From 40c80e36b1a204ed133acc403016a6cb1a92051e Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Tue, 19 Dec 2023 16:52:35 -0500 Subject: [PATCH] wallettool: Don't unilaterally reset wallet_instance if loading error When there is a wallet loading error, it could be a noncritical one so it is not necessary to make wallet_instance a nullptr. The wallet can still go on with normal operation in that case, as we do for loading in bitcoind and bitcoin-qt. --- src/wallet/wallettool.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/wallet/wallettool.cpp b/src/wallet/wallettool.cpp index 2f3f8ef77de..c8deda89b56 100644 --- a/src/wallet/wallettool.cpp +++ b/src/wallet/wallettool.cpp @@ -68,7 +68,6 @@ static std::shared_ptr MakeWallet(const std::string& name, const fs::pa } if (load_wallet_ret != DBErrors::LOAD_OK) { - wallet_instance = nullptr; if (load_wallet_ret == DBErrors::CORRUPT) { tfm::format(std::cerr, "Error loading %s: Wallet corrupted", name); return nullptr;