From 6d118302654481927e864a428950960e26eb7f4a Mon Sep 17 00:00:00 2001 From: Cory Fields Date: Tue, 4 Apr 2023 20:34:58 +0000 Subject: [PATCH] verifybinaries: remove awkward bitcoin-core prefix handling --- contrib/verifybinaries/README.md | 8 +++----- contrib/verifybinaries/verify.py | 7 ++----- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/contrib/verifybinaries/README.md b/contrib/verifybinaries/README.md index 4f2722b23f4..c2b8d2f2dc5 100644 --- a/contrib/verifybinaries/README.md +++ b/contrib/verifybinaries/README.md @@ -44,8 +44,6 @@ Validate releases with default settings: ```sh ./contrib/verifybinaries/verify.py pub 22.0 ./contrib/verifybinaries/verify.py pub 22.0-rc2 -./contrib/verifybinaries/verify.py pub bitcoin-core-23.0 -./contrib/verifybinaries/verify.py pub bitcoin-core-23.0-rc1 ``` Get JSON output and don't prompt for user input (no auto key import): @@ -66,12 +64,12 @@ specified keys, while requiring a threshold of at least 10 trusted signatures: If you only want to download the binaries of certain platform, add the corresponding suffix, e.g.: ```sh -./contrib/verifybinaries/verify.py pub bitcoin-core-22.0-osx -./contrib/verifybinaries/verify.py pub bitcoin-core-22.0-rc2-win64 +./contrib/verifybinaries/verify.py pub 22.0-osx +./contrib/verifybinaries/verify.py pub 22.0-rc2-win64 ``` If you do not want to keep the downloaded binaries, specify anything as the second parameter. ```sh -./contrib/verifybinaries/verify.py pub bitcoin-core-22.0 delete +./contrib/verifybinaries/verify.py pub 22.0 delete ``` diff --git a/contrib/verifybinaries/verify.py b/contrib/verifybinaries/verify.py index 83370fbede1..e5e171d58d1 100755 --- a/contrib/verifybinaries/verify.py +++ b/contrib/verifybinaries/verify.py @@ -99,9 +99,6 @@ VERSION_FORMAT = ".[.][-rc[0-9]][-platform]" VERSION_EXAMPLE = "22.0-x86_64 or 0.21.0-rc2-osx" def parse_version_string(version_str): - if version_str.startswith(VERSIONPREFIX): # remove version prefix - version_str = version_str[len(VERSIONPREFIX):] - parts = version_str.split('-') version_base = parts[0] version_rc = "" @@ -290,8 +287,8 @@ def get_files_from_hosts_and_compare( log.error( f"couldn't fetch file ({url}). " "Have you specified the version number in the following format?\n" - f"[{VERSIONPREFIX}]{VERSION_FORMAT} " - f"(example: {VERSIONPREFIX}{VERSION_EXAMPLE})\n" + f"{VERSION_FORMAT} " + f"(example: {VERSION_EXAMPLE})\n" f"wget output:\n{indent(output)}") return ReturnCode.FILE_GET_FAILED else: