mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-05 14:06:27 -05:00
multiprocess: Make interfaces::Chain::isTaprootActive non-const
interfaces::Chain is an abstract class, so declaring the method const would be exposing internal implementation details of subclasses to interface callers. And specifically this doesn't work because the multiprocess implementation of the interfaces::Chain::isTaprootActive method can't be const because IPC connection state and request state is not constant during the call.
This commit is contained in:
parent
6ef84e0503
commit
7e88f61b28
2 changed files with 2 additions and 2 deletions
|
@ -289,7 +289,7 @@ public:
|
|||
virtual void requestMempoolTransactions(Notifications& notifications) = 0;
|
||||
|
||||
//! Check if Taproot has activated
|
||||
virtual bool isTaprootActive() const = 0;
|
||||
virtual bool isTaprootActive() = 0;
|
||||
};
|
||||
|
||||
//! Interface to let node manage chain clients (wallets, or maybe tools for
|
||||
|
|
|
@ -698,7 +698,7 @@ public:
|
|||
notifications.transactionAddedToMempool(entry.GetSharedTx(), 0 /* mempool_sequence */);
|
||||
}
|
||||
}
|
||||
bool isTaprootActive() const override
|
||||
bool isTaprootActive() override
|
||||
{
|
||||
LOCK(::cs_main);
|
||||
const CBlockIndex* tip = Assert(m_node.chainman)->ActiveChain().Tip();
|
||||
|
|
Loading…
Add table
Reference in a new issue