Replace the LogPrint function with a macro

Calling LogPrint with a category that is not enabled results in
evaluating the remaining function arguments, which may be arbitrarily
complex (and possibly expensive) expressions. Defining LogPrint as a
macro prevents this unnecessary expression evaluation.

This is a partial revert of #14209. The decision to revert is discussed
in #16688, which adds verbose logging for validation event notification.

src/logging.h

@@ -155,12 +155,13 @@ static inline void LogPrintf(const char* fmt, const Args&... args)
     }
 }
 
-template <typename... Args>
+// Use a macro instead of a function for conditional logging to prevent
-static inline void LogPrint(const BCLog::LogFlags& category, const Args&... args)
+// evaluating arguments when logging for the category is not enabled.
-{
+#define LogPrint(category, ...)              \
-    if (LogAcceptCategory((category))) {
+    do {                                     \
-        LogPrintf(args...);
+        if (LogAcceptCategory((category))) { \
-    }
+            LogPrintf(__VA_ARGS__);          \
-}
+        }                                    \
+    } while (0)
 
 #endif // BITCOIN_LOGGING_H