foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

refactor: use std::string for thread names

Browse source
This commit is contained in:
stickies-v 2022-08-31 16:30:35 +01:00
parent 29d540b7ad
commit 97f5b20c12
No known key found for this signature in database
GPG key ID: 5CB1CE6E5E66A757
5 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/qt/guiutil.cpp
View file

@ -982,7 +982,7 @@ void PrintSlotException(
std::string description = sender->metaObject()->className();
description += "->";
description += receiver->metaObject()->className();
PrintExceptionContinue(exception, description.c_str());
PrintExceptionContinue(exception, description);
}
void ShowModalDialogAsynchronously(QDialog* dialog)

4
src/util/system.cpp
View file

@ -831,7 +831,7 @@ std::string HelpMessageOpt(const std::string &option, const std::string &message
std::string("\n\n");
}
static std::string FormatException(const std::exception* pex, const char* pszThread)
static std::string FormatException(const std::exception* pex, std::string_view pszThread)
{
#ifdef WIN32
char pszModule[MAX_PATH] = "";
@ -847,7 +847,7 @@ static std::string FormatException(const std::exception* pex, const char* pszThr
"UNKNOWN EXCEPTION \n%s in %s \n", pszModule, pszThread);
}
void PrintExceptionContinue(const std::exception* pex, const char* pszThread)
void PrintExceptionContinue(const std::exception* pex, std::string_view pszThread)
{
std::string message = FormatException(pex, pszThread);
LogPrintf("\n\n************************\n%s\n", message);

2
src/util/system.h
View file

@ -51,7 +51,7 @@ bool error(const char* fmt, const Args&... args)
return false;
}
void PrintExceptionContinue(const std::exception *pex, const char* pszThread);
void PrintExceptionContinue(const std::exception* pex, std::string_view pszThread);
/**
* Ensure file contents are fully committed to disk, using a platform-specific

6
src/util/thread.cpp
View file

@ -10,10 +10,12 @@
#include <exception>
#include <functional>
#include <string>
#include <utility>
void util::TraceThread(const char* thread_name, std::function<void()> thread_func)
void util::TraceThread(std::string_view thread_name, std::function<void()> thread_func)
{
util::ThreadRename(thread_name);
util::ThreadRename(std::string{thread_name});
try {
LogPrintf("%s thread start\n", thread_name);
thread_func();

3
src/util/thread.h
View file

@ -6,12 +6,13 @@
#define BITCOIN_UTIL_THREAD_H
#include <functional>
#include <string>
namespace util {
/**
* A wrapper for do-something-once thread functions.
*/
void TraceThread(const char* thread_name, std::function<void()> thread_func);
void TraceThread(std::string_view thread_name, std::function<void()> thread_func);
} // namespace util