foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

[coin selection] consolidate m_change_target and m_min_change_target

Browse source 
These values are both intended for the same thing. Their divergence
seems to be the result of an incomplete rename.
This commit is contained in:
glozow 2022-08-11 15:23:15 +01:00
parent dd62721ba9
commit acda7e8686
No known key found for this signature in database
GPG key ID: BA03F4DBE0C63FB4
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wallet/coinselection.h
View file

@ -125,8 +125,6 @@ struct CoinSelectionParams {
CAmount m_min_change_target{0}; CAmount m_min_change_target{0};
/** Cost of creating the change output. */ /** Cost of creating the change output. */
CAmount m_change_fee{0}; CAmount m_change_fee{0};
/** The pre-determined minimum value to target when funding a change output. */
CAmount m_change_target{0};
/** Cost of creating the change output + cost of spending the change output in the future. */ /** Cost of creating the change output + cost of spending the change output in the future. */
CAmount m_cost_of_change{0}; CAmount m_cost_of_change{0};
/** The targeted feerate of the transaction being built. */ /** The targeted feerate of the transaction being built. */

2
src/wallet/spend.cpp
View file

@ -794,7 +794,7 @@ static util::Result<CreatedTransactionResult> CreateTransactionInternal(
coin_selection_params.m_subtract_fee_outputs = true; coin_selection_params.m_subtract_fee_outputs = true;
} }
} }
coin_selection_params.m_change_target = GenerateChangeTarget(std::floor(recipients_sum / vecSend.size()), rng_fast); coin_selection_params.m_min_change_target = GenerateChangeTarget(std::floor(recipients_sum / vecSend.size()), rng_fast);
// Create change script that will be used if we need change // Create change script that will be used if we need change
CScript scriptChange; CScript scriptChange;