foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

txdb: don't reset during in-memory cache resize

Browse source 
We can't support a reset of the dbwrapper object when in-memory configuration is used
because it results in the permanent loss of coins. This only affects unittest
configurations (since that's the only place we use in-memory CCoinsViewDB instances).
This commit is contained in:
James O'Beirne 2020-08-25 13:48:21 -04:00
parent f6e2da5fb7
commit ad949ba449
No known key found for this signature in database
GPG key ID: 7A935DADB2C44F05
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/txdb.cpp
View file

@ -47,12 +47,16 @@ CCoinsViewDB::CCoinsViewDB(fs::path ldb_path, size_t nCacheSize, bool fMemory, b
void CCoinsViewDB::ResizeCache(size_t new_cache_size) void CCoinsViewDB::ResizeCache(size_t new_cache_size)
{ {
// We can't do this operation with an in-memory DB since we'll lose all the coins upon
// reset.
if (!m_is_memory) {
// Have to do a reset first to get the original `m_db` state to release its // Have to do a reset first to get the original `m_db` state to release its
// filesystem lock. // filesystem lock.
m_db.reset(); m_db.reset();
m_db = MakeUnique<CDBWrapper>( m_db = MakeUnique<CDBWrapper>(
m_ldb_path, new_cache_size, m_is_memory, /*fWipe*/ false, /*obfuscate*/ true); m_ldb_path, new_cache_size, m_is_memory, /*fWipe*/ false, /*obfuscate*/ true);
} }
}
bool CCoinsViewDB::GetCoin(const COutPoint &outpoint, Coin &coin) const { bool CCoinsViewDB::GetCoin(const COutPoint &outpoint, Coin &coin) const {
return m_db->Read(CoinEntry(&outpoint), coin); return m_db->Read(CoinEntry(&outpoint), coin);