foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-04 13:55:23 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#28513: ci: Install Homebrew's pkg-config package

Browse source 
43cd8029fa ci: Install Homebrew's `pkg-config` package (Hennadii Stepanov)

Pull request description:

  Some versions of macOS images lack the `pkg-config` package.

  For example, https://github.com/bitcoin/bitcoin/actions/runs/6248032071/job/16961797066:
  ```
  Runner Image
    Image: macos-13
    Version: 20230417.1
  ```

  ```
  + ./autogen.sh
  configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
  ```

  This PR makes Homebrew install the `pkg-config` package explicitly.

  Also please refer to [macOS Build Guide](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md).

ACKs for top commit:
  kevkevinpal:
    ACK [43cd802](43cd8029fa)
  MarcoFalke:
    lgtm ACK 43cd8029fa
  RandyMcMillan:
    ACK 43cd802

Tree-SHA512: 2b934b22e5f6748634089e0525b92219484e37b2afc11e9fd4c53faf112b33ca1c8deb5b4aa36939bf5c4807e7599d4aabae6335317ecc5d4a4d562bbd7dbdf2
This commit is contained in:
fanquake 2023-09-21 16:32:34 +00:00
commit b66f6dcb26
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View file

@ -68,7 +68,7 @@ jobs:
run: clang --version
- name: Install Homebrew packages
run: brew install boost libevent qt@5 miniupnpc libnatpmp ccache zeromq qrencode libtool automake gnu-getopt
run: brew install automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencode
- name: Set Ccache directory
run: echo "CCACHE_DIR=${RUNNER_TEMP}/ccache_dir" >> "$GITHUB_ENV"