foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

Merge bitcoin/bitcoin#30552: test: fix constructor of msg_tx

Browse source 
ec5e294e4b test: fix constructor of msg_tx (Martin Zumsande)

Pull request description:

  In python, if the default value is a mutable object (here: a class) it is shared over all instances, so that one instance being changed would affect others to be changed as well.
  This was the source of #30543, and possibly various other intermittent bugs in the functional tests, see
  https://github.com/bitcoin/bitcoin/issues/29621#issuecomment-1999298224.

  Fixes #30543
  Fixes #29621
  Fixes #25128

ACKs for top commit:
  sipa:
    utACK ec5e294e4b. I believe some linters even warn about doing this.
  maflcko:
    ACK ec5e294e4b
  vasild:
    ACK ec5e294e4b ❤️
  theStack:
    ACK ec5e294e4b

Tree-SHA512: a6204fb1a326de3f9aa965f345fd658f6a4dcf78731db25cc905ff6eb8d4eeb65d14cc316305eebd89387aec8748c57c3a4f4ca62408f8e5ee53f535b88b1411
This commit is contained in:
merge-script 2024-07-31 12:01:33 +01:00
commit be969292db
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
test/functional/test_framework/messages.py
View file

@ -1294,8 +1294,11 @@ class msg_tx:
__slots__ = ("tx",) __slots__ = ("tx",)
msgtype = b"tx" msgtype = b"tx"
def __init__(self, tx=CTransaction()): def __init__(self, tx=None):
self.tx = tx if tx is None:
self.tx = CTransaction()
else:
self.tx = tx
def deserialize(self, f): def deserialize(self, f):
self.tx.deserialize(f) self.tx.deserialize(f)