diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 19ef038c7a6..f14bc6e21c0 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -3124,17 +3124,17 @@ std::shared_ptr CWallet::Create(WalletContext& context, const std::stri } if (args.IsArgSet("-maxapsfee")) { - const std::string max_aps_fee{args.GetArg("-maxapsfee", "")}; - if (max_aps_fee == "-1") { + const std::string max_aps_fee_str{args.GetArg("-maxapsfee", "")}; + if (max_aps_fee_str == "-1") { walletInstance->m_max_aps_fee = -1; - } else if (std::optional max_fee = ParseMoney(max_aps_fee)) { - if (max_fee.value() > HIGH_APS_FEE) { + } else if (std::optional max_aps_fee = ParseMoney(max_aps_fee_str)) { + if (max_aps_fee.value() > HIGH_APS_FEE) { warnings.push_back(AmountHighWarn("-maxapsfee") + Untranslated(" ") + _("This is the maximum transaction fee you pay (in addition to the normal fee) to prioritize partial spend avoidance over regular coin selection.")); } - walletInstance->m_max_aps_fee = max_fee.value(); + walletInstance->m_max_aps_fee = max_aps_fee.value(); } else { - error = AmountErrMsg("maxapsfee", max_aps_fee); + error = AmountErrMsg("maxapsfee", max_aps_fee_str); return nullptr; } } @@ -3186,21 +3186,21 @@ std::shared_ptr CWallet::Create(WalletContext& context, const std::stri } if (args.IsArgSet("-maxtxfee")) { - std::optional max_fee = ParseMoney(args.GetArg("-maxtxfee", "")); - if (!max_fee) { + std::optional max_tx_fee = ParseMoney(args.GetArg("-maxtxfee", "")); + if (!max_tx_fee) { error = AmountErrMsg("maxtxfee", args.GetArg("-maxtxfee", "")); return nullptr; - } else if (max_fee.value() > HIGH_MAX_TX_FEE) { + } else if (max_tx_fee.value() > HIGH_MAX_TX_FEE) { warnings.push_back(strprintf(_("%s is set very high! Fees this large could be paid on a single transaction."), "-maxtxfee")); } - if (chain && CFeeRate{max_fee.value(), 1000} < chain->relayMinFee()) { + if (chain && CFeeRate{max_tx_fee.value(), 1000} < chain->relayMinFee()) { error = strprintf(_("Invalid amount for %s=: '%s' (must be at least the minrelay fee of %s to prevent stuck transactions)"), "-maxtxfee", args.GetArg("-maxtxfee", ""), chain->relayMinFee().ToString()); return nullptr; } - walletInstance->m_max_tx_fee = max_fee.value(); + walletInstance->m_max_tx_fee = max_tx_fee.value(); } if (args.IsArgSet("-consolidatefeerate")) {