foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

doc: update developer notes wrt unix epoch time

Browse source
This commit is contained in:
Jon Atack 2019-12-03 18:35:16 +01:00
parent e2f32cb5c5
commit d94d34f05f
No known key found for this signature in database
GPG key ID: 4F5721B3D0E3921D
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
doc/developer-notes.md
View file

@ -1014,7 +1014,7 @@ A few guidelines for introducing and reviewing new RPC interfaces:
- A RPC method must either be a wallet method or a non-wallet method. Do not - A RPC method must either be a wallet method or a non-wallet method. Do not
introduce new methods that differ in behavior based on the presence of a wallet. introduce new methods that differ in behavior based on the presence of a wallet.
- *Rationale*: as well as complicating the implementation and interfering - *Rationale*: As well as complicating the implementation and interfering
with the introduction of multi-wallet, wallet and non-wallet code should be with the introduction of multi-wallet, wallet and non-wallet code should be
separated to avoid introducing circular dependencies between code units. separated to avoid introducing circular dependencies between code units.
@ -1041,8 +1041,13 @@ A few guidelines for introducing and reviewing new RPC interfaces:
- *Rationale*: RPC methods registered with the same function pointer will be - *Rationale*: RPC methods registered with the same function pointer will be
considered aliases and only the first method name will show up in the considered aliases and only the first method name will show up in the
`help` rpc command list. `help` RPC command list.
- *Exception*: Using RPC method aliases may be appropriate in cases where a - *Exception*: Using RPC method aliases may be appropriate in cases where a
new RPC is replacing a deprecated RPC, to avoid both RPCs confusingly new RPC is replacing a deprecated RPC, to avoid both RPCs confusingly
showing up in the command list. showing up in the command list.
- Use the `UNIX_EPOCH_TIME` constant when describing UNIX epoch time or
timestamps in the documentation.
- *Rationale*: User-facing consistency.