diff --git a/src/test/crypto_tests.cpp b/src/test/crypto_tests.cpp index 52ac7cff5be..0a6378adf47 100644 --- a/src/test/crypto_tests.cpp +++ b/src/test/crypto_tests.cpp @@ -226,10 +226,9 @@ static void TestPoly1305(const std::string &hexmessage, const std::string &hexke { auto key = ParseHex(hexkey); auto m = ParseHex(hexmessage); - auto tag = ParseHex(hextag); std::vector tagres(Poly1305::TAGLEN); Poly1305{key}.Update(m).Finalize(tagres); - BOOST_CHECK(tag == tagres); + BOOST_CHECK_EQUAL(HexStr(tagres), hextag); // Test incremental interface for (int splits = 0; splits < 10; ++splits) { @@ -243,7 +242,7 @@ static void TestPoly1305(const std::string &hexmessage, const std::string &hexke } tagres.assign(Poly1305::TAGLEN, std::byte{}); poly1305.Update(data).Finalize(tagres); - BOOST_CHECK(tag == tagres); + BOOST_CHECK_EQUAL(HexStr(tagres), hextag); } } } @@ -922,15 +921,15 @@ BOOST_AUTO_TEST_CASE(poly1305_testvector) auto total_key = ParseHex("01020304050607fffefdfcfbfaf9ffffffffffffffffffffffffffff00000000"); Poly1305 total_ctx(total_key); for (unsigned i = 0; i < 256; ++i) { - std::vector key(32, std::byte{(uint8_t)i}); - std::vector msg(i, std::byte{(uint8_t)i}); + std::vector key(32, std::byte{uint8_t(i)}); + std::vector msg(i, std::byte{uint8_t(i)}); std::array tag; Poly1305{key}.Update(msg).Finalize(tag); total_ctx.Update(tag); } std::vector total_tag(Poly1305::TAGLEN); total_ctx.Finalize(total_tag); - BOOST_CHECK(total_tag == ParseHex("64afe2e8d6ad7bbdd287f97c44623d39")); + BOOST_CHECK_EQUAL(HexStr(total_tag), "64afe2e8d6ad7bbdd287f97c44623d39"); } // Tests with sparse messages and random keys.