From deccf1c4848620cfff2a9642c5a6b5acdfbc33bd Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Thu, 13 Jul 2023 13:01:54 -0600 Subject: [PATCH] Move IsPeerAddrLocalGood() declaration from header to implementation --- src/net.cpp | 2 +- src/net.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/net.cpp b/src/net.cpp index 1b1b5404177..e8567348f66 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -223,7 +223,7 @@ static int GetnScore(const CService& addr) } // Is our peer's addrLocal potentially useful as an external IP source? -bool IsPeerAddrLocalGood(CNode *pnode) +[[nodiscard]] static bool IsPeerAddrLocalGood(CNode *pnode) { CService addrLocal = pnode->GetAddrLocal(); return fDiscover && pnode->addr.IsRoutable() && addrLocal.IsRoutable() && diff --git a/src/net.h b/src/net.h index 7427d0f45b7..e26bf523e8b 100644 --- a/src/net.h +++ b/src/net.h @@ -145,7 +145,6 @@ enum LOCAL_MAX }; -bool IsPeerAddrLocalGood(CNode *pnode); /** Returns a local address that we should advertise to this peer. */ std::optional GetLocalAddrForPeer(CNode& node);