From e417c988f61bf9d3948d5c8e169626922fe6e24c Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Fri, 4 Aug 2023 13:55:54 +0200 Subject: [PATCH] fuzz: coins_view: remove an incorrect assertion Again, this was not hit because the default implementation of `CCoinsView` return `false` for `GetCoin`. --- src/test/fuzz/coins_view.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/fuzz/coins_view.cpp b/src/test/fuzz/coins_view.cpp index c0dff7e4854..b088aa0bd7b 100644 --- a/src/test/fuzz/coins_view.cpp +++ b/src/test/fuzz/coins_view.cpp @@ -163,7 +163,8 @@ FUZZ_TARGET(coins_view, .init = initialize_coins_view) Coin coin_using_backend_get_coin; if (backend_coins_view.GetCoin(random_out_point, coin_using_backend_get_coin)) { assert(exists_using_have_coin_in_backend); - assert(coin_using_get_coin == coin_using_backend_get_coin); + // Note we can't assert that `coin_using_get_coin == coin_using_backend_get_coin` because the coin in + // the cache may have been modified but not yet flushed. } else { assert(!exists_using_have_coin_in_backend); }