foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

refactor: CTxMemPool::ClearPrioritisation() requires CTxMemPool::cs lock

Browse source 
No change in behavior, the lock is already held at call sites.
Also `const uint256` refactored to `const uint256&`.
This commit is contained in:
Hennadii Stepanov 2020-09-01 12:30:21 +03:00
parent 7140b31b90
commit fa5fcb032b
No known key found for this signature in database
GPG key ID: 410108112E7EA81F
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/txmempool.cpp
View file

@ -862,9 +862,9 @@ void CTxMemPool::ApplyDelta(const uint256& hash, CAmount &nFeeDelta) const
nFeeDelta += delta; nFeeDelta += delta;
} }
void CTxMemPool::ClearPrioritisation(const uint256 hash) void CTxMemPool::ClearPrioritisation(const uint256& hash)
{ {
LOCK(cs); AssertLockHeld(cs);
mapDeltas.erase(hash); mapDeltas.erase(hash);
} }

2
src/txmempool.h
View file

@ -627,7 +627,7 @@ public:
/** Affect CreateNewBlock prioritisation of transactions */ /** Affect CreateNewBlock prioritisation of transactions */
void PrioritiseTransaction(const uint256& hash, const CAmount& nFeeDelta); void PrioritiseTransaction(const uint256& hash, const CAmount& nFeeDelta);
void ApplyDelta(const uint256& hash, CAmount &nFeeDelta) const EXCLUSIVE_LOCKS_REQUIRED(cs); void ApplyDelta(const uint256& hash, CAmount &nFeeDelta) const EXCLUSIVE_LOCKS_REQUIRED(cs);
void ClearPrioritisation(const uint256 hash); void ClearPrioritisation(const uint256& hash) EXCLUSIVE_LOCKS_REQUIRED(cs);
/** Get the transaction in the pool that spends the same prevout */ /** Get the transaction in the pool that spends the same prevout */
const CTransaction* GetConflictTx(const COutPoint& prevout) const EXCLUSIVE_LOCKS_REQUIRED(cs); const CTransaction* GetConflictTx(const COutPoint& prevout) const EXCLUSIVE_LOCKS_REQUIRED(cs);