foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

test: Treat exclude list warning as failure in CI

Browse source
This commit is contained in:
MarcoFalke 2024-10-02 15:13:55 +02:00
parent fc642c33ef
commit fa6d14eacb
No known key found for this signature in database
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
test/functional/test_runner.py
View file

@ -446,8 +446,8 @@ def main():
help="Leave bitcoinds and test.* datadir on exit or error") help="Leave bitcoinds and test.* datadir on exit or error")
parser.add_argument('--resultsfile', '-r', help='store test results (as CSV) to the provided file') parser.add_argument('--resultsfile', '-r', help='store test results (as CSV) to the provided file')
args, unknown_args = parser.parse_known_args() args, unknown_args = parser.parse_known_args()
fail_on_warn = args.ci
if not args.ansi: if not args.ansi:
global DEFAULT, BOLD, GREEN, RED global DEFAULT, BOLD, GREEN, RED
DEFAULT = ("", "") DEFAULT = ("", "")
@ -524,8 +524,12 @@ def main():
# Remove the test cases that the user has explicitly asked to exclude. # Remove the test cases that the user has explicitly asked to exclude.
# The user can specify a test case with or without the .py extension. # The user can specify a test case with or without the .py extension.
if args.exclude: if args.exclude:
def print_warning_missing_test(test_name): def print_warning_missing_test(test_name):
print("{}WARNING!{} Test '{}' not found in current test list.".format(BOLD[1], BOLD[0], test_name)) print("{}WARNING!{} Test '{}' not found in current test list. Check the --exclude list.".format(BOLD[1], BOLD[0], test_name))
if fail_on_warn:
sys.exit(1)
def remove_tests(exclude_list): def remove_tests(exclude_list):
if not exclude_list: if not exclude_list:
print_warning_missing_test(exclude_test) print_warning_missing_test(exclude_test)
@ -562,7 +566,7 @@ def main():
f"A minimum of {MIN_NO_CLEANUP_SPACE // (1024 * 1024 * 1024)} GB of free space is required.") f"A minimum of {MIN_NO_CLEANUP_SPACE // (1024 * 1024 * 1024)} GB of free space is required.")
passon_args.append("--nocleanup") passon_args.append("--nocleanup")
check_script_list(src_dir=config["environment"]["SRCDIR"], fail_on_warn=args.ci) check_script_list(src_dir=config["environment"]["SRCDIR"], fail_on_warn=fail_on_warn)
check_script_prefixes() check_script_prefixes()
if not args.keepcache: if not args.keepcache:
@ -871,7 +875,6 @@ def check_script_list(*, src_dir, fail_on_warn):
if len(missed_tests) != 0: if len(missed_tests) != 0:
print("%sWARNING!%s The following scripts are not being run: %s. Check the test lists in test_runner.py." % (BOLD[1], BOLD[0], str(missed_tests))) print("%sWARNING!%s The following scripts are not being run: %s. Check the test lists in test_runner.py." % (BOLD[1], BOLD[0], str(missed_tests)))
if fail_on_warn: if fail_on_warn:
# On CI this warning is an error to prevent merging incomplete commits into master
sys.exit(1) sys.exit(1)