foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

Clarify that COutput is a struct, not a class

Browse source 
Also, use {}-initialization
This commit is contained in:
MarcoFalke 2022-03-25 10:08:59 +01:00
parent fa61cdf464
commit fab287cedd
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/wallet/coinselection.h
View file

@ -19,9 +19,7 @@ static constexpr CAmount MIN_CHANGE{COIN / 100};
static const CAmount MIN_FINAL_CHANGE = MIN_CHANGE/2; static const CAmount MIN_FINAL_CHANGE = MIN_CHANGE/2;
/** A UTXO under consideration for use in funding a new transaction. */ /** A UTXO under consideration for use in funding a new transaction. */
class COutput struct COutput {
{
public:
/** The outpoint identifying this UTXO */ /** The outpoint identifying this UTXO */
COutPoint outpoint; COutPoint outpoint;
@ -67,21 +65,22 @@ public:
CAmount long_term_fee{0}; CAmount long_term_fee{0};
COutput(const COutPoint& outpoint, const CTxOut& txout, int depth, int input_bytes, bool spendable, bool solvable, bool safe, int64_t time, bool from_me) COutput(const COutPoint& outpoint, const CTxOut& txout, int depth, int input_bytes, bool spendable, bool solvable, bool safe, int64_t time, bool from_me)
: outpoint(outpoint), : outpoint{outpoint},
txout(txout), txout{txout},
depth(depth), depth{depth},
input_bytes(input_bytes), input_bytes{input_bytes},
spendable(spendable), spendable{spendable},
solvable(solvable), solvable{solvable},
safe(safe), safe{safe},
time(time), time{time},
from_me(from_me), from_me{from_me},
effective_value(txout.nValue) effective_value{txout.nValue}
{} {}
std::string ToString() const; std::string ToString() const;
bool operator<(const COutput& rhs) const { bool operator<(const COutput& rhs) const
{
return outpoint < rhs.outpoint; return outpoint < rhs.outpoint;
} }
}; };