foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

lint: Remove forbidden functions from lint-format-strings.py

Browse source 
Given that all of them are forbidden by the
test/lint/lint-locale-dependence.py check, they can be removed.
This commit is contained in:
MarcoFalke 2024-09-10 21:55:23 +02:00
parent 2756797eca
commit fae7b83eb5
No known key found for this signature in database
2 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/lint/lint-format-strings.py
View file

@ -17,7 +17,6 @@ import sys
FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [
'FatalErrorf,0', 'FatalErrorf,0',
'fprintf,1',
'tfm::format,1', # Assuming tfm::::format(std::ostream&, ... 'tfm::format,1', # Assuming tfm::::format(std::ostream&, ...
'LogConnectFailure,1', 'LogConnectFailure,1',
'LogError,0', 'LogError,0',
@ -27,14 +26,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [
'LogTrace,1', 'LogTrace,1',
'LogPrintf,0', 'LogPrintf,0',
'LogPrintLevel,2', 'LogPrintLevel,2',
'printf,0',
'snprintf,2',
'sprintf,1',
'strprintf,0', 'strprintf,0',
'vfprintf,1',
'vprintf,1',
'vsnprintf,1',
'vsprintf,1',
'WalletLogPrintf,0', 'WalletLogPrintf,0',
] ]
RUN_LINT_FILE = 'test/lint/run-lint-format-strings.py' RUN_LINT_FILE = 'test/lint/run-lint-format-strings.py'

1
test/lint/run-lint-format-strings.py
View file

@ -13,7 +13,6 @@ import re
import sys import sys
FALSE_POSITIVES = [ FALSE_POSITIVES = [
("src/dbwrapper.cpp", "vsnprintf(p, limit - p, format, backup_ap)"),
("src/index/base.cpp", "FatalErrorf(const char* fmt, const Args&... args)"), ("src/index/base.cpp", "FatalErrorf(const char* fmt, const Args&... args)"),
("src/index/base.h", "FatalErrorf(const char* fmt, const Args&... args)"), ("src/index/base.h", "FatalErrorf(const char* fmt, const Args&... args)"),
("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"), ("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"),