foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

wallet: Fix use-after-free in WalletBatch::EraseRecords

Browse source
This commit is contained in:
MarcoFalke 2024-01-04 12:18:07 +01:00
parent 65c05db660
commit faebf1df2a
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/wallet/walletdb.cpp
View file

@ -1401,13 +1401,13 @@ bool WalletBatch::EraseRecords(const std::unordered_set<std::string>& types)
} }
// Make a copy of key to avoid data being deleted by the following read of the type // Make a copy of key to avoid data being deleted by the following read of the type
Span key_data{key}; const SerializeData key_data{key.begin(), key.end()};
std::string type; std::string type;
key >> type; key >> type;
if (types.count(type) > 0) { if (types.count(type) > 0) {
if (!m_batch->Erase(key_data)) { if (!m_batch->Erase(Span{key_data})) {
cursor.reset(nullptr); cursor.reset(nullptr);
m_batch->TxnAbort(); m_batch->TxnAbort();
return false; // erase failed return false; // erase failed