merge-script 0f6d20e43f Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} ... 4120c7543e scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} (Sebastian Falbesoner) Pull request description: The confusing "command" terminology for the 12-byte field in the (v1) p2p message header was replaced with the more proper term "message type" in other modules already years ago, see eg #18533, #18937, #24078, #24141. This PR does the same for the protocol.{h,cpp} module to complete the replacements. Note that "GetCommand" is a method name also used in the `ArgsManager` (there it makes much more sense), so the scripted-diff lists for this replacement the files explicitly, rather than using `$(git grep -l ...)`. ACKs for top commit: maflcko: review ACK 4120c7543e 🛒 fjahr: Code review ACK 4120c7543e rkrux: tACK 4120c7543e Tree-SHA512: 7b4dd30136392a145da95d2f3ba181c18c155ba6f3158e49e622d76811c6a45ef9b5c7539a979a04d8404faf18bb27f11457aa436d4e2998ece3deb2c9e59748		2024-11-11 10:54:20 +00:00
..
bench	bench: add coverage for wallet migration process	2024-10-21 08:29:22 -03:00
common	Merge bitcoin/bitcoin#31156: test: Don't enforce BIP94 on regtest unless specified by arg	2024-10-30 17:00:14 -04:00
compat
config
consensus	Move BlockMerkleBranch back to merkle.{h,cpp}	2024-09-26 09:48:31 +02:00
crc32c
crypto	scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h	2024-10-10 12:22:12 +02:00
index	refactor: Split up NodeContext shutdown_signal and shutdown_request	2024-10-01 09:10:54 +02:00
init	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
interfaces	interfaces: remove now unused 'use_upnp' arg from 'mapPort'	2024-10-24 18:23:30 +02:00
ipc	Add submitSolution to BlockTemplate interface	2024-09-26 10:04:45 +02:00
kernel	Merge bitcoin/bitcoin#30592: Remove mempoolfullrbf	2024-11-08 13:51:29 -05:00
leveldb
logging	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
minisketch
node	Merge bitcoin/bitcoin#30592: Remove mempoolfullrbf	2024-11-08 13:51:29 -05:00
policy	fees: Log non-fatal errors as [warning], instead of info-level	2024-10-23 18:43:32 +02:00
primitives
qt	Merge bitcoin/bitcoin#29686: Update manpage descriptions	2024-11-08 13:34:59 -05:00
rpc	Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}	2024-11-11 10:54:20 +00:00
script	Fix unsigned integer overflows in interpreter	2024-10-01 10:45:44 +02:00
secp256k1	Update secp256k1 subtree to v0.6.0	2024-11-04 14:59:46 -05:00
support	cleanse: Use SecureZeroMemory for mingw-w64 (release) builds	2024-07-24 09:57:49 +01:00
test	Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}	2024-11-11 10:54:20 +00:00
univalue	build: Remove Autotools-based build system	2024-08-30 21:31:39 +01:00
util	Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing	2024-11-11 10:33:28 +00:00
wallet	Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing	2024-11-11 10:33:28 +00:00
zmq	cmake: Add FindZeroMQ module	2024-10-25 18:09:36 +01:00
.clang-format
.clang-tidy	tidy: add clang-tidy modernize-use-starts-ends-with check	2024-09-14 20:33:32 +03:00
addrdb.cpp	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
addrdb.h
addresstype.cpp	policy: Add OP_1 <0x4e73> as a standard output type	2024-07-30 14:06:58 -04:00
addresstype.h	policy: Add OP_1 <0x4e73> as a standard output type	2024-07-30 14:06:58 -04:00
addrman.cpp	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
addrman.h	addrman: change Select to support multiple networks	2024-09-10 12:58:54 -03:00
addrman_impl.h	Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t	2024-09-20 12:55:22 -04:00
arith_uint256.cpp
arith_uint256.h	doc + test: Correct uint256 hex string endianness	2024-08-03 21:59:54 +02:00
attributes.h
banman.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
banman.h
base58.cpp
base58.h
bech32.cpp	fuzz: replace hardcoded numbers for bech32 limits	2024-08-06 11:03:31 +02:00
bech32.h	fuzz: replace hardcoded numbers for bech32 limits	2024-08-06 11:03:31 +02:00
bip324.cpp
bip324.h
bitcoin-chainstate.cpp	kernel: Move background load thread to node context	2024-09-13 16:10:31 +02:00
bitcoin-cli-res.rc	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp	Merge bitcoin/bitcoin#29686: Update manpage descriptions	2024-11-08 13:34:59 -05:00
bitcoin-tx-res.rc	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp	doc: add bitcoin-tx man description	2024-10-30 10:18:40 +00:00
bitcoin-util-res.rc	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
bitcoin-util.cpp	doc: add bitcoin-util man description	2024-10-30 10:18:41 +00:00
bitcoin-wallet-res.rc	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp	doc: add bitcoin-wallet man description	2024-10-30 10:18:39 +00:00
bitcoind-res.rc	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
bitcoind.cpp	doc: add bitcoind man description	2024-10-30 10:18:36 +00:00
blockencodings.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
blockencodings.h
blockfilter.cpp
blockfilter.h
chain.cpp
chain.h	doc: update NeedsRedownload() comment	2024-09-17 09:54:18 +02:00
chainparams.cpp	test: Don't enforce BIP94 on regtest unless specified by arg	2024-10-28 11:38:38 -04:00
chainparams.h
chainparamsbase.cpp	Deduplicate list of chain strings in RPC help texts	2024-08-13 14:00:33 -03:00
chainparamsbase.h	Deduplicate list of chain strings in RPC help texts	2024-08-13 14:00:33 -03:00
chainparamsseeds.h	seeds: Regenerate mainnet seeds	2024-08-27 07:00:27 +02:00
checkqueue.h
clientversion.cpp	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
clientversion.h	scripted-diff: Clarify "user agent" variable name	2024-10-28 12:35:49 +00:00
cluster_linearize.h	clusterlin: remove Cluster type	2024-10-07 13:49:36 -04:00
CMakeLists.txt	build: Disable secp256k1 musig module	2024-11-05 15:08:49 -05:00
coins.cpp	tracing: only prepare tracepoint args if attached	2024-10-28 14:27:47 +01:00
coins.h	refactor: Rely on returned value of GetCoin instead of parameter	2024-09-18 20:03:47 +02:00
compressor.cpp
compressor.h
core_io.h	refactor: Replace ParseHashStr with FromHex	2024-07-24 17:40:18 +02:00
core_memusage.h
core_read.cpp	refactor: Replace ParseHashStr with FromHex	2024-07-24 17:40:18 +02:00
core_write.cpp
cuckoocache.h
dbwrapper.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp
external_signer.cpp	refactor: Remove Span operator==, Use std::ranges::equal	2024-08-13 07:44:31 +02:00
external_signer.h
flatfile.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
flatfile.h	refactor: Add FlatFileSeq member variables in BlockManager	2024-07-24 09:39:35 +02:00
hash.cpp
hash.h	Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563	2024-11-04 14:59:46 -05:00
headerssync.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
headerssync.h
httprpc.cpp	Merge bitcoin/bitcoin#30401: fix: increase consistency of rpcauth parsing	2024-09-09 12:29:17 -04:00
httprpc.h
httpserver.cpp	scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h	2024-10-10 12:22:12 +02:00
httpserver.h
i2p.cpp
i2p.h
indirectmap.h
init.cpp	Merge bitcoin/bitcoin#30592: Remove mempoolfullrbf	2024-11-08 13:51:29 -05:00
init.h	multiprocess: Add -ipcbind option to bitcoin-node	2024-09-06 09:08:10 -04:00
key.cpp	refactor: remove un-tested early returns	2024-08-04 08:52:22 +02:00
key.h	refactor: move SignSchnorr to KeyPair	2024-08-04 08:51:36 +02:00
key_io.cpp	key: clear out secret data in DecodeExtKey	2024-10-27 15:38:54 +01:00
key_io.h
logging.cpp	log: Enforce trailing newline, Remove redundant m_started_new_line	2024-10-01 11:31:39 +02:00
logging.h	log: Enforce trailing newline, Remove redundant m_started_new_line	2024-10-01 11:31:39 +02:00
mapport.cpp	mapport: remove dead code in DispatchMapPort	2024-10-25 15:02:07 -04:00
mapport.h	interfaces: remove now unused 'use_upnp' arg from 'mapPort'	2024-10-24 18:23:30 +02:00
memusage.h	memusage: Add DynamicUsage for std::string	2024-11-04 18:46:40 +01:00
merkleblock.cpp
merkleblock.h
net.cpp	Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}	2024-11-11 10:54:20 +00:00
net.h	net: Use actual memory size in receive buffer accounting	2024-11-04 18:46:40 +01:00
net_permissions.cpp
net_permissions.h
net_processing.cpp	Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing	2024-11-11 10:33:28 +00:00
net_processing.h	net: add GetOrphanTransactions() to PeerManager	2024-10-01 21:55:18 -04:00
net_types.cpp
net_types.h
netaddress.cpp	refactor: Remove Span operator==, Use std::ranges::equal	2024-08-13 07:44:31 +02:00
netaddress.h
netbase.cpp	scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h	2024-10-10 12:22:12 +02:00
netbase.h	net: add All() in ReachableNets	2024-09-10 11:20:40 -03:00
netgroup.cpp
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp	Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to execute a fuzz target	2024-10-31 13:51:37 +01:00
pow.h	Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check	2024-09-02 15:43:33 +01:00
prevector.h	prevector: avoid GCC bogus warnings in insert method	2024-09-11 17:41:26 +02:00
protocol.cpp	scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}	2024-10-26 23:44:15 +02:00
protocol.h	scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}	2024-10-26 23:44:15 +02:00
psbt.cpp
psbt.h
pubkey.cpp	refactor: Hand-replace some ParseHex -> ""_hex	2024-08-28 19:11:59 +02:00
pubkey.h	refactor: Make XOnlyPubKey tolerate constexpr std::arrays	2024-08-28 19:09:51 +02:00
random.cpp	Merge bitcoin/bitcoin#31124: util: Remove RandAddSeedPerfmon	2024-10-24 18:08:12 -04:00
random.h	util: Remove RandAddSeedPerfmon	2024-10-21 23:24:17 +02:00
randomenv.cpp	util: Remove RandAddSeedPerfmon	2024-10-21 23:24:17 +02:00
randomenv.h
rest.cpp	scripted-diff: Rename PACKAGE_* variables to CLIENT_*	2024-10-28 12:36:19 +00:00
rest.h
scheduler.cpp
scheduler.h
serialize.h
signet.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
signet.h
span.h	refactor: Remove Span operator==, Use std::ranges::equal	2024-08-13 07:44:31 +02:00
streams.cpp	streams: add DataStream::GetMemoryUsage	2024-11-04 18:46:40 +01:00
streams.h	streams: add DataStream::GetMemoryUsage	2024-11-04 18:46:40 +01:00
sync.cpp
sync.h
threadsafety.h
tinyformat.h
torcontrol.cpp	scripted-diff: LogPrint -> LogDebug	2024-08-29 13:49:57 +02:00
torcontrol.h
txdb.cpp	refactor: Rely on returned value of GetCoin instead of parameter	2024-09-18 20:03:47 +02:00
txdb.h	refactor: Rely on returned value of GetCoin instead of parameter	2024-09-18 20:03:47 +02:00
txmempool.cpp	tracing: only prepare tracepoint args if attached	2024-10-28 14:27:47 +01:00
txmempool.h	refactor: Rely on returned value of GetCoin instead of parameter	2024-09-18 20:03:47 +02:00
txorphanage.cpp	net: add GetOrphanTransactions() to PeerManager	2024-10-01 21:55:18 -04:00
txorphanage.h	[fuzz] txdownloadman and txdownload_impl	2024-10-24 21:23:56 -04:00
txrequest.cpp	Merge bitcoin/bitcoin#30194: refactor: use recommended type hiding on multi_index types	2024-08-07 20:00:28 +01:00
txrequest.h
uint256.cpp	scripted-diff: Rename SetHex to SetHexDeprecated	2024-07-24 09:15:34 +02:00
uint256.h	test: remove test-only uint256S	2024-09-06 17:36:18 +02:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing	2024-11-11 10:33:28 +00:00
validation.h	Remove unused g_best_block	2024-09-17 09:27:45 +02:00
validationinterface.cpp	refactor: include the proper header rather than forward-declaring RemovalReasonToString	2024-10-08 15:25:47 +00:00
validationinterface.h	[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr	2024-07-25 11:01:22 +01:00
versionbits.cpp
versionbits.h
walletinitinterface.h