Hennadii Stepanov 23a7d56df2 Merge bitcoin-core/gui#447: Never disable HD status icon ... 35e814c1cf qt: never disable HD status icon (=) Pull request description: [#8517](https://github.com/bitcoin/bitcoin/pull/8517) introduced the HD status icon in the bottom menu bar. At the time, it may have made sense to disable the HD status icon (which would display the icon at 50% opacity) when the wallet is not HD or watch-only. Since then, we have had many changes to our UI. Namely, the ability to switch between dark and light mode on macOS. Additionally, since version 0.16, the Bitcoin Core client only [generates HD wallets](https://github.com/bitcoin/bitcoin/issues/12547). Non-HD Wallets cannot be created anymore, only imported. This PR proposes never to disable the HD status icon in the bottom menu bar. Instead, we always leave the HD status icon enabled for a better user interface. There’s no good reason for it to remain disabled, and it’s hard to see the watch-only icon in macOS dark mode. If a user has imported a non-HD wallet, we also want the icon to be as clear as possible in the bottom menu bar. - on macOS | | Master | PR | | ------------- | ------------- | ------------- | | Dark Mode |  |  | | Light Mode || | - on ubuntu 20.04 | Master | PR | | ------------- | ------------- | |  | | ACKs for top commit: jarolrod: ACK 35e814c1cf hebasto: ACK 35e814c1cf Tree-SHA512: ba7d1c1f2a439bbb32f7755c10cadc5d61892add3abca2a286a30a0fbbbb077e2190365c9e8dee6a10b4feed249656c7bd58ea14a319f5b28cd56182d4ddbdc1		2021-10-20 00:51:42 +03:00
..
bench	Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified)	2021-10-19 15:47:53 +02:00
compat	compat: remove glibc_compat.cpp	2021-09-10 11:18:58 +08:00
config
consensus	consensus: use <cstdint> over <stdint.h> in amount.h	2021-09-30 07:42:01 +08:00
crc32c	Update crc32c subtree	2021-09-29 14:10:29 +02:00
crypto
index	Add syscall sandboxing (seccomp-bpf)	2021-10-01 13:51:10 +00:00
init	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
interfaces	Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const	2021-10-13 07:19:13 +02:00
ipc	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
leveldb
logging	Make unexpected time type in BCLog::LogMsg() a compile-time error	2021-09-07 19:19:31 +02:00
node	Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method	2021-10-15 10:01:56 +02:00
policy	Merge bitcoin/bitcoin#22863: policy: document dust threshold for Taproot outputs	2021-10-15 14:52:07 +02:00
primitives	[MOVEONLY] consensus: move amount.h into consensus	2021-09-30 07:41:57 +08:00
qt	Merge bitcoin-core/gui#447: Never disable HD status icon	2021-10-20 00:51:42 +03:00
rpc	Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified)	2021-10-19 15:47:53 +02:00
script	[MOVEONLY] consensus: move amount.h into consensus	2021-09-30 07:41:57 +08:00
secp256k1
support
test	Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method	2021-10-15 10:01:56 +02:00
univalue
util	Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method	2021-10-15 10:01:56 +02:00
wallet	Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method	2021-10-15 10:01:56 +02:00
zmq	scripted-diff: Rename overloaded int GetArg to GetIntArg	2021-09-27 06:57:20 -04:00
.clang-format
.clang-tidy	Enable clang-tidy bugprone-argument-comment and fix violations	2021-09-07 09:11:10 +02:00
addrdb.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
addrdb.h	scripted-diff: Rename CAddrMan to AddrMan	2021-09-28 22:21:10 -04:00
addrman.cpp	[style] Run changed files through clang formatter.	2021-09-28 22:21:10 -04:00
addrman.h	[style] Run changed files through clang formatter.	2021-09-28 22:21:10 -04:00
addrman_impl.h	[style] Run changed files through clang formatter.	2021-09-28 22:21:10 -04:00
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp	Ignore banlist.dat	2021-07-30 11:21:51 +02:00
banman.h	Ignore banlist.dat	2021-07-30 11:21:51 +02:00
base58.cpp
base58.h
bech32.cpp	Add references for the generator/constant used in Bech32(m)	2021-08-20 15:49:50 -04:00
bech32.h
bitcoin-cli-res.rc	windres: use PACKAGE_VERSION rather than building more version numbers	2021-08-17 16:54:47 +08:00
bitcoin-cli.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
bitcoin-tx-res.rc	windres: use PACKAGE_VERSION rather than building more version numbers	2021-08-17 16:54:47 +08:00
bitcoin-tx.cpp	bitcoin-tx: Reject non-integral and out of range multisig numbers	2021-10-12 12:45:55 +02:00
bitcoin-util-res.rc	windres: use PACKAGE_VERSION rather than building more version numbers	2021-08-17 16:54:47 +08:00
bitcoin-util.cpp
bitcoin-wallet-res.rc	windres: use PACKAGE_VERSION rather than building more version numbers	2021-08-17 16:54:47 +08:00
bitcoin-wallet.cpp
bitcoind-res.rc	windres: use PACKAGE_VERSION rather than building more version numbers	2021-08-17 16:54:47 +08:00
bitcoind.cpp	Add syscall sandboxing (seccomp-bpf)	2021-10-01 13:51:10 +00:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp	bloom: cleanup includes	2021-09-29 09:48:36 +08:00
bloom.h	bloom: cleanup includes	2021-09-29 09:48:36 +08:00
chain.cpp
chain.h	chain: add BLOCK_ASSUMED_VALID for use with assumeutxo	2021-09-15 15:46:44 -04:00
chainparams.cpp	Use absolute FQDN for DNS seed domains	2021-10-14 17:49:52 +05:30
chainparams.h
chainparamsbase.cpp	test: Activate all regtest softforks at height 1, unless overridden	2021-09-16 18:53:04 +02:00
chainparamsbase.h
chainparamsseeds.h	contrib, p2p: update I2P hardcoded seeds	2021-07-30 11:03:44 +02:00
checkqueue.h	Add syscall sandboxing (seccomp-bpf)	2021-10-01 13:51:10 +00:00
clientversion.cpp	wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump	2021-08-16 16:04:47 +08:00
clientversion.h	wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump	2021-08-16 16:04:47 +08:00
coins.cpp
coins.h
compat.h
compressor.cpp
compressor.h
core_io.h	rpc: Add level 3 verbosity to getblock RPC call.	2021-10-05 10:42:34 +02:00
core_memusage.h
core_read.cpp	bitcoin-tx: Avoid treating overflow as OP_0	2021-10-11 09:17:28 +02:00
core_write.cpp	core_write: Rename calculate_fee to have_undo for clarity	2021-10-05 10:42:34 +02:00
cuckoocache.h
dbwrapper.cpp	Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method	2021-10-15 10:01:56 +02:00
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp	consensus/params: simplify ValidDeployment check to avoid gcc warning	2021-08-02 23:48:32 +10:00
deploymentstatus.h
dummywallet.cpp	Remove -rescan startup parameter	2021-09-30 12:06:27 +13:00
external_signer.cpp
external_signer.h
flatfile.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
flatfile.h
fs.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
fs.h	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
hash.cpp	refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization	2021-10-05 23:53:33 +02:00
hash.h
httprpc.cpp	Replace use of boost::trim use with locale-independent TrimString	2021-09-02 13:17:46 +08:00
httprpc.h
httpserver.cpp	Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)	2021-10-04 22:45:43 +02:00
httpserver.h
i2p.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
i2p.h
indirectmap.h
init.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
init.h
key.cpp	refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization	2021-10-05 23:53:33 +02:00
key.h	doc: Remove stale comment for CPrivKey	2021-09-16 21:16:39 +09:00
key_io.cpp
key_io.h
logging.cpp	blockstorage: use debug log category	2021-10-11 21:45:49 +10:00
logging.h	blockstorage: use debug log category	2021-10-11 21:45:49 +10:00
Makefile.am	scripts: use LIEF for ELF checks in symbol-check.py	2021-10-12 08:36:15 +08:00
Makefile.bench.include
Makefile.crc32c.include	build: remove support for weak linking getauxval()	2021-09-24 15:40:04 +08:00
Makefile.leveldb.include
Makefile.qt.include	scripted-diff: Prefix makefile variables with QT_	2021-10-13 21:09:54 +01:00
Makefile.qt_locale.include
Makefile.qttest.include	Start using init makeNode, makeChain, etc methods	2021-08-17 03:05:15 -05:00
Makefile.test.include	test: Add ParseMoney and ParseScript tests	2021-10-06 20:01:42 +02:00
Makefile.test_fuzz.include
Makefile.test_util.include	move-only: unittest: add test/util/chainstate.h	2021-09-15 15:46:48 -04:00
mapport.cpp	Add syscall sandboxing (seccomp-bpf)	2021-10-01 13:51:10 +00:00
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
miner.cpp	[MOVEONLY] consensus: move amount.h into consensus	2021-09-30 07:41:57 +08:00
miner.h
net.cpp	Merge bitcoin/bitcoin#22950: [p2p] Pimpl AddrMan to abstract implementation details	2021-10-05 16:48:33 +02:00
net.h	Merge bitcoin/bitcoin#22950: [p2p] Pimpl AddrMan to abstract implementation details	2021-10-05 16:48:33 +02:00
net_permissions.cpp
net_permissions.h	Rate limit the processing of incoming addr messages	2021-07-15 12:52:38 -07:00
net_processing.cpp	Merge bitcoin/bitcoin#22950: [p2p] Pimpl AddrMan to abstract implementation details	2021-10-05 16:48:33 +02:00
net_processing.h	scripted-diff: Rename CAddrMan to AddrMan	2021-09-28 22:21:10 -04:00
net_types.cpp	MOVEONLY: Expose BanMapToJson / BanMapFromJson	2021-09-03 05:21:58 -04:00
net_types.h	MOVEONLY: Expose BanMapToJson / BanMapFromJson	2021-09-03 05:21:58 -04:00
netaddress.cpp	scripted-diff: Rename CAddrMan to AddrMan	2021-09-28 22:21:10 -04:00
netaddress.h	scripted-diff: Rename CAddrMan to AddrMan	2021-09-28 22:21:10 -04:00
netbase.cpp	Cleanup headers after #20788	2021-09-11 10:47:02 +03:00
netbase.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp	make ParseOutputType return a std::optional<OutputType>	2021-08-04 19:20:32 +08:00
outputtype.h	make ParseOutputType return a std::optional<OutputType>	2021-08-04 19:20:32 +08:00
pow.cpp
pow.h
prevector.h
protocol.cpp
protocol.h	doc: Remove incorrect INIT_PROTO_VERSION from nTime comment	2021-08-23 18:53:34 +02:00
psbt.cpp
psbt.h
pubkey.cpp	refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization	2021-10-05 23:53:33 +02:00
pubkey.h	Consolidate XOnlyPubKey lookup hack	2021-08-23 21:38:34 -04:00
random.cpp
random.h
randomenv.cpp	build: remove support for weak linking getauxval()	2021-09-24 15:40:04 +08:00
randomenv.h
rest.cpp	Merge bitcoin/bitcoin#22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified)	2021-10-19 15:47:53 +02:00
reverse_iterator.h
scheduler.cpp	Add syscall sandboxing (seccomp-bpf)	2021-10-01 13:51:10 +00:00
scheduler.h
serialize.h
shutdown.cpp
shutdown.h
signet.cpp	Enable clang-tidy bugprone-argument-comment and fix violations	2021-09-07 09:11:10 +02:00
signet.h
span.h
streams.h
sync.cpp	log: Avoid broken DEBUG_LOCKORDER log	2021-09-29 18:46:30 +02:00
sync.h	sync: inline lock contention logging macro to fix time duration	2021-09-06 23:43:51 +02:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp	scripted-diff: Rename overloaded int GetArg to GetIntArg	2021-09-27 06:57:20 -04:00
timedata.h
tinyformat.h
torcontrol.cpp	refactor: Block unsafe fs::path std::string conversion calls	2021-10-05 11:10:47 -04:00
torcontrol.h
txdb.cpp	scripted-diff: Rename overloaded int GetArg to GetIntArg	2021-09-27 06:57:20 -04:00
txdb.h	Remove txindex migration code	2021-08-20 16:59:41 +02:00
txmempool.cpp	Use C++11 member initializer in CTxMemPoolEntry	2021-09-21 16:04:27 +02:00
txmempool.h	[MOVEONLY] consensus: move amount.h into consensus	2021-09-30 07:41:57 +08:00
txorphanage.cpp
txorphanage.h	[net processing] Add Orphanage empty consistency check	2021-07-20 13:12:42 +01:00
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h
undo.h
validation.cpp	tracing: drop block_connected hash.toString() arg	2021-10-18 14:35:25 +02:00
validation.h	[MOVEONLY] consensus: move amount.h into consensus	2021-09-30 07:41:57 +08:00
validationinterface.cpp
validationinterface.h
version.h
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp
warnings.h