0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
bitcoin-core/src/test
fanquake 2026301405
Merge bitcoin/bitcoin#27810: fuzz: Partially revert #27780
71200ac390 [fuzz] Only check duplicate coinbase script when block was valid (dergoegge)

Pull request description:

  Partially revert #27780, because moving the duplicate coinbase check out of the `was_valid` branch leads to non-bug crashes in the fuzz target.

  For context and further explanation see: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59516

ACKs for top commit:
  MarcoFalke:
    nice lgtm ACK 71200ac390

Tree-SHA512: 8c38e5ff9de6331016b9a0c5e435d007d46186151b04c09085f617bb31627a28ad56678066fe152372a3ad8656f026439e3e2f9ee61d7ef588072aef8124eaa3
2023-06-07 15:55:36 +02:00
..
data
fuzz Merge bitcoin/bitcoin#27810: fuzz: Partially revert #27780 2023-06-07 15:55:36 +02:00
util Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation. 2023-05-30 14:57:22 +01:00
addrman_tests.cpp p2p, refactor: return std::optional<CNetAddr> in LookupHost 2023-05-26 13:41:07 -03:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp
argsman_tests.cpp refactor: Use ChainType enum exhaustively 2023-05-10 10:39:58 +02:00
arith_uint256_tests.cpp
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp
blockchain_tests.cpp
blockencodings_tests.cpp
blockfilter_index_tests.cpp refactor: Move functions to BlockManager methods 2023-05-10 19:06:53 +02:00
blockfilter_tests.cpp
blockmanager_tests.cpp refactor, blockstorage: Replace blocksdir arg 2023-05-10 19:07:44 +02:00
bloom_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
bswap_tests.cpp
checkqueue_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
coins_tests.cpp
coinstatsindex_tests.cpp
compilerbug_tests.cpp
compress_tests.cpp
crypto_tests.cpp
cuckoocache_tests.cpp
dbwrapper_tests.cpp
denialofservice_tests.cpp
descriptor_tests.cpp
flatfile_tests.cpp
fs_tests.cpp
getarg_tests.cpp
hash_tests.cpp
headers_sync_chainwork_tests.cpp
httpserver_tests.cpp
i2p_tests.cpp
interfaces_tests.cpp Temporarily work around gcc-13 warning bug in interfaces_tests 2023-05-09 20:27:05 +02:00
key_io_tests.cpp scripted-diff: Use UniValue::find_value method 2023-05-09 18:47:14 +02:00
key_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
logging_tests.cpp
main.cpp
Makefile
mempool_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
merkle_tests.cpp
merkleblock_tests.cpp
miner_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
miniminer_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
miniscript_tests.cpp
minisketch_tests.cpp
multisig_tests.cpp
net_peer_eviction_tests.cpp
net_tests.cpp p2p, refactor: return std::optional<CNetAddr> in LookupHost 2023-05-26 13:41:07 -03:00
netbase_tests.cpp p2p, refactor: return std::optional<CNetAddr> in LookupHost 2023-05-26 13:41:07 -03:00
orphanage_tests.cpp
pmt_tests.cpp
policy_fee_tests.cpp
policyestimator_tests.cpp
pool_tests.cpp
pow_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
prevector_tests.cpp
raii_event_tests.cpp
random_tests.cpp
rbf_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
README.md
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp Merge bitcoin/bitcoin#27256: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it 2023-06-02 16:18:11 +01:00
sanity_tests.cpp
scheduler_tests.cpp
script_p2sh_tests.cpp
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp
script_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp
serialize_tests.cpp
settings_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
sighash_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
sigopcount_tests.cpp
skiplist_tests.cpp
sock_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
streams_tests.cpp
sync_tests.cpp
system_tests.cpp scripted-diff: Use UniValue::find_value method 2023-05-09 18:47:14 +02:00
timedata_tests.cpp
torcontrol_tests.cpp
transaction_tests.cpp
translation_tests.cpp
txindex_tests.cpp
txpackage_tests.cpp
txreconciliation_tests.cpp
txrequest_tests.cpp
txvalidation_tests.cpp
txvalidationcache_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
uint256_tests.cpp
util_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
util_threadnames_tests.cpp
validation_block_tests.cpp
validation_chainstate_tests.cpp
validation_chainstatemanager_tests.cpp kernel: Add notification interface 2023-05-20 12:03:22 +02:00
validation_flush_tests.cpp
validation_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
xoroshiro128plusplus_tests.cpp

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred