Wladimir J. van der Laan 6757b3ac8f Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding block count ... c133cdcdc3 Cap listsinceblock target_confirmations param (Adam Stein) Pull request description: This addresses an issue brought up in #19587. Currently, the `target_confirmations` parameter to `listsinceblock` is not checked for being too large. When `target_confirmations` is greater than one more than the current number of blocks, `listsinceblock` fails with error code -1. In comparison, when `target_confirmations` is less than 1, a -8 "Invalid parameter" error code is thrown. This PR fixes the issue by returning a -8 "Invalid parameter" error if the `target_confirmations` value corresponds to a block with more confirmations than the genesis block. This happens if `target_confirmations` exceeds one more than the number of blocks. ACKs for top commit: laanwj: Code review ACK c133cdcdc3 ryanofsky: Code review ACK c133cdcdc3. Just suggested changes since last review. Thanks! Tree-SHA512: 02680f4cb937d2c24d5019abd0ebfa188b8a50679a1e64e9c26bfe5c17eef6aea906832e6e2d492ba8a2ea160041bf185d66795ee691e340f6793db03c21b89a		2020-08-13 12:12:33 +02:00
..
test	Make Hash[160] consume range-like objects	2020-07-30 13:57:54 -07:00
bdb.cpp	refactor: Make HexStr take a span	2020-08-06 19:41:43 +02:00
bdb.h	Remove BDB dummy databases	2020-07-29 12:30:23 -04:00
coincontrol.cpp	[rpc] walletcreatefundedpsbt: don't automatically append inputs	2020-03-12 13:07:17 +01:00
coincontrol.h	[rpc] walletcreatefundedpsbt: don't automatically append inputs	2020-03-12 13:07:17 +01:00
coinselection.cpp	bnb: exit selection when best_waste is 0	2020-03-04 16:35:15 -05:00
coinselection.h
context.cpp	Remove g_rpc_chain global	2020-05-28 02:13:19 -04:00
context.h	wallet: Pass unused args to StartWallets	2020-07-09 13:07:37 +02:00
crypter.cpp	Fix occurences of c_str() used with size() to data()	2019-10-28 13:41:45 +01:00
crypter.h	Convert wallet to new serialization	2020-05-24 10:34:52 -07:00
db.cpp	walletdb: Move BDB specific things into bdb.{cpp/h}	2020-06-15 20:41:05 -04:00
db.h	Introduce DummyDatabase and use it in the tests	2020-07-29 12:28:30 -04:00
feebumper.cpp	wallet: Remove trailing whitespace from potential translation strings	2020-05-01 07:41:32 -04:00
feebumper.h	wallet: Avoid translating RPC errors when creating txs	2020-05-01 07:39:06 -04:00
fees.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
fees.h
init.cpp	scripted-diff: Replace gArgs with local argsman	2020-07-29 16:39:00 +07:00
ismine.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
load.cpp	walletdb: Move BerkeleyDatabase::Flush(true) to Close()	2020-07-14 11:07:16 -04:00
load.h	wallet: Pass unused args to StartWallets	2020-07-09 13:07:37 +02:00
rpcdump.cpp	refactor: Make HexStr take a span	2020-08-06 19:41:43 +02:00
rpcwallet.cpp	Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding block count	2020-08-13 12:12:33 +02:00
rpcwallet.h	refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions	2020-06-05 08:29:18 -04:00
salvage.cpp	walletdb: Don't remove database transaction logs and instead error	2020-07-13 11:00:54 -04:00
salvage.h	Move RecoverKeysOnlyFilter into RecoverDataBaseFile	2020-05-25 12:59:29 -04:00
scriptpubkeyman.cpp	Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants	2020-07-11 23:08:54 +12:00
scriptpubkeyman.h	Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants	2020-07-11 23:08:54 +12:00
wallet.cpp	walletdb: Move BerkeleyDatabase::Flush(true) to Close()	2020-07-14 11:07:16 -04:00
wallet.h	walletdb: Move BerkeleyDatabase::Flush(true) to Close()	2020-07-14 11:07:16 -04:00
walletdb.cpp	Make Hash[160] consume range-like objects	2020-07-30 13:57:54 -07:00
walletdb.h	walletdb: Introduce WalletDatabase abstract class	2020-07-14 11:07:16 -04:00
wallettool.cpp	walletdb: Move BerkeleyDatabase::Flush(true) to Close()	2020-07-14 11:07:16 -04:00
wallettool.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
walletutil.cpp	Correctly check for default wallet	2020-04-23 13:59:48 -04:00
walletutil.h	Convert wallet to new serialization	2020-05-24 10:34:52 -07:00