fanquake 34d1d6a112 Merge bitcoin/bitcoin#22381: guix: Test security-check sanity before performing them (with macOS) ... 5b4703c6a7 guix: Test security-check sanity before performing them (Carl Dong) 6cf3345297 scripts: adjust test-symbol-check for guix release environment (fanquake) 1946b5f77c scripts: more robustly test macOS symbol checks (fanquake) a8127b34bc build: Use and test PE binutils with --reloc-section (Carl Dong) 678348db51 guix: Patch binutils to add security-related disable flags (Carl Dong) 9fdc8afe11 devtools: Improve *-check.py tool detection (Carl Dong) bda62eab38 ci: skip running the Linux test-security-check target for now (fanquake) d6ef3543ae lint: Run mypy with --show-error-codes (Carl Dong) Pull request description: This is #20980 rebased (to include the Boost Process fix), and with an additional commit (892d6897f1e613084aa0517a660eab2412308e6e) to fix running the `test-security-check` target for the macOS build. It should pass inside Guix, as well as when cross-compiling on Ubuntu, or building natively on macOS. Note that the `test-security-check` may output some warnings (similar too): ```bash ld: warning: passed two min versions (10.14, 11.4) for platform macOS. Using 11.4. ld: warning: passed two min versions (10.14, 11.4) for platform macOS. Using 11.4. ld: warning: passed two min versions (10.14, 10.14) for platform macOS. Using 10.14. ``` but those can be ignored, and come about due to us passing `-platform_version` when `-mmacosx-version-min` is already part of `CC`. Guix builds: ```bash 71ed0c7a13a4726300779ffc87f7d271086a2744c36896fe6dc51fe3dc33df2e guix-build-5b4703c6a70d/output/aarch64-linux-gnu/SHA256SUMS.part 9273980a17052c8ec45b77579781c14ab5d189fa25aa29907d5115513dd302b1 guix-build-5b4703c6a70d/output/aarch64-linux-gnu/bitcoin-5b4703c6a70d-aarch64-linux-gnu-debug.tar.gz 9c042179af43c8896eb95a34294df15d4910308dcdba40b2010cd36e192938b8 guix-build-5b4703c6a70d/output/aarch64-linux-gnu/bitcoin-5b4703c6a70d-aarch64-linux-gnu.tar.gz 1ceddecac113f50a952ba6a201cdcdb722e3dc804e663f219bfac8268ce42bf0 guix-build-5b4703c6a70d/output/arm-linux-gnueabihf/SHA256SUMS.part 759597c4e925e75db4a2381c06cda9b9f4e4674c23436148676b31c9be05c7aa guix-build-5b4703c6a70d/output/arm-linux-gnueabihf/bitcoin-5b4703c6a70d-arm-linux-gnueabihf-debug.tar.gz 34e3b6beabaf8c95d7c2ca0d2c3ac4411766694ef43e00bd9783badbbaf045a7 guix-build-5b4703c6a70d/output/arm-linux-gnueabihf/bitcoin-5b4703c6a70d-arm-linux-gnueabihf.tar.gz e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 guix-build-5b4703c6a70d/output/dist-archive/SKIPATTEST.TAG 3664f6ceee7898caa374281fd877a7597fe491fa2e9f0c174c28d889d60b559c guix-build-5b4703c6a70d/output/dist-archive/bitcoin-5b4703c6a70d.tar.gz d6bc35ba0750c1440bb32831b8c12cddee62f6dce10fec2650897444c2bf4748 guix-build-5b4703c6a70d/output/powerpc64-linux-gnu/SHA256SUMS.part a836edf6474ba0c16c19bb217549bac7936c1b44306ed512df58f607ee5568f2 guix-build-5b4703c6a70d/output/powerpc64-linux-gnu/bitcoin-5b4703c6a70d-powerpc64-linux-gnu-debug.tar.gz 7cc91c6805d5069ca3bd1771e77d95f83eb184b137198cbf84d1d11d0a5c5afe guix-build-5b4703c6a70d/output/powerpc64-linux-gnu/bitcoin-5b4703c6a70d-powerpc64-linux-gnu.tar.gz 93b4cb7b83c4975120ad5de5a92f050f5760a2a3f2c37c204c647f5a581c924a guix-build-5b4703c6a70d/output/powerpc64le-linux-gnu/SHA256SUMS.part 2266e2c5d0dafa28c6c057ccfc1c439baeab1d714d8c3f64a83015d2827116d2 guix-build-5b4703c6a70d/output/powerpc64le-linux-gnu/bitcoin-5b4703c6a70d-powerpc64le-linux-gnu-debug.tar.gz 85f41f42c319b83d049d6fd2e2278c07b40a1e28a2eac596427822c0eef9dc3f guix-build-5b4703c6a70d/output/powerpc64le-linux-gnu/bitcoin-5b4703c6a70d-powerpc64le-linux-gnu.tar.gz 1499ca9119926083d8c3714ca10d8d4c8d864cbeee8848fd8445b7a1d081222d guix-build-5b4703c6a70d/output/riscv64-linux-gnu/SHA256SUMS.part 1995fc1a2e45c49d4b0718aff5dcdac931917e8ae9e762fd23f1126abcecc248 guix-build-5b4703c6a70d/output/riscv64-linux-gnu/bitcoin-5b4703c6a70d-riscv64-linux-gnu-debug.tar.gz 266889eb58429a470f0fd7bb123f2ae09b0aef86c47b0390938b3634a8f748a9 guix-build-5b4703c6a70d/output/riscv64-linux-gnu/bitcoin-5b4703c6a70d-riscv64-linux-gnu.tar.gz cdc3a0dcf80b110443dac5ddf8bc951001a776a651c898c5ea49bb2d487bfe29 guix-build-5b4703c6a70d/output/x86_64-apple-darwin18/SHA256SUMS.part 8538d1eab96c97866b24546c453d95822f24cf9c6638b42ba523eb7aa441cb26 guix-build-5b4703c6a70d/output/x86_64-apple-darwin18/bitcoin-5b4703c6a70d-osx-unsigned.dmg d1b73133f1da68586b07292a8425f7f851e93f599c016376f23728c041cf39cc guix-build-5b4703c6a70d/output/x86_64-apple-darwin18/bitcoin-5b4703c6a70d-osx-unsigned.tar.gz 5ad94c5f8a5f29405955ff3ab35d137de1acc04398d6c8298fb187b57a6e316a guix-build-5b4703c6a70d/output/x86_64-apple-darwin18/bitcoin-5b4703c6a70d-osx64.tar.gz 8c6d7b3f847faa7b4d16ceecf228f26f146ea982615c1d7a00c57f9230a0c484 guix-build-5b4703c6a70d/output/x86_64-linux-gnu/SHA256SUMS.part d0a8c99750319ad8046cfa132a54e5c13a08351f94439ae9af0f8e5486c2c2ea guix-build-5b4703c6a70d/output/x86_64-linux-gnu/bitcoin-5b4703c6a70d-x86_64-linux-gnu-debug.tar.gz d816bb26dd4b0e309f2f576b1cccc6d78743fb2f357daad2da09bb1177330971 guix-build-5b4703c6a70d/output/x86_64-linux-gnu/bitcoin-5b4703c6a70d-x86_64-linux-gnu.tar.gz 65caaa7f648c7eab1eb82c3331a2ca25b8cd4fe41439de55604501e02571de55 guix-build-5b4703c6a70d/output/x86_64-w64-mingw32/SHA256SUMS.part 5bf6f7328cbceb0db22a2d7babb07b60cb6dcc19a6db84a1698589b7f5173a06 guix-build-5b4703c6a70d/output/x86_64-w64-mingw32/bitcoin-5b4703c6a70d-win-unsigned.tar.gz 7aabcb56115decef78d3797840b6e49dbc9b202d56f892490e92616fb06fec9e guix-build-5b4703c6a70d/output/x86_64-w64-mingw32/bitcoin-5b4703c6a70d-win64-debug.zip 2f369694648ff9dc5ca1261a1e5874b1c7408ccf2802f9caef56c1334e8a5b7c guix-build-5b4703c6a70d/output/x86_64-w64-mingw32/bitcoin-5b4703c6a70d-win64-setup-unsigned.exe 1c1f92513c4aad38419ff49a7b80bf10e6b1eca01ee8c5e3b2acd1768cf1e3d5 guix-build-5b4703c6a70d/output/x86_64-w64-mingw32/bitcoin-5b4703c6a70d-win64.zip ``` ACKs for top commit: hebasto: Approach ACK 5b4703c6a7. Tree-SHA512: 2cd92a245ea64ef7176cf402a1fa5348a9421c30a4d30d01c950c48f6dcc15cf22ce69ffe1657be97e5fccc14bd933d64683c4439b695528ce3dc34d72dda927		2021-07-09 10:20:16 +08:00
..
bench	bench: bench_bitcoin.cpp help fixups	2021-06-24 11:13:12 +02:00
compat	Remove support for double serialization	2021-05-24 16:15:05 -07:00
config
consensus	Merge bitcoin/bitcoin#19438: Introduce deploymentstatus	2021-07-01 19:15:09 +02:00
crc32c
crypto	crypto: Make MuHash Remove method efficient	2021-04-19 20:28:46 +02:00
index	scripted-diff: tree-wide: Remove all review-only assertions	2021-06-10 15:05:24 -04:00
init	Make SetupServerArgs callable without NodeContext	2021-06-10 09:58:45 -05:00
interfaces	refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage	2021-06-16 10:48:58 +02:00
ipc	multiprocess: Add echoipc RPC method and test	2021-04-23 03:02:50 -05:00
leveldb
logging
node	[refactor] Add versionbits deployments to deploymentstatus.h	2021-06-30 08:18:58 +10:00
policy	MOVEONLY: context-free package policies	2021-06-02 17:26:44 +01:00
primitives
qt	Merge bitcoin-core/gui#375: Emit dataChanged signal to dynamically re-sort Peers table	2021-07-06 00:02:49 +03:00
rpc	[refactor] versionbits: make VersionBitsCache a full class	2021-06-30 08:19:12 +10:00
script	Merge bitcoin/bitcoin#21329: descriptor wallet: Cache last hardened xpub and use in normalized descriptors	2021-07-01 09:58:40 +12:00
secp256k1	Update libsecp256k1 subtree to latest upstream master	2021-04-23 11:35:15 -07:00
support
test	Merge bitcoin/bitcoin#22179: Torv2 removal followups	2021-07-08 17:20:35 +02:00
univalue
util	build: Fix Boost Process compatibility with mingw-w64 compiler	2021-07-01 12:16:47 +03:00
wallet	Merge bitcoin/bitcoin#22334: wallet: do not spam about non-existent spk managers	2021-07-01 19:11:20 +08:00
zmq	zmq: use msg: prefix over errno= in zmqError	2021-06-09 19:25:13 +08:00
.clang-format
addrdb.cpp	banman: save the banlist in a JSON format on disk	2021-06-21 14:39:44 +02:00
addrdb.h	banman: save the banlist in a JSON format on disk	2021-06-21 14:39:44 +02:00
addrman.cpp	Merge bitcoin/bitcoin#22179: Torv2 removal followups	2021-07-08 17:20:35 +02:00
addrman.h	Merge bitcoin/bitcoin#22179: Torv2 removal followups	2021-07-08 17:20:35 +02:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp	banman: save the banlist in a JSON format on disk	2021-06-21 14:39:44 +02:00
banman.h	banman: save the banlist in a JSON format on disk	2021-06-21 14:39:44 +02:00
base58.cpp
base58.h
bech32.cpp
bech32.h
bitcoin-cli-res.rc
bitcoin-cli.cpp	cli: Avoid truncating -rpcwaittimeout	2021-06-23 14:40:55 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	Add support for SIGHASH_DEFAULT in RPCs, and make it default	2021-06-12 12:38:17 -07:00
bitcoin-util-res.rc
bitcoin-util.cpp	refactor: Pass grind args vector as const reference	2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	Remove unused OptionsCategory arg from AddCommand	2021-06-18 20:09:23 +02:00
bitcoind-res.rc
bitcoind.cpp	Make SetupServerArgs callable without NodeContext	2021-06-10 09:58:45 -05:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp
bloom.h
chain.cpp
chain.h	doc: Various validation doc fixups	2021-06-03 13:53:31 +02:00
chainparams.cpp	[move-only] Rename versionbitsinfo to deploymentinfo	2021-06-30 08:19:12 +10:00
chainparams.h	refactor: Use type-safe assumeutxo hash	2021-05-11 10:40:40 +02:00
chainparamsbase.cpp	versionbits: Add support for delayed activation	2021-04-12 11:14:49 +10:00
chainparamsbase.h
chainparamsseeds.h	contrib: remove torv2 seed nodes	2021-06-03 14:04:06 +02:00
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp	refactor: wrap CCoinsViewCursor in unique_ptr	2021-06-17 09:47:08 -04:00
coins.h	refactor: wrap CCoinsViewCursor in unique_ptr	2021-06-17 09:47:08 -04:00
compat.h
compressor.cpp	refactor: Use CPubKey vector constructor where possible	2021-05-04 06:53:32 +02:00
compressor.h
core_io.h
core_memusage.h
core_read.cpp	Add support for SIGHASH_DEFAULT in RPCs, and make it default	2021-06-12 12:38:17 -07:00
core_write.cpp
cuckoocache.h
dbwrapper.cpp	refactor: Use only one temporary buffer in CreateObfuscateKey	2021-05-04 06:53:37 +02:00
dbwrapper.h
deploymentinfo.cpp	deploymentinfo: Add DeploymentName()	2021-06-30 08:19:12 +10:00
deploymentinfo.h	deploymentinfo: Add DeploymentName()	2021-06-30 08:19:12 +10:00
deploymentstatus.cpp	scripted-diff: rename versionbitscache	2021-06-30 08:19:12 +10:00
deploymentstatus.h	[refactor] versionbits: make VersionBitsCache a full class	2021-06-30 08:19:12 +10:00
dummywallet.cpp	tests: Skip SQLite fsyncs while testing	2021-04-12 19:29:03 -04:00
external_signer.cpp	refactor: make ExternalSigner NetworkArg() and m_chain private	2021-06-16 10:48:58 +02:00
external_signer.h	refactor: make ExternalSigner NetworkArg() and m_chain private	2021-06-16 10:48:58 +02:00
flatfile.cpp
flatfile.h
fs.cpp
fs.h
hash.cpp
hash.h	Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8	2021-04-23 11:35:15 -07:00
httprpc.cpp
httprpc.h
httpserver.cpp	refactor: Make httpserver work queue a unique_ptr	2021-06-28 11:47:05 +02:00
httpserver.h
i2p.cpp
i2p.h
indirectmap.h
init.cpp	[refactor] Add deploymentstatus.h	2021-06-29 17:11:12 +10:00
init.h	Make SetupServerArgs callable without NodeContext	2021-06-10 09:58:45 -05:00
key.cpp	Add CKey::SignSchnorr function for BIP 340/341 signing	2021-06-12 12:25:28 -07:00
key.h	Add CKey::SignSchnorr function for BIP 340/341 signing	2021-06-12 12:25:28 -07:00
key_io.cpp	Separate WitnessV1Taproot variant in CTxDestination	2021-05-24 12:14:16 -07:00
key_io.h
logging.cpp	multiprocess: Add Ipc interface implementation	2021-04-23 03:02:50 -05:00
logging.h	multiprocess: Add Ipc interface implementation	2021-04-23 03:02:50 -05:00
Makefile.am	devtools: Improve *-check.py tool detection	2021-07-07 19:31:37 +08:00
Makefile.bench.include
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt.include	Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always deterministic	2021-06-03 21:25:30 +08:00
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include	fuzz: fix fuzz binary linking order	2021-06-16 10:41:24 +02:00
Makefile.test_fuzz.include
Makefile.test_util.include
mapport.cpp	refactor: Use appropriate thread constructor	2021-04-29 18:39:01 +03:00
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
miner.cpp	[refactor] Move ComputeBlockVersion into VersionBitsCache	2021-06-30 08:19:12 +10:00
miner.h	miner: Pass in chainman to RegenerateCommitments	2021-05-27 13:50:11 -04:00
net.cpp	Merge bitcoin/bitcoin#22144: Randomize message processing peer order	2021-06-16 11:27:16 +08:00
net.h	p2p: extend inbound eviction protection by network to I2P peers	2021-06-14 14:01:35 +02:00
net_permissions.cpp	p2p: pass strings to NetPermissions::TryParse functions by const ref	2021-05-19 19:41:05 +02:00
net_permissions.h	p2p: pass strings to NetPermissions::TryParse functions by const ref	2021-05-19 19:41:05 +02:00
net_processing.cpp	[refactor] Add deploymentstatus.h	2021-06-29 17:11:12 +10:00
net_processing.h	[net processing] Add internal _RelayTransactions()	2021-05-04 09:31:03 +01:00
net_types.h
netaddress.cpp	Merge bitcoin/bitcoin#22179: Torv2 removal followups	2021-07-08 17:20:35 +02:00
netaddress.h	Merge bitcoin/bitcoin#18722: addrman: improve performance by using more suitable containers	2021-06-12 11:41:27 +08:00
netbase.cpp
netbase.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp	Disallow bech32m addresses for legacy wallet things	2021-06-22 21:57:04 -04:00
outputtype.h	Disallow bech32m addresses for legacy wallet things	2021-06-22 21:57:04 -04:00
pow.cpp
pow.h
prevector.h
protocol.cpp	refactor: Replace memset calls with array initialization	2021-05-13 12:42:21 +01:00
protocol.h	Add roundtrip fuzz tests for CAddress serialization	2021-05-24 18:06:35 -07:00
psbt.cpp	Make GetInputUTXO safer: verify non-witness UTXO match	2021-06-12 12:25:28 -07:00
psbt.h	Construct and use PrecomputedTransactionData in PSBT signing	2021-06-12 12:25:28 -07:00
pubkey.cpp	Add CKey::SignSchnorr function for BIP 340/341 signing	2021-06-12 12:25:28 -07:00
pubkey.h	Add CKey::SignSchnorr function for BIP 340/341 signing	2021-06-12 12:25:28 -07:00
random.cpp	refactor: Replace &foo[0] with foo.data()	2021-05-04 06:55:31 +02:00
random.h
randomenv.cpp
randomenv.h
rest.cpp	validation: Farewell, global Chainstate!	2021-06-10 15:05:25 -04:00
reverse_iterator.h
scheduler.cpp	test: Fix off-by-one in mockscheduler test RPC	2021-05-14 12:49:16 +02:00
scheduler.h
serialize.h	refactor: Switch serialize to uint8_t (1/n)	2021-05-31 14:56:17 +02:00
shutdown.cpp
shutdown.h
signet.cpp	Merge #21330: Deal with missing data in signature hashes more consistently	2021-04-13 10:24:31 +08:00
signet.h
span.h
streams.h	streams: Accept URef obj for VectorReader unserialize	2021-05-05 20:19:03 +02:00
sync.cpp
sync.h
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
tinyformat.h
torcontrol.cpp	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
torcontrol.h
txdb.cpp	doc: add comment about CCoinsViewDBCursor constructor	2021-06-18 14:15:39 -04:00
txdb.h	move-only(ish): don't expose CCoinsViewDBCursor	2021-06-18 14:14:15 -04:00
txmempool.cpp	scripted-diff: tree-wide: Remove all review-only assertions	2021-06-10 15:05:24 -04:00
txmempool.h	[refactor] comment/naming improvements	2021-06-02 09:40:40 +01:00
txorphanage.cpp
txorphanage.h
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h	Make XOnlyPubKey act like byte container	2021-05-24 12:14:16 -07:00
undo.h
validation.cpp	[refactor] Move ComputeBlockVersion into VersionBitsCache	2021-06-30 08:19:12 +10:00
validation.h	[move-only] Move ComputeBlockVersion from validation to versionbits	2021-06-30 08:19:12 +10:00
validationinterface.cpp
validationinterface.h
version.h
versionbits.cpp	[refactor] Move ComputeBlockVersion into VersionBitsCache	2021-06-30 08:19:12 +10:00
versionbits.h	[refactor] Move ComputeBlockVersion into VersionBitsCache	2021-06-30 08:19:12 +10:00
walletinitinterface.h
warnings.cpp
warnings.h