0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
bitcoin-core/src/qt
MarcoFalke 81c533c6f4
Merge #13158: [Qt]: Improve sendcoinsdialog readability
f08a385590 [qt]: changes sendcoinsdialog's box layout for improved readability. (marcoagner)

Pull request description:

  I'm addressing two (probably duplicate) issues: https://github.com/bitcoin/bitcoin/issues/11606 and https://github.com/bitcoin/bitcoin/issues/10613.

  Some points worth noting:

  - I've tried to balance the proposed changes on both issues without going too far and remaining a bit conservative. It will be easier to improve based on suggestions where necessary.

  - I preferred to maintain a layout that doesn't ask for an address truncation because, in my view, this wallet should be conservative on this.

  - I didn't follow the idea of aligning the amounts to the right for finding it more natural (and minimalist) to read the information without having to map alignments. Additionally, that approach seems to need more `<hr />`'s (or similar) in order to help the user to map information, which ended up cluttering the box too much (specially with multiple recipients). Thus, I preferred to just give some more space between recipients. Let me know if there are better ideas on this.

  Visually, I went from this (current):
  ![screenshot from 2018-05-03 15-11-30](https://user-images.githubusercontent.com/5016303/39581859-16abec82-4edc-11e8-86d3-eb722f8a7ed6.png)

  To this:
  ![screenshot from 2018-05-03 15-15-41](https://user-images.githubusercontent.com/5016303/39582066-96856adc-4edc-11e8-804c-468aec44cc8d.png)

  As a side note, while doing this, I thought about a better way to show fees and found there's already a PR on this (https://github.com/bitcoin/bitcoin/pull/12189) and thought it is

Tree-SHA512: e94b740fab6c1babd853a97be65c3b6f86ec174c975a926fde66b147f7a47e0cf0fa10f7255ba92aaba68c76a80dde8c688008179a34705a9799bf24d3c5cd46
2018-05-14 17:07:26 -04:00
..
forms
locale
res
test [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
addressbookpage.cpp
addressbookpage.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
addresstablemodel.cpp Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor 2018-05-02 16:49:59 +02:00
addresstablemodel.h Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor 2018-05-02 16:49:59 +02:00
askpassphrasedialog.cpp
askpassphrasedialog.h
bantablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
bantablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
bitcoin.cpp Make gArgs aware of the arguments 2018-05-09 12:21:05 -04:00
bitcoin.qrc
bitcoin_locale.qrc
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp
bitcoinamountfield.h
bitcoingui.cpp qt:Show the entire Window when double clicking on taskbar 2018-04-17 02:38:10 +08:00
bitcoingui.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
bitcoinstrings.cpp
bitcoinunits.cpp
bitcoinunits.h
callback.h
clientmodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
clientmodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
coincontroldialog.cpp wallet: Make fee settings non-static members 2018-04-23 10:49:21 -04:00
coincontroldialog.h
coincontroltreewidget.cpp
coincontroltreewidget.h
csvmodelwriter.cpp
csvmodelwriter.h
editaddressdialog.cpp [qt] Display more helpful message when adding a send address has failed 2018-04-25 13:08:53 -04:00
editaddressdialog.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
guiconstants.h
guiutil.cpp Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections 2018-04-08 16:24:30 +02:00
guiutil.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
intro.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
intro.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
macdockiconhandler.h
macdockiconhandler.mm
macnotificationhandler.h
macnotificationhandler.mm
Makefile
modaloverlay.cpp
modaloverlay.h
networkstyle.cpp
networkstyle.h
notificator.cpp
notificator.h
openuridialog.cpp
openuridialog.h
optionsdialog.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
optionsdialog.h
optionsmodel.cpp Fix illegal default addProxy and addrSeparateProxyTor settings. 2018-04-10 22:22:55 +02:00
optionsmodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
overviewpage.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
overviewpage.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
paymentrequest.proto
paymentrequestplus.cpp Remove duplicate includes 2018-04-09 09:18:49 +02:00
paymentrequestplus.h
paymentserver.cpp Merge #12729: Get rid of ambiguous OutputType::NONE value 2018-05-03 11:53:30 +02:00
paymentserver.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
peertablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
peertablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
platformstyle.cpp
platformstyle.h
qvalidatedlineedit.cpp
qvalidatedlineedit.h
qvaluecombobox.cpp
qvaluecombobox.h
README.md [doc] qt: fixes broken link on readme 2018-05-01 21:17:54 +01:00
receivecoinsdialog.cpp Remove most direct bitcoin calls from qt/walletmodel.cpp 2018-04-04 16:52:40 -04:00
receivecoinsdialog.h
receiverequestdialog.cpp
receiverequestdialog.h
recentrequeststablemodel.cpp Remove direct bitcoin calls from qt transaction table files 2018-04-04 16:52:40 -04:00
recentrequeststablemodel.h Remove direct bitcoin calls from qt transaction table files 2018-04-04 16:52:40 -04:00
rpcconsole.cpp Add 'sethdseed' RPC to initialize or replace HD seed 2018-05-12 13:15:21 -04:00
rpcconsole.h Make sure initialization occurs in the constructor 2018-05-02 13:56:20 +02:00
sendcoinsdialog.cpp [qt]: changes sendcoinsdialog's box layout for improved readability. 2018-05-08 21:19:12 +01:00
sendcoinsdialog.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
sendcoinsentry.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
sendcoinsentry.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
signverifymessagedialog.cpp Remove most direct bitcoin calls from qt/walletmodel.cpp 2018-04-04 16:52:40 -04:00
signverifymessagedialog.h
splashscreen.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
splashscreen.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
trafficgraphwidget.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
trafficgraphwidget.h
transactiondesc.cpp Add purpose arg to Wallet::getAddress 2018-04-25 13:08:53 -04:00
transactiondesc.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiondescdialog.cpp
transactiondescdialog.h
transactionfilterproxy.cpp
transactionfilterproxy.h
transactionrecord.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactionrecord.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiontablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiontablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactionview.cpp Remove most direct bitcoin calls from qt/walletmodel.cpp 2018-04-04 16:52:40 -04:00
transactionview.h
utilitydialog.cpp Make gArgs aware of the arguments 2018-05-09 12:21:05 -04:00
utilitydialog.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletframe.cpp
walletframe.h
walletmodel.cpp Add purpose arg to Wallet::getAddress 2018-04-25 13:08:53 -04:00
walletmodel.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
walletmodeltransaction.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletmodeltransaction.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletview.cpp Add cancel button to rescan progress dialog 2018-04-12 17:00:30 -04:00
walletview.h
winshutdownmonitor.cpp
winshutdownmonitor.h

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk. Qt 4 is also supported (see #8263).

Compile and run

See build instructions (OSX, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 and BIP70 (see https://github.com/bitcoin/bitcoin/pull/11622) payment URI / requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/cpp)
  • macdockiconhandler.(h/cpp): display notifications in OSX

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for OSX:

  1. Make sure you installed everything through Homebrew mentioned in the OSX build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)