0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-09 15:37:00 -04:00
bitcoin-core/src/test
MacroFake 5057adf22f
Merge bitcoin/bitcoin#25349: CBlockIndex/CDiskBlockIndex improvements for safety, consistent behavior
3a61fc56a0 refactor: move CBlockIndex#ToString() from header to implementation (Jon Atack)
57865eb512 CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash() (Jon Atack)
99e8ec8721 CDiskBlockIndex: remove unused ToString() class member (Jon Atack)
14aeece462 CBlockIndex: ensure phashBlock is not nullptr before dereferencing (Jon Atack)

Pull request description:

  Fix a few design issues, potential footguns and inconsistent behavior in the CBlockIndex and CDiskBlockIndex classes.

  - Ensure phashBlock in `CBlockIndex#GetBlockHash()` is not nullptr before dereferencing and remove a now-redundant assert preceding a GetBlockHash() caller.  This protects against UB here, and in case of failure (which would indicate a consensus bug), the debug log will print `bitcoind: chain.h:265: uint256 CBlockIndex::GetBlockHash() const: Assertion 'phashBlock != nullptr' failed. Aborted` instead of `Segmentation fault`.
  - Remove the unused `CDiskBlockIndex#ToString()` class member, and mark the inherited `CBlockIndex#ToString()` public interface member as deleted to disallow calling it in the derived CDiskBlockIndex class.
  - Rename the `CDiskBlockIndex GetBlockHash()` class member to `ConstructBlockHash()`, which also makes sense as they perform different operations to return a blockhash, and mark the inherited `CBlockIndex#GetBlockHash()` public interface member as deleted to disallow calling it in the derived CDiskBlockIndex class.
  - Move `CBlockIndex#ToString()` from header to implementation, which also allows dropping `tinyformat.h` from the header file.

  Rationale and discussion regarding the CDiskBlockIndex changes:

  Here is a failing test on master that demonstrates the inconsistent behavior of the current design: calling the same inherited public interface functions on the same CDiskBlockIndex object should yield identical behavior, but does not.

  ```diff
  diff --git a/src/test/validation_chainstatemanager_tests.cpp b/src/test/validation_chainstatemanager_tests.cpp
  index 6dc522b421..dac3840f32 100644
  --- a/src/test/validation_chainstatemanager_tests.cpp
  +++ b/src/test/validation_chainstatemanager_tests.cpp
  @@ -240,6 +240,15 @@ BOOST_FIXTURE_TEST_CASE(chainstatemanager_activate_snapshot, TestChain100Setup)

       const CBlockIndex* tip = chainman.ActiveTip();

       BOOST_CHECK_EQUAL(tip->nChainTx, au_data.nChainTx);

  +    // CDiskBlockIndex "is a" CBlockIndex, as it publicly inherits from it.
  +    // Test that calling the same inherited interface functions on the same
  +    // object yields identical behavior.
  +    CDiskBlockIndex index{tip};
  +    CBlockIndex *pB = &index;
  +    CDiskBlockIndex *pD = &index;
  +    BOOST_CHECK_EQUAL(pB->GetBlockHash(), pD->GetBlockHash());
  +    BOOST_CHECK_EQUAL(pB->ToString(), pD->ToString());
  ```

  (build and run: `$ ./src/test/test_bitcoin -t validation_chainstatemanager_tests`)

  The GetBlockHash() test assertion only passes on master because the different methods invoked by the current design happen to return the same result.  If one of the two is changed, it fails like the ToString() assertion does.

  Redefining inherited non-virtual functions is well-documented as incorrect design to avoid inconsistent behavior (see Scott Meyers, Effective C++, Item 36). Class usage is confusing when the behavior depends on the pointer definition instead of the object definition (static binding happening where dynamic binding was expected). This can lead to unsuspected or hard-to-track bugs.

  Outside of critical hot spots, correctness usually comes before optimisation, but the current design dates back to main.cpp and it may possibly have been chosen to avoid the overhead of dynamic dispatch.  This solution does the same: the class sizes are unchanged and no vptr or vtbl is added.

  There are better designs for doing this that use composition instead of inheritance, or that separate the public interface from the private implementations.  One example of the latter would be a non-virtual public interface that calls private virtual implementation methods, i.e. the Template pattern via the Non-Virtual Interface (NVI) idiom.

ACKs for top commit:
  vasild:
    ACK 3a61fc56a0

Tree-SHA512: 9ff358ab0a6d010b8f053ad8303c6d4d061e62d9c3755a56b9c9f5eab855d02f02bee42acc77dfa0cbf4bb5cb775daa72d675e1560610a29bd285c46faa85ab7
2022-07-25 16:20:13 +02:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz Merge bitcoin/bitcoin#25349: CBlockIndex/CDiskBlockIndex improvements for safety, consistent behavior 2022-07-25 16:20:13 +02:00
util refactor: move compat.h into compat/ 2022-07-20 10:34:46 +01:00
addrman_tests.cpp [netgroupman] Add GetMappedAS() and GetGroup() 2022-04-20 14:35:52 +01:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
arith_uint256_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
banman_tests.cpp net: Drop only invalid entries when reading banlist.json 2021-12-14 18:58:45 +01:00
base32_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
base58_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base64_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp refactor: Use Span of std::byte in CExtKey::SetSeed 2022-04-27 19:53:37 +02:00
blockchain_tests.cpp
blockencodings_tests.cpp scripted-diff: test: Use CTxMemPool in TestingSetup 2022-06-15 17:28:55 -04:00
blockfilter_index_tests.cpp indexes, refactor: Pass Chain interface instead of CChainState class to indexes 2022-07-18 13:39:55 -05:00
blockfilter_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
bloom_tests.cpp Use spans of std::byte in serialize 2022-01-02 11:40:31 +01:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
coins_tests.cpp refactor: Remove defunct attributes.h includes 2022-05-21 13:54:33 -05:00
coinstatsindex_tests.cpp Merge bitcoin/bitcoin#25494: indexes: Stop using node internal types 2022-07-19 21:42:48 +01:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
denialofservice_tests.cpp [net processing] Remove CNode::nLocalServices 2022-07-14 15:25:15 +02:00
descriptor_tests.cpp Miniscript support in output descriptors 2022-07-14 12:11:44 +02:00
flatfile_tests.cpp Use AutoFile where possible 2022-06-29 10:33:13 +02:00
fs_tests.cpp test: Correctly decode UTF-8 literal string paths 2022-03-03 14:12:07 -05:00
getarg_tests.cpp test: Remove boost::split from getarg_tests.cpp 2022-04-29 14:35:50 +02:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
httpserver_tests.cpp Add GetQueryParameter helper function 2022-03-10 12:01:54 +01:00
i2p_tests.cpp
interfaces_tests.cpp Guard CBlockIndex::nStatus/nFile/nDataPos/nUndoPos by cs_main 2022-01-25 20:46:52 +01:00
key_io_tests.cpp refactor: Use Span of std::byte in CExtKey::SetSeed 2022-04-27 19:53:37 +02:00
key_tests.cpp refactor: use Span in random.* 2022-03-23 17:36:33 -05:00
logging_tests.cpp logging: add LogPrintfCategory to log unconditionally with category 2022-06-08 14:02:54 +02:00
main.cpp build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
Makefile
mempool_tests.cpp mempool: Make GetMinFee() with custom size protected 2022-06-28 15:36:36 -04:00
merkle_tests.cpp
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Remove LOCKTIME_MEDIAN_TIME_PAST constant 2022-06-22 09:54:15 +02:00
miniscript_tests.cpp refactor: remove unused using directives 2022-07-18 17:25:03 +01:00
minisketch_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
multisig_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
net_peer_eviction_tests.cpp doc: Convert remaining comments to clang-tidy format 2022-04-06 15:37:07 +02:00
net_tests.cpp refactor: move compat.h into compat/ 2022-07-20 10:34:46 +01:00
netbase_tests.cpp [netgroupman] Add GetMappedAS() and GetGroup() 2022-04-20 14:35:52 +01:00
orphanage_tests.cpp [tests] Move TxOrphange tests to orphange_tests.cpp 2022-04-25 08:37:01 +01:00
pmt_tests.cpp Remove not needed ArithToUint256 roundtrips in tests 2022-04-14 19:29:52 +02:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp test/policyestimator: Use ChainTestingSetup's CTxMemPool 2022-06-15 17:28:55 -04:00
pow_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
prevector_tests.cpp test, bench: make prevector and checkqueue swap member functions noexcept 2022-04-28 20:34:43 +02:00
raii_event_tests.cpp
random_tests.cpp Merge bitcoin/bitcoin#24925: refactor: make GetRand a template, remove GetRandInt 2022-05-12 08:57:22 +02:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
sanity_tests.cpp compat: remove glibcxx sanity checks 2022-05-28 09:43:02 +01:00
scheduler_tests.cpp Switch scheduler to steady_clock 2022-05-10 10:54:54 +02:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_segwit_tests.cpp Unit tests for IsWitnessProgram and IsP2WSH. 2021-10-15 06:46:25 +02:00
script_standard_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
script_tests.cpp Use HashWriter where possible 2022-07-20 15:34:36 +02:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp test: Fix Wambiguous-reversed-operator compiler warnings 2022-02-21 16:36:59 +01:00
settings_tests.cpp settings: Add update/getPersistent/isIgnored methods 2022-05-19 11:32:56 -04:00
sighash_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
skiplist_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sock_tests.cpp refactor: move compat.h into compat/ 2022-07-20 10:34:46 +01:00
streams_tests.cpp test: Create fresh CDataStream each time 2022-02-03 20:16:41 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
system_tests.cpp build: Fix Boost.Process test for Boost 1.78 2022-03-21 16:52:27 +00:00
timedata_tests.cpp timedata: make it possible to reset the state 2022-03-02 15:40:30 +01:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
txindex_tests.cpp indexes, refactor: Pass Chain interface instead of CChainState class to indexes 2022-07-18 13:39:55 -05:00
txpackage_tests.cpp refactor: fixup named args in txpackage tests 2022-04-07 12:50:54 +01:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp [test util] add chain name to TestChain100Setup ctor 2022-05-30 16:00:41 -07:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp Merge bitcoin/bitcoin#23595: util: Add ParseHex<std::byte>() helper 2022-05-20 10:47:30 +02:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp miner: Make mempool optional for BlockAssembler 2022-06-06 15:38:09 -04:00
validation_chainstate_tests.cpp Use designated initializers for ChainstateManager::Options 2022-07-14 08:35:23 -04:00
validation_chainstatemanager_tests.cpp Use AutoFile where possible 2022-06-29 10:33:13 +02:00
validation_flush_tests.cpp scripted-diff: test: Use CTxMemPool in TestingSetup 2022-06-15 17:28:55 -04:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp Merge bitcoin/bitcoin#25200: doc: Fix spelling errors identified by codespell in comments 2022-05-31 15:19:59 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred