Samuel Dobson 58f8b156ed Merge bitcoin/bitcoin#22008: wallet: Cleanup and refactor CreateTransactionInternal ... 96c2c9520e scripted-diff: Rename SelectCoinsMinConf to AttemptSelection (Andrew Chow) b583f73354 Move vin filling to before final fee setting (Andrew Chow) d39cac0547 Set m_subtract_fee_outputs during recipients vector loop (Andrew Chow) 364e0698a5 Move variable initializations to where they are used (Andrew Chow) 32ab430651 Move recipients vector checks to beginning of CreateTransaction (Andrew Chow) cd1d6d3324 Rename nSubtractFeeFromAmount in CreateTransaction (Andrew Chow) dac21c793f Rename nValue and nValueToSelect (Andrew Chow) d2aee3bbc7 Remove extraneous scope in CreateTransactionInternal (Andrew Chow) b2995963b5 Move cs_wallet lock in CreateTransactionInternal to top of function (Andrew Chow) Pull request description: #17331 did some refactors and cleanup of `CreateTransactionInternal` to make it easier to understand, however it is still a bit convoluted even though it doesn't have to be. This PR does additional cleanup and refactoring to `CreateTransactionInternal` so that it is easier to understand. Some unnecessary code was removed, some variables moved around to where they matter, and several indents removed. ACKs for top commit: glozow: reACK 96c2c95 ryanofsky: Code review ACK 96c2c9520e also acked previously (was reverted). meshcollider: re-utACK 96c2c9520e Tree-SHA512: 3dba67ed436968a07bfd82d435d566ad74e116c6e50ac9baed7144a46ad5c0f630b1ba59d91e8e8972ac2af559d7c0576f0560f09684d2ab20fad6689902866f		2021-06-09 22:37:34 +12:00
..
coinselector_tests.cpp	scripted-diff: Rename SelectCoinsMinConf to AttemptSelection	2021-05-30 14:10:10 -04:00
db_tests.cpp	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
init_test_fixture.cpp	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
init_test_fixture.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
init_tests.cpp	Change BOOST_CHECK to BOOST_CHECK_EQUAL to see mismatched values when a check fails.	2021-02-09 15:00:02 +01:00
ismine_tests.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
psbt_wallet_tests.cpp	psbt: always put a non_witness_utxo and don't remove it	2020-06-24 16:32:19 -04:00
scriptpubkeyman_tests.cpp	test: Remove no longer needed MakeChain calls	2020-12-07 20:46:03 -05:00
wallet_crypto_tests.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
wallet_test_fixture.cpp	refactor: move first run detection to client code	2021-05-19 08:50:16 +02:00
wallet_test_fixture.h	test: Remove no longer needed MakeChain calls	2020-12-07 20:46:03 -05:00
wallet_tests.cpp	Merge bitcoin/bitcoin#21353: interfaces: Stop exposing wallet destdata to gui	2021-06-03 15:57:30 +02:00
walletdb_tests.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00