0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
bitcoin-core/src/rpc
Ava Chow 11f68cc810
Merge bitcoin/bitcoin#31212: util: Improve documentation and negation of args
95a0104f2e test: Add tests for directories in place of config files (Hodlinator)
e85abe92c7 args: Catch directories in place of config files (Hodlinator)
e4b6b1822c test: Add tests for -noconf (Hodlinator)
483f0dacc4 args: Properly support -noconf (Hodlinator)
312ec64cc0 test refactor: feature_config_args.py - Stop nodes at the end of tests, not at the beginning (Hodlinator)
7402658bc2 test: -norpccookiefile (Hodlinator)
39cbd4f37c args: Support -norpccookiefile for bitcoind and bitcoin-cli (Hodlinator)
e82ad88452 logs: Use correct path and more appropriate macros in cookie-related code (Hodlinator)
6e28c76907 test: Harden testing of cookie file existence (Hodlinator)
75bacabb55 test: combine_logs.py - Output debug.log paths on error (Hodlinator)
bffd92f00f args: Support -nopid (Hodlinator)
12f8d848fd args: Disallow -nodatadir (Hodlinator)
6ff9662760 scripted-diff: Avoid printing version information for -noversion (Hodlinator)
e8a2054edc doc args: Document narrow scope of -color (Hodlinator)

Pull request description:

  - Document `-color` as only applying to `-getinfo`, to be less confusing for bitcoin-cli users.
  - No longer print version information when getting passed `-noversion`.
  - Disallow `-nodatadir` as we cannot run without one. It was previously interpreted as a mix of unset and as a relative path of "0".
  - Support `-norpccookiefile`
  - Support `-nopid`
  - Properly support `-noconf` (instead of working by accident). Also detect when directories are specified instead of files.

  Prompted by investigation in https://github.com/bitcoin/bitcoin/pull/16545#pullrequestreview-2316714013.

ACKs for top commit:
  l0rinc:
    utACK 95a0104f2e
  achow101:
    ACK 95a0104f2e
  ryanofsky:
    Code review ACK 95a0104f2e. Looks good! Thanks for all your work on this breaking the changes down and making them simple.

Tree-SHA512: 5174251e6b9196a9c6d135eddcb94130295c551bcfccc78e633d9e118ff91523b1be0d72828fb49603ceae312e6e1f8ee2651c6a2b9e0f195603a73a9a622785
2024-12-04 13:20:46 -05:00
..
blockchain.cpp Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 2024-11-27 12:23:35 -05:00
blockchain.h
client.cpp Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 2024-11-27 12:23:35 -05:00
client.h
external_signer.cpp
fees.cpp
mempool.cpp Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1 2024-12-03 17:46:23 -05:00
mempool.h
mining.cpp Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks 2024-12-03 17:38:41 -05:00
mining.h
net.cpp
node.cpp
output_script.cpp refactor: Fix remaining clang-tidy performance-inefficient-vector errors 2024-11-25 20:09:44 +01:00
protocol.h
rawtransaction.cpp Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 2024-11-27 12:23:35 -05:00
rawtransaction_util.cpp
rawtransaction_util.h
register.h
request.cpp args: Support -norpccookiefile for bitcoind and bitcoin-cli 2024-12-03 10:38:21 +01:00
request.h
server.cpp
server.h
server_util.cpp
server_util.h
signmessage.cpp
txoutproof.cpp
util.cpp Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 2024-11-27 12:23:35 -05:00
util.h Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity 2024-11-27 12:23:35 -05:00