fanquake 7799f53542 Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2) ... fa9f6d7bcd rpc: Run type check against RPCArgs (MarcoFalke) faf96721a6 test: Fix wrong types passed to RPCs (MarcoFalke) Pull request description: It seems brittle to require `RPCTypeCheck` being called inside the code logic. Without compile-time enforcement this will lead to places where it is forgotten and thus to inconsistencies and bugs. Fix this by removing the calls to `RPCTypeCheck` and doing the check internally. The changes should be reviewed as refactoring changes. However, if they change behavior, it will be a bugfix. For example the changes here happen to also detect/fix bugs like the one fixed in commit 3b5fb6e77a. ACKs for top commit: ajtowns: ACK fa9f6d7bcd Tree-SHA512: fb2c0981fe6e24da3ca7dbc06898730779ea4e02ea485458505a281cf421015e44dad0221a04023fc547ea2c660d94657909843fc85d92b847611ec097532439		2023-01-17 09:39:26 +00:00
..
rpc	Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2)	2023-01-17 09:39:26 +00:00
test	Merge bitcoin/bitcoin#26758: refactor: Add performance-no-automatic-move clang-tidy check	2023-01-11 16:18:34 +01:00
bdb.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
bdb.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coincontrol.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coincontrol.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coinselection.cpp	Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages	2023-01-03 18:53:36 -05:00
coinselection.h	Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages	2023-01-03 18:53:36 -05:00
context.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
context.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
db.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
db.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
dump.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
dump.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
external_signer_scriptpubkeyman.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
external_signer_scriptpubkeyman.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
feebumper.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
feebumper.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
fees.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
fees.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
init.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
interfaces.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
ismine.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
load.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
load.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
receive.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
receive.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
salvage.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
salvage.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
scriptpubkeyman.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
scriptpubkeyman.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
spend.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
spend.h	Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages	2023-01-03 18:53:36 -05:00
sqlite.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
sqlite.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
transaction.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
transaction.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
wallet.cpp	Merge bitcoin/bitcoin#26675: wallet: For feebump, ignore abandoned descendant spends	2023-01-11 18:24:53 -05:00
wallet.h	Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods	2023-01-04 17:53:58 +00:00
walletdb.cpp	Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename	2023-01-03 11:54:51 -05:00
walletdb.h	Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename	2023-01-03 11:54:51 -05:00
wallettool.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
wallettool.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
walletutil.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
walletutil.h	Implement LegacyScriptPubKeyMan::MigrateToDescriptor	2022-08-25 16:25:53 -04:00