Andrew Chow 7be62df80f Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet ... fb3e812277 p2p: return `CSubNet` in `LookupSubNet` (brunoerg) Pull request description: Analyzing the usage of `LookupSubNet`, noticed that most cases uses check if the subnet is valid by calling `subnet.IsValid()`, and the boolean returned by `LookupSubNet` hasn't been used so much, see: 29d540b7ad/src/httpserver.cpp (L172-L174) 29d540b7ad/src/net_permissions.cpp (L114-L116) It makes sense to return `CSubNet` instead of `bool`. ACKs for top commit: achow101: ACK fb3e812277 vasild: ACK fb3e812277 theStack: Code-review ACK fb3e812277 stickies-v: Concept ACK, but Approach ~0 (for now). Reviewed the code (fb3e812277) and it all looks good to me. Tree-SHA512: ba50d6bd5d58dfdbe1ce1faebd80dd8cf8c92ac53ef33519860b83399afffab482d5658cb6921b849d7a3df6d5cea911412850e08f3f4e27f7af510fbde4b254		2023-10-26 14:29:47 -04:00
..
blockchain.cpp	scripted-diff: Rename hash_serialized_2 to hash_serialized_3	2023-10-20 22:53:06 +02:00
blockchain.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
client.cpp	rpc: addnode arg to use BIP324 v2 p2p	2023-10-02 18:10:30 -04:00
client.h	refactor: rpc: hide and rename ParseNonRFCJSONValue()	2023-03-23 18:18:46 +00:00
external_signer.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
fees.cpp	rpc: Run type check against RPCArgs	2023-01-11 17:42:09 +01:00
mempool.cpp	[rpc] allow submitpackage to be called outside of regtest	2023-10-02 10:13:38 +01:00
mempool.h	rpc: Move mempool RPCs to new file	2022-03-11 17:46:58 +01:00
mining.cpp	rpc: Add MaybeArg() and Arg() default helper	2023-08-24 10:44:45 +02:00
mining.h
net.cpp	Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet	2023-10-26 14:29:47 -04:00
node.cpp	Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers	2023-08-07 22:31:46 +02:00
output_script.cpp	Add PubKeyDestination for P2PK scripts	2023-09-12 12:14:31 -04:00
protocol.h	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
rawtransaction.cpp	tidy: modernize-use-emplace	2023-10-12 11:27:19 +02:00
rawtransaction_util.cpp	Fix clang-tidy performance-unnecessary-copy-initialization warnings	2023-05-09 18:48:52 +02:00
rawtransaction_util.h	wallet: add outputs arguments to bumpfee and psbtbumpfee	2023-01-17 13:28:53 +02:00
register.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
request.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
request.h	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
server.cpp	tidy: modernize-use-emplace	2023-10-12 11:27:19 +02:00
server.h	RPC: Add add OBJ_NAMED_PARAMS type	2023-05-03 11:27:51 -05:00
server_util.cpp	refactor: add and use EnsureAnyAddrman in rpc	2023-10-04 08:53:51 +05:30
server_util.h	refactor: add and use EnsureAnyAddrman in rpc	2023-10-04 08:53:51 +05:30
signmessage.cpp	rpc: Move signmessage RPC util to new file	2022-04-28 11:19:29 +02:00
txoutproof.cpp	refactor: Move functions to BlockManager methods	2023-05-10 19:06:53 +02:00
util.cpp	rpc: addnode arg to use BIP324 v2 p2p	2023-10-02 18:10:30 -04:00
util.h	rpc: Add MaybeArg() and Arg() default helper	2023-08-24 10:44:45 +02:00