foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-09 15:37:00 -04:00
Code Issues Activity
bitcoin-core/src/qt/forms
History
Wladimir J. van der Laan 7fca189a2a
Merge #79: Embed monospaced font 
67f26319a0 gui: Add monospaced font settings (Hennadii Stepanov)
22e0114d05 qt: Choose monospaced font in C++ code rather in `*.ui` file (Hennadii Stepanov)
623de12d04 qt: Make GUIUtil::fixedPitchFont aware of embedded font (Hennadii Stepanov)
89e421918e gui: Add Roboto Mono font (Hennadii Stepanov)

Pull request description:

  Qt does not guarantee that the actual applied font matches to the requested one.
  It was noted (https://github.com/bitcoin/bitcoin/pull/16432#issuecomment-514486077):
  > the monospace font looks a bit weird no macOS

  ... because it is _not_ monospaced.
  Also some discrepancies I've noted on Windows while testing Qt 5.15 ([#19716](https://github.com/bitcoin/bitcoin/pull/19716)).

  Of course, we could check the actual font with `QFontInfo`, and try to choose another font.
  But this PR suggests to just embed a monospaced font, and get the GUI look (partially) independent from a platform.

  [Roboto Mono](https://fonts.google.com/specimen/Roboto+Mono) was chosen after discussion with Bitcoin Design community, and due to its [Apache License, Version 2.0](https://fonts.google.com/specimen/Roboto+Mono#license).

  Changes are scoped to the Overview page only.

  ---

  Screenshots on macOS 10.15.6 (images are simulated by code patching):

  - master (ca30d34cf9)
  ![Screenshot from 2020-09-03 14-10-03](https://user-images.githubusercontent.com/32963518/92107902-30357d80-edef-11ea-8a4f-b4c758eebf66.png)

  - this PR (3fdd5b6bd17a679d6e3876682266092159c52d59)
  ![Screenshot from 2020-09-03 15-41-36](https://user-images.githubusercontent.com/32963518/92116277-4b5aba00-edfc-11ea-8cb9-22fc44460bfb.png)

  ---

  More screenshots added after https://github.com/bitcoin-core/gui/pull/79#issuecomment-782909149:

  - Linux Mint 20.1 + Cinnamon DE

  ![DeepinScreenshot_select-area_20210221205410](https://user-images.githubusercontent.com/32963518/108635739-b327be80-7489-11eb-8851-ac89f61199ee.png)

  - Windows 10 (with depends)

  ![DeepinScreenshot_select-area_20210221205056](https://user-images.githubusercontent.com/32963518/108635741-b6bb4580-7489-11eb-8b6b-66be5551eb8c.png)

  - macOS Big Sur (with depends)

  ![DeepinScreenshot_select-area_20210221202917](https://user-images.githubusercontent.com/32963518/108635746-bd49bd00-7489-11eb-8cd2-cf4bb2273a6d.png)

ACKs for top commit:
  laanwj:
    Tested ACK 67f26319a0

Tree-SHA512: a59775570b8ce314669ede50a0b69f53e8a47a41e7eea428835013240f0ce9afcff6e4c258895455b56806417ed877e5b7a9522f1904e95a5f435db8ccf6078c
2021-02-22 13:01:06 +01:00
..
addressbookpage.ui [qt] Add support to search the address book 2018-01-03 16:15:15 +00:00
askpassphrasedialog.ui gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog 2019-09-09 10:57:38 +02:00
coincontroldialog.ui gui: move coin control OK to the right 2019-05-28 11:16:39 -04:00
createwalletdialog.ui qt: Use layout manager for Create Wallet dialog 2021-01-06 23:35:24 +02:00
debugwindow.ui Merge bitcoin-core/gui#206: Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details 2021-02-22 08:19:53 +01:00
editaddressdialog.ui qt: refactor: Use absolute include paths in .ui files 2017-11-16 08:23:02 +13:00
helpmessagedialog.ui Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
intro.ui [gui] intro: add prune preference 2019-08-24 22:41:32 +02:00
modaloverlay.ui gui: Shortcut to close ModalOverlay 2020-01-24 20:27:49 +01:00
openuridialog.ui gui: Move static placeholder texts to forms 2019-12-09 11:12:20 +01:00
optionsdialog.ui gui: Add monospaced font settings 2021-02-21 21:01:42 +02:00
overviewpage.ui qt: Choose monospaced font in C++ code rather in *.ui file 2021-02-21 21:01:03 +02:00
psbtoperationsdialog.ui [gui] PSBT Operations Dialog (sign & broadcast) 2020-06-19 02:20:04 -07:00
receivecoinsdialog.ui qt: Make "Create new receiving address" default unconditionally 2020-07-21 21:24:28 +03:00
receiverequestdialog.ui qt: Overhaul ReceiveRequestDialog 2020-05-05 05:56:50 +03:00
sendcoinsdialog.ui [gui] send: show watch-only balance in send screen 2019-11-26 11:43:53 +01:00
sendcoinsentry.ui qt: Normalize placeholder to avoid using "address book" in sendcoinsentry 2019-12-09 12:28:55 +01:00
signverifymessagedialog.ui gui: Move static placeholder texts to forms 2019-12-09 11:12:20 +01:00
transactiondescdialog.ui qt: Add transaction hash to details window title 2016-04-26 16:05:10 +02:00