Wladimir J. van der Laan 80f9dad0b7 Merge #11809: gui: Fix proxy setting options dialog crash ... f05d349 gui: Fix proxy setting options dialog crash (Wladimir J. van der Laan) Pull request description: This fixes a crash bug when opening the options dialog. - Check the return value of split() to avoid segmentation faults due to out of bounds when the user manages to enter invalid proxy settings. This is reported resonably often. - Move the default proxy/port to a constant instead of hardcoding magic values. - Factor out some common code. - Revert #11448 because this proves a more robust replacement, it is no longer necessary and didn't generally solve the issue. No attempt is made to do full sanity checking on the proxy, so it can still be rejected by the core with an InitError message. Tree-SHA512: 72b700b7d6c4d3e3410f0c60e9e4facf93d7c6c1a1b6b23957c48b074a045970f518166952859d1ebca8620062cb70d222670a7310bbd6fe50550ec6d04417b5		2017-12-07 17:40:11 +01:00
..
bench	Merge #11654: tests: Initialize recently introduced non-static class member lastCycles to zero in constructor	2017-11-16 11:49:42 +01:00
compat	Merge #11140: Trivial: Improve #endif comments	2017-11-17 15:34:51 +01:00
config
consensus	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
crypto	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
leveldb	Update LevelDB with latest Bitcoin-specific patches	2017-08-01 12:40:42 -07:00
obj
obj-test
policy	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
primitives	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
qt	Merge #11809: gui: Fix proxy setting options dialog crash	2017-12-07 17:40:11 +01:00
rpc	qa: Add getrawtransaction in_active_chain=False test	2017-12-06 11:00:08 -05:00
script	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
secp256k1	Bump secp256k1 subtree	2017-09-29 16:02:39 +02:00
support	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
test	Merge #11804: [docs] Fixed outdated link with archive.is	2017-12-01 15:28:53 +01:00
univalue	Bump univalue and fix json formatting in tests	2017-09-29 14:35:46 +02:00
wallet	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
zmq	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
.clang-format	Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>	2017-07-04 18:05:18 +02:00
addrdb.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
addrdb.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
addrman.cpp	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
addrman.h	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
amount.h	Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module	2017-05-03 18:00:13 +02:00
arith_uint256.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
arith_uint256.h	Merge #10749: Use compile-time constants instead of unnamed enumerations (remove "enum hack")	2017-11-11 18:07:28 -05:00
base58.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
base58.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bech32.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bech32.h	Import Bech32 C++ reference code & tests	2017-09-28 16:02:16 -07:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	cli: Reject arguments to -getinfo	2017-11-17 15:11:50 +01:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoind-res.rc
bitcoind.cpp	Create walletdir if datadir doesn't exist and fix tests	2017-11-18 00:50:59 +13:00
blockencodings.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
blockencodings.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bloom.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bloom.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
chain.cpp	Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads	2017-12-01 15:19:07 +01:00
chain.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
chainparams.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
chainparams.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
chainparamsbase.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
chainparamsbase.h	Chainparams: Use a regular factory for creating chainparams	2017-05-03 18:15:47 +02:00
chainparamsseeds.h	p2p: Hardcoded seeds update pre-0.15 branch	2017-07-30 14:04:51 +02:00
checkpoints.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
checkpoints.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
checkqueue.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
clientversion.cpp	refactor: Include obj/build.h instead of build.h	2017-11-16 08:23:03 +13:00
clientversion.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
coins.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
coins.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
compat.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
compressor.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
compressor.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
core_io.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
core_memusage.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
core_read.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
core_write.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
cuckoocache.h	Fix header guards using reserved identifiers	2017-08-26 02:56:53 +03:00
dbwrapper.cpp	Prefix leveldb debug logging	2017-11-30 09:29:25 +01:00
dbwrapper.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
fs.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
fs.h	[Trivial] Add BITCOIN_FS_H endif footer in fs.h	2017-05-19 02:01:28 -07:00
hash.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
hash.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
httprpc.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
httprpc.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
httpserver.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
httpserver.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
indirectmap.h
init.cpp	Add -debuglogfile option	2017-11-30 11:16:02 +01:00
init.h	init: Factor out AppInitLockDataDirectory	2017-07-17 14:56:52 +02:00
key.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
key.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
keystore.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
keystore.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
limitedmap.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
Makefile.am	Add -walletdir parameter to specify custom wallet dir	2017-11-18 00:50:58 +13:00
Makefile.bench.include	build: Make "make clean" remove all files created when running "make check"	2017-10-04 14:54:41 +02:00
Makefile.leveldb.include	build: verify that the assembler can handle crc32 functions	2017-07-13 12:49:05 -04:00
Makefile.qt.include	Merge #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck	2017-11-17 14:04:02 +01:00
Makefile.qttest.include	Remove redundant testutil files	2017-09-05 15:02:17 +12:00
Makefile.test.include	[tests] Test that mempool rejects coinbase transactions	2017-11-18 00:48:34 -08:00
memusage.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
merkleblock.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
merkleblock.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
miner.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
miner.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
net.cpp	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
net.h	Add Clang thread safety analysis annotations	2017-11-23 07:59:58 +01:00
net_processing.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
net_processing.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
netaddress.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
netaddress.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
netbase.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
netbase.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
netmessagemaker.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
noui.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
noui.h
pow.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
pow.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
prevector.h	Fix header guards using reserved identifiers	2017-08-26 02:56:53 +03:00
protocol.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
protocol.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
pubkey.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
pubkey.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
random.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
random.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
rest.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
reverse_iterator.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
reverselock.h
scheduler.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
scheduler.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
serialize.h	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
streams.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
sync.cpp	threads: add a thread_local autoconf check	2017-11-27 15:01:47 -08:00
sync.h	Switched sync.{cpp,h} to std threading primitives.	2017-11-18 11:35:14 -08:00
threadinterrupt.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
threadinterrupt.h
threadsafety.h
timedata.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
timedata.h
tinyformat.h	[Util] Update tinyformat.h	2017-10-29 21:12:12 +08:00
torcontrol.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
torcontrol.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
txdb.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
txdb.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
txmempool.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
txmempool.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
ui_interface.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
ui_interface.h	Drop upgrade-cancel callback registration for a generic "resumeable"	2017-08-20 20:04:15 -04:00
uint256.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
uint256.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
undo.h	Remove trailing whitespace causing travis failure	2017-11-16 08:23:03 +13:00
util.cpp	Test datadir in conf file exists	2017-12-06 00:24:06 +13:00
util.h	Add -debuglogfile option	2017-11-30 11:16:02 +01:00
utilmoneystr.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
utilmoneystr.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
utilstrencodings.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
utilstrencodings.h	Implement BIP173 addresses and tests	2017-09-28 16:24:30 -07:00
utiltime.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
utiltime.h	[logging] log system time and mock time	2017-05-10 15:49:00 -04:00
validation.cpp	Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction	2017-12-06 12:10:21 +01:00
validation.h	[rpc] Allow getrawtransaction to take optional blockhash to fetch transaction from a block directly.	2017-12-05 11:03:24 +09:00
validationinterface.cpp	Fix shutdown in case of errors during initialization	2017-11-28 12:12:05 +01:00
validationinterface.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
version.h	Remove unused constant MEMPOOL_GD_VERSION	2017-06-09 01:45:36 +02:00
versionbits.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
versionbits.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
warnings.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
warnings.h	remove some unused functions	2017-07-22 09:55:57 +02:00