Ryan Ofsky 8426e018bf Merge bitcoin/bitcoin#30428: log: LogError with FlatFilePos in UndoReadFromDisk ... fa14e1d9d5 log: Fix __func__ in LogError in blockstorage module (MarcoFalke) fad59a2f0f log: LogError with FlatFilePos in UndoReadFromDisk (MarcoFalke) aaaa3323f3 refactor: Mark IsBlockPruned const (MarcoFalke) Pull request description: These errors should never happen in normal operation. If they do, knowing the `FlatFilePos` may be useful to determine if data corruption happened. Also, handle the error `pos.IsNull()` as part of `OpenUndoFile`, because it may as well have happened due to data corruption. This mirrors the `LogError` behavior from `ReadBlockFromDisk`. Also, two other fixup commits in this module. ACKs for top commit: kevkevinpal: ACK [fa14e1d](fa14e1d9d5) tdb3: cr and light test ACK fa14e1d9d5 ryanofsky: Code review ACK fa14e1d9d5. This should make logging clearer and more consistent Tree-SHA512: abb492a919b4796698d1de0a7874c8eae355422b992aa80dcd6b59c2de1ee0d2949f62b3cf649cd62892976fee640358f7522867ed9d48a595d6f8f4e619df50		2024-07-15 13:42:53 -04:00
..
bench	Merge bitcoin/bitcoin#30407: test: [refactor] Pass TestOpts	2024-07-15 17:21:55 +01:00
common	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
compat
config
consensus	refactor: Rename CTransaction::nVersion to version	2024-06-07 13:55:23 -04:00
crc32c
crypto	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
index	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
init	Introduce Mining interface	2024-06-18 18:47:51 +02:00
interfaces	Merge bitcoin-core/gui#825: Show maximum mempool size in information window	2024-07-14 13:07:44 +01:00
ipc
kernel	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
leveldb	Update leveldb-subtree subtree to latest upstream	2024-06-13 13:17:57 +01:00
logging
minisketch	Update minisketch subtree to latest master	2024-06-12 14:38:39 +01:00
node	Merge bitcoin/bitcoin#30428: log: LogError with FlatFilePos in UndoReadFromDisk	2024-07-15 13:42:53 -04:00
policy	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
primitives	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
qt	Merge bitcoin-core/gui#827: OptionsDialog: Prefer to stretch actual options area rather than waste space	2024-07-15 12:15:09 +01:00
rpc	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
script	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
secp256k1	Update secp256k1 subtree to latest master	2024-06-25 15:01:00 +01:00
support	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
test	Merge bitcoin/bitcoin#30407: test: [refactor] Pass TestOpts	2024-07-15 17:21:55 +01:00
univalue
util	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
wallet	Merge bitcoin/bitcoin#30373: fuzz: fix key size in crypter	2024-07-15 11:40:11 +01:00
zmq	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
.bear-tidy-config
.clang-format
.clang-tidy	Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment	2024-07-11 19:21:05 +01:00
addrdb.cpp	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
addrdb.h
addresstype.cpp
addresstype.h
addrman.cpp	random: add RandomMixin::randbits with compile-known bits	2024-07-01 10:26:46 -04:00
addrman.h
addrman_impl.h
arith_uint256.cpp
arith_uint256.h	Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment	2024-07-11 19:21:05 +01:00
attributes.h
banman.cpp
banman.h
base58.cpp
base58.h
bech32.cpp	Reduce memory copying operations in bech32 encode	2024-06-05 13:18:13 +02:00
bech32.h
bip324.cpp
bip324.h
bitcoin-chainstate.cpp	kernel: De-globalize signature cache	2024-07-05 09:03:04 +02:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	Merge bitcoin/bitcoin#29015: kernel: Streamline util library	2024-06-12 17:12:54 -04:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	Merge bitcoin/bitcoin#29015: kernel: Streamline util library	2024-06-12 17:12:54 -04:00
bitcoin-util-res.rc
bitcoin-util.cpp
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	Merge bitcoin/bitcoin#29015: kernel: Streamline util library	2024-06-12 17:12:54 -04:00
bitcoind-res.rc
bitcoind.cpp	refactor: remove warnings globals	2024-06-13 11:20:49 +01:00
blockencodings.cpp	test: Make blockencodings_tests deterministic	2024-06-19 22:56:30 +01:00
blockencodings.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
blockfilter.cpp
blockfilter.h
chain.cpp
chain.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
chainparams.cpp
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp	log: use error level for critical log messages	2024-06-10 13:46:56 +02:00
coins.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
compressor.cpp
compressor.h	refactor: Rename CTransaction::nVersion to version	2024-06-07 13:55:23 -04:00
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp	refactor: Rename CTransaction::nVersion to version	2024-06-07 13:55:23 -04:00
cuckoocache.h	validation: Don't error if maxsigcachesize exceeds uint32::max	2024-07-04 22:35:29 +02:00
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp
external_signer.cpp
external_signer.h
flatfile.cpp
flatfile.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
hash.cpp
hash.h
headerssync.cpp	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
headerssync.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
httprpc.cpp	Merge bitcoin/bitcoin#28167: init: Add option for rpccookie permissions (replace 26088)	2024-06-27 17:35:08 -04:00
httprpc.h
httpserver.cpp	rest: don't copy data when sending binary response	2024-06-26 06:47:30 +03:00
httpserver.h	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
i2p.cpp	Merge bitcoin/bitcoin#29833: i2p: fix and improve logs	2024-06-26 15:28:26 -04:00
i2p.h	i2p: log errors properly according to their severity	2024-06-12 16:19:50 -03:00
indirectmap.h
init.cpp	Merge bitcoin/bitcoin#30141: kernel: De-globalize validation caches	2024-07-08 12:14:12 -04:00
init.h
key.cpp
key.h	refactor: add self-assign checks to classes which violate the clang-tidy check	2024-06-14 10:27:03 +00:00
key_io.cpp
key_io.h
logging.cpp
logging.h
Makefile.am	remove truc_policy.cpp from libbitcoin_common_a_SOURCES	2024-07-11 11:55:37 +01:00
Makefile.bench.include	random bench refactor: move to new bench/random.cpp	2024-07-05 09:51:26 -04:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include
Makefile.qt.include
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include	random: move XoRoShiRo128PlusPlus into random module	2024-07-01 10:26:46 -04:00
Makefile.test_fuzz.include
Makefile.test_util.include	random: move XoRoShiRo128PlusPlus into random module	2024-07-01 10:26:46 -04:00
Makefile.univalue.include
mapport.cpp	upnp: add compatibility for miniupnpc 2.2.8	2024-06-18 12:24:48 +00:00
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
net.cpp	Merge bitcoin/bitcoin#30396: random: add benchmarks and drop unnecessary Shuffle function	2024-07-09 17:52:47 -04:00
net.h	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
net_permissions.cpp
net_permissions.h
net_processing.cpp	Merge bitcoin/bitcoin#29996: Assumeutxo: bugfix on loadtxoutset with a divergent chain + test	2024-07-10 15:18:33 -04:00
net_processing.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
net_types.cpp
net_types.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
netaddress.cpp
netaddress.h	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
netbase.cpp	refactor: use #ifdef HAVE_SOCKADDR_UN	2024-06-21 09:43:46 +01:00
netbase.h	netbase: extend CreateSock() to support creating arbitrary sockets	2024-06-14 14:23:50 +02:00
netgroup.cpp
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
protocol.cpp
protocol.h
psbt.cpp
psbt.h	Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default	2024-07-11 19:08:46 +01:00
pubkey.cpp
pubkey.h
random.cpp	random: replace construct/assign with explicit Reseed()	2024-07-01 12:39:57 -04:00
random.h	random: drop ad-hoc Shuffle in favor of std::shuffle	2024-07-06 09:06:36 -04:00
randomenv.cpp	util: Use SteadyClock in RandAddSeedPerfmon	2024-07-01 17:40:35 +02:00
randomenv.h
rest.cpp	rest: don't copy data when sending binary response	2024-06-26 06:47:30 +03:00
rest.h
reverse_iterator.h
scheduler.cpp
scheduler.h
serialize.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
signet.cpp	refactor: Rename CTransaction::nVersion to version	2024-06-07 13:55:23 -04:00
signet.h
span.h
streams.cpp
streams.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
sync.cpp
sync.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
threadsafety.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
tinyformat.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
torcontrol.cpp
torcontrol.h
txdb.cpp
txdb.h
txmempool.cpp	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
txmempool.h
txorphanage.cpp
txorphanage.h	Don't use iterator addresses in IteratorComparator	2024-06-19 10:14:31 +01:00
txrequest.cpp	random: get rid of GetRand by inlining	2024-07-01 12:39:53 -04:00
txrequest.h
uint256.cpp
uint256.h
undo.h
validation.cpp	Merge bitcoin/bitcoin#30295: #28984 package rbf followups	2024-07-12 17:15:27 +01:00
validation.h	Merge bitcoin/bitcoin#30141: kernel: De-globalize validation caches	2024-07-08 12:14:12 -04:00
validationinterface.cpp	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00
validationinterface.h
versionbits.cpp
versionbits.h
walletinitinterface.h	tidy: modernize-use-equals-default	2024-07-08 11:12:01 +02:00