0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-10 15:46:48 -04:00
bitcoin-core/src/wallet/rpc
MarcoFalke 9887fc7898
Merge bitcoin/bitcoin#26758: refactor: Add performance-no-automatic-move clang-tidy check
9567bfeab9 clang-tidy: Add `performance-no-automatic-move` check (Hennadii Stepanov)

Pull request description:

  Split from bitcoin/bitcoin#26642 as [requested](https://github.com/bitcoin/bitcoin/pull/26642#discussion_r1054673201).

  For the problem description see https://clang.llvm.org/extra/clang-tidy/checks/performance/no-automatic-move.html.

  The following types are affected:
  - `std::pair<CAddress, NodeSeconds>`
  - `std::vector<CAddress>`
  - `UniValue`, also see bitcoin/bitcoin#25429
  - `QColor`
  - `CBlock`
  - `MempoolAcceptResult`
  - `std::shared_ptr<CWallet>`
  - `std::optional<SelectionResult>`
  - `CTransactionRef`, which is `std::shared_ptr<const CTransaction>`

ACKs for top commit:
  andrewtoth:
    ACK 9567bfeab9
  aureleoules:
    ACK 9567bfeab9

Tree-SHA512: 9b6a5d539205b41d2c86402d384318ed2e1d89e66333ebd200a48fd7df3ce6f6c60a3e989eda5cc503fb34b8d82526f95e56776e1af51e63b49e3a1fef72dbcb
2023-01-11 16:18:34 +01:00
..
addresses.cpp Merge bitcoin/bitcoin#26186: rpc: Sanitize label name in various RPCs with tests 2023-01-10 17:31:19 -05:00
backup.cpp Merge bitcoin/bitcoin#26186: rpc: Sanitize label name in various RPCs with tests 2023-01-10 17:31:19 -05:00
coins.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
encrypt.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
signmessage.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
spend.cpp rpc: Correct RPCHelpMan for fundrawtransaction's input_weights field 2023-01-02 14:31:49 -05:00
transactions.cpp Merge bitcoin/bitcoin#26186: rpc: Sanitize label name in various RPCs with tests 2023-01-10 17:31:19 -05:00
util.cpp Merge bitcoin/bitcoin#26758: refactor: Add performance-no-automatic-move clang-tidy check 2023-01-11 16:18:34 +01:00
util.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet.cpp Merge bitcoin/bitcoin#26618: rpc: Prevent unloading a wallet when rescanning 2023-01-09 16:56:40 -05:00
wallet.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00