merge-script 35bf426e02 Merge bitcoin/bitcoin#28724: wallet: Cleanup accidental encryption keys in watchonly wallets ... 69e95c2b4f tests: Test cleanup of mkeys from wallets without privkeys (Andrew Chow) 2b9279b50a wallet: Remove unused encryption keys from watchonly wallets (Andrew Chow) 813a16a463 wallet: Add HasCryptedKeys (Andrew Chow) Pull request description: An earlier version allowed users to create watchonly wallets (wallets without private keys) that were "encrypted". Such wallets would have a stored encryption keys, but nothing would actually be encrypted with them. This can cause unexpected behavior such as https://github.com/bitcoin-core/gui/issues/772. We can detect such wallets as they will have the disable private keys flag set, no encrypted keys, and encryption keys. For such wallets, we can remove those encryption keys thereby avoiding any issues that may result from this unexpected situation. ACKs for top commit: sipa: utACK 69e95c2b4f. laanwj: Code review re-ACK 69e95c2b4f furszy: Code review ACK 69e95c2b4f Tree-SHA512: 901932cd709c57e66c598f011f0105a243b5a8b539db2ef3fcf370dca4cf35ae09bc1110e8fca8353be470f159468855a4dd96b99bc9c1112adc86ccc50e1b9d		2025-01-10 15:29:47 +00:00
..
bench
common
compat
consensus	Check leaves size maximum in MerkleComputation	2024-12-17 10:12:31 +07:00
crc32c
crypto	refactor: Allow std::byte in Read(LE/BE)	2024-12-18 10:59:25 +01:00
index	scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)	2024-12-04 15:09:05 -04:00
init	scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)	2024-12-04 15:09:05 -04:00
interfaces	Remove processNewBlock() from mining interface	2024-12-18 09:20:26 +07:00
ipc	Remove processNewBlock() from mining interface	2024-12-18 09:20:26 +07:00
kernel
leveldb
logging
minisketch
node	miner: add package feerate vector to CBlockTemplate	2025-01-07 15:29:17 -05:00
policy	Merge bitcoin/bitcoin#31596: doc: Clarify comments about endianness after #30526	2025-01-06 18:52:59 -05:00
primitives
qt	scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)	2024-12-04 15:09:05 -04:00
rpc	Merge bitcoin/bitcoin#31596: doc: Clarify comments about endianness after #30526	2025-01-06 18:52:59 -05:00
script	Merge bitcoin/bitcoin#31555: descriptor: remove unreachable verification for pkh	2024-12-30 16:40:11 -05:00
secp256k1
support	util: Add missing types in make_secure_unique	2024-12-10 21:51:48 +01:00
test	Merge bitcoin/bitcoin#31549: fuzz: Abort if system time is called without mock time being set	2025-01-09 19:31:07 -05:00
univalue	test: clang-format -i src/univalue/test/unitester.cpp	2024-12-20 15:01:44 +01:00
util	Merge bitcoin/bitcoin#31549: fuzz: Abort if system time is called without mock time being set	2025-01-09 19:31:07 -05:00
wallet	Merge bitcoin/bitcoin#28724: wallet: Cleanup accidental encryption keys in watchonly wallets	2025-01-10 15:29:47 +00:00
zmq
.clang-format
.clang-tidy
addrdb.cpp
addrdb.h
addresstype.cpp
addresstype.h
addrman.cpp
addrman.h
addrman_impl.h
arith_uint256.cpp
arith_uint256.h	doc: Clarify comments about endianness after #30526	2025-01-03 09:19:53 -05:00
attributes.h
banman.cpp
banman.h
base58.cpp	refactor: Avoid needless, unsafe c-style cast	2024-12-19 13:46:31 +01:00
base58.h
bech32.cpp
bech32.h
bip324.cpp
bip324.h
bitcoin-chainstate.cpp
bitcoin-cli-res.rc
bitcoin-cli.cpp
bitcoin-tx-res.rc
bitcoin-tx.cpp
bitcoin-util-res.rc
bitcoin-util.cpp
bitcoin-wallet-res.rc
bitcoin-wallet.cpp
bitcoind-res.rc
bitcoind.cpp
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
chain.cpp
chain.h
chainparams.cpp
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
cluster_linearize.h
CMakeLists.txt
coins.cpp	Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests	2024-12-04 14:09:05 -05:00
coins.h
compressor.cpp
compressor.h
core_io.h
core_memusage.h
core_read.cpp	ci: Update Clang in "tidy" job	2024-12-05 14:37:47 +00:00
core_write.cpp
cuckoocache.h
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp
external_signer.cpp
external_signer.h
flatfile.cpp
flatfile.h
hash.cpp
hash.h
headerssync.cpp
headerssync.h
httprpc.cpp
httprpc.h
httpserver.cpp	scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)	2024-12-04 15:09:05 -04:00
httpserver.h
i2p.cpp
i2p.h
indirectmap.h
init.cpp	init,log: Unify block index and chainstate loading log line	2025-01-09 14:14:43 +01:00
init.h
key.cpp
key.h
key_io.cpp
key_io.h
logging.cpp
logging.h
mapport.cpp
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
net.cpp	Merge bitcoin/bitcoin#28521: net, net_processing: additional and consistent disconnect logging	2024-12-27 09:09:29 -05:00
net.h
net_permissions.cpp
net_permissions.h
net_processing.cpp
net_processing.h
net_types.cpp
net_types.h
netaddress.cpp
netaddress.h
netbase.cpp
netbase.h
netgroup.cpp
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp
protocol.h
psbt.cpp
psbt.h
pubkey.cpp	refactor: Use immediate lambda to work around GCC bug 117966	2024-12-16 10:39:28 +01:00
pubkey.h
random.cpp	fuzz: Abort when using global PRNG without re-seed	2024-12-16 15:23:56 +01:00
random.h
randomenv.cpp
randomenv.h
rest.cpp
rest.h
scheduler.cpp
scheduler.h
serialize.h	Allow std::span in stream serialization	2024-12-19 14:41:21 +01:00
signet.cpp
signet.h
span.h	refactor: Simplify SpanPopBack	2024-12-19 13:46:52 +01:00
streams.cpp
streams.h	refactor: Avoid passing span iterators when data pointers are expected	2024-12-19 14:39:55 +01:00
sync.cpp
sync.h
threadsafety.h
tinyformat.h
torcontrol.cpp	Merge bitcoin/bitcoin#31223: net, init: derive default onion port if a user specified a -port	2024-12-13 18:56:37 -05:00
torcontrol.h
txdb.cpp
txdb.h
txmempool.cpp	txmempool: fix typos in comments	2024-12-31 00:04:20 -03:00
txmempool.h	txmempool: fix typos in comments	2024-12-31 00:04:20 -03:00
txorphanage.cpp
txorphanage.h
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h	doc: Clarify comments about endianness after #30526	2025-01-03 09:19:53 -05:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#31556: validation: Send correct notification during snapshot completion	2024-12-30 14:40:27 -05:00
validation.h	refactor: Move GuessVerificationProgress into ChainstateManager	2024-12-13 16:12:30 +01:00
validationinterface.cpp
validationinterface.h
versionbits.cpp
versionbits.h
walletinitinterface.h