Andrew Chow a8f69541ad Merge bitcoin/bitcoin#25748: refactor: Avoid copies in FlatSigningProvider Merge ... fa3f15f2dd refactor: Avoid copies in FlatSigningProvider Merge (MacroFake) Pull request description: `Merge` will create several copies unconditionally: * To initialize the args `a`, and `b` * `ret`, which is the merge of the two args So change the code to let the caller decide how many copies they need/want: * `a`, and `b` must be explicitly moved or copied by the caller * `ret` is no longer needed, as `a` can be used for it in place "for free" ACKs for top commit: achow101: ACK fa3f15f2dd furszy: looks good, ACK fa3f15f2 ryanofsky: Code review ACK fa3f15f2dd. Confirmed that all the places `std::move` was added the argument actually did seem safe to move from. Compiler enforces that temporary copies are explicitly created in non-move cases. Tree-SHA512: 7c027ccdea1549cd9f37403344ecbb76e008adf545f6ce52996bf95e89eb7dc89af6cb31435a9289d6f2eea1c416961b2fb96348bc8a211d550728f1d99ac49c		2022-08-17 17:57:33 -04:00
..
addresses.cpp	script/sign: remove needless IsSolvable() utility	2022-08-11 15:43:40 +02:00
backup.cpp	refactor: remove unnecessary string initializations	2022-07-26 10:16:42 +01:00
coins.cpp	Merge bitcoin/bitcoin#25734: wallet, refactor: #24584 follow-ups	2022-08-16 20:00:19 -04:00
encrypt.cpp	scripted-diff: Replace NullUniValue with UniValue::VNULL	2022-07-25 17:27:53 +02:00
signmessage.cpp	scripted-diff: Replace NullUniValue with UniValue::VNULL	2022-07-25 17:27:53 +02:00
spend.cpp	Merge bitcoin/bitcoin#25748: refactor: Avoid copies in FlatSigningProvider Merge	2022-08-17 17:57:33 -04:00
transactions.cpp	Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors	2022-08-16 13:08:05 -04:00
util.cpp	Merge bitcoin/bitcoin#24678: Prevent wallet unload on GetWalletForJSONRPCRequest	2022-08-17 14:39:50 +01:00
util.h	rpc: output wallet descriptors for received entries in listsinceblock	2022-07-19 12:46:01 +02:00
wallet.cpp	rpc/wallet: add simulaterawtransaction RPC	2022-08-05 09:48:09 +09:00
wallet.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00