foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-11 15:56:58 -04:00
Code Issues Activity
bitcoin-core/src/qt
History
Hennadii Stepanov aece566249
Merge bitcoin-core/gui#555: Restore Send button when using external signer 
2efdfb88aa gui: restore Send for external signer (Sjors Provoost)
4b5a6cd149 refactor: helper function signWithExternalSigner() (Sjors Provoost)
026b5b4523 move-only: helper function to present PSBT (Sjors Provoost)

Pull request description:

  Fixes #551

  For the simplest use case of a wallet with one external signer and "PSBT Controls" disabled in settings (the default), the send dialog will behave the same as when using a wallet with private keys. I.e. there's no "Create Unsigned" button.

  When PSBT controls are turned on, you can now actually make a PSBT with signing it; before this PR that button would trigger a sign event and would broadcast the transaction.

  In case a multisig, the Send button will sign on the device, and then fall back to presenting a PSBT (same behavior as before #441).

  This PR starts with two refactoring commits to move some stuff into a helper function for improved readability in general, and to make the main commit easier to review.

ACKs for top commit:
  jonatack:
    utACK 2efdfb88aa diff review since my last review, code re-review, rebased to current master, verified clean debug build of each commit
  luke-jr:
    utACK 2efdfb88aa

Tree-SHA512: e8731a0ef9e87564b2676c7b022b742d9621bba964c19dba9fd9f6961eb608737a9e1a22c0a3c8b2f2f6d583bba067606ee8392422e82082deefb20ea7b88c7c
2022-03-17 07:21:07 +01:00
..
android build, qt: No need to set inapplicable QPA backend for Android 2022-01-03 14:45:39 +02:00
forms gui: use available space to display "Last Transaction" in peer details 2022-01-24 10:53:44 +01:00
locale qt: Pre-branch translation updates for 23.x 2022-02-28 16:59:56 +01:00
res scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
test qt: Avoid crash on startup if int specified in settings.json 2022-03-07 13:29:46 -05:00
addressbookpage.cpp scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
addressbookpage.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addresstablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addresstablemodel.h
askpassphrasedialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
askpassphrasedialog.h
bantablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bantablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoin.cpp qt: Remove network detection based on address in BIP21 2022-03-10 12:56:19 +01:00
bitcoin.h qt: Override BitcoinApplication::event() to handle QEvent::Quit 2022-02-12 16:04:57 +02:00
bitcoin.qrc
bitcoin_locale.qrc qt: Pre-branch translation updates for 23.x 2022-02-28 16:59:56 +01:00
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoinamountfield.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoingui.cpp scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
bitcoingui.h qt, refactor: Drop BitcoinGUI::{send,receive}CoinsMenuAction members 2022-02-08 18:41:42 +02:00
bitcoinstrings.cpp qt: English (source) translations update 2022-02-24 12:40:00 +01:00
bitcoinunits.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoinunits.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
clientmodel.cpp Merge bitcoin/bitcoin#22834: net: respect -onlynet= when making outbound connections 2022-03-01 18:32:01 +01:00
clientmodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
coincontroldialog.cpp Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
coincontroldialog.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
coincontroltreewidget.cpp
coincontroltreewidget.h
createwalletdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
createwalletdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
csvmodelwriter.cpp
csvmodelwriter.h
editaddressdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
editaddressdialog.h
guiconstants.h qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
guiutil.cpp Merge bitcoin/bitcoin#24132: build: Bump minimum Qt version to 5.11.3 2022-03-07 14:53:23 +00:00
guiutil.h scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
initexecutor.cpp qt: Keep InitExecutor in main gui thread 2021-09-27 13:05:40 +01:00
initexecutor.h qt: Keep InitExecutor in main gui thread 2021-09-27 13:05:40 +01:00
intro.cpp User-facing content fixups from transifex translator feedback 2022-02-17 12:59:30 +01:00
intro.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
macdockiconhandler.h
macdockiconhandler.mm
macnotificationhandler.h
macnotificationhandler.mm
macos_appnap.h
macos_appnap.mm
main.cpp
Makefile
modaloverlay.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
modaloverlay.h
networkstyle.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
networkstyle.h
notificator.cpp
notificator.h
openuridialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
openuridialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
optionsdialog.cpp Merge bitcoin/bitcoin#22834: net: respect -onlynet= when making outbound connections 2022-03-01 18:32:01 +01:00
optionsdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
optionsmodel.cpp scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
optionsmodel.h Merge bitcoin-core/gui#441: Add Create Unsigned button to SendConfirmationDialog 2022-01-09 17:46:23 +02:00
overviewpage.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
overviewpage.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
paymentserver.cpp qt: Remove network detection based on address in BIP21 2022-03-10 12:56:19 +01:00
paymentserver.h
peertablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablesortproxy.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablesortproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
psbtoperationsdialog.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
psbtoperationsdialog.h
qrimagewidget.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qrimagewidget.h
qvalidatedlineedit.cpp Merge bitcoin-core/gui#404: Fix various edge case bugs in QValidatedLineEdit 2022-02-09 06:23:44 +02:00
qvalidatedlineedit.h Merge bitcoin-core/gui#404: Fix various edge case bugs in QValidatedLineEdit 2022-02-09 06:23:44 +02:00
qvaluecombobox.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qvaluecombobox.h
README.md
receivecoinsdialog.cpp Merge bitcoin-core/gui#516: Change 'Show' icon 2022-01-04 12:55:29 +02:00
receivecoinsdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.h
recentrequeststablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
recentrequeststablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpcconsole.cpp Merge bitcoin-core/gui#524: Replace int with std::chrono in for the timer->setInterval() argument 2022-02-04 12:39:07 +02:00
rpcconsole.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsdialog.cpp gui: restore Send for external signer 2022-03-16 10:28:39 +01:00
sendcoinsdialog.h gui: restore Send for external signer 2022-03-16 10:28:39 +01:00
sendcoinsentry.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsentry.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsrecipient.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
signverifymessagedialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
signverifymessagedialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
splashscreen.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
splashscreen.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
trafficgraphwidget.cpp qt,refactor: Use std::chrono in TrafficGraphWidget class 2022-01-18 20:03:50 +05:30
trafficgraphwidget.h qt,refactor: Use std::chrono in TrafficGraphWidget class 2022-01-18 20:03:50 +05:30
transactiondesc.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiondesc.h
transactiondescdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactiondescdialog.h
transactionfilterproxy.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionfilterproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionoverviewwidget.h
transactionrecord.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactionrecord.h qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiontablemodel.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiontablemodel.h
transactionview.cpp scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
transactionview.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
utilitydialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
utilitydialog.h
walletcontroller.cpp Merge bitcoin-core/gui#517: refactor, qt: Use std::chrono for parameters of QTimer methods 2022-01-12 14:59:24 +02:00
walletcontroller.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletframe.cpp scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
walletframe.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletmodel.cpp Merge bitcoin/bitcoin#23497: Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces 2022-01-11 11:11:00 +01:00
walletmodel.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
walletmodeltransaction.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletmodeltransaction.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletview.cpp scripted-diff: Rename ShowModalDialogAndDeleteOnClose 2022-02-12 23:00:45 +02:00
walletview.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
winshutdownmonitor.cpp
winshutdownmonitor.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00

README.md

This directory contains the source code for the Bitcoin Core graphical user interface (GUI). It uses the Qt cross-platform framework.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions: Unix, macOS, Windows, FreeBSD, NetBSD, OpenBSD

When following your systems build instructions, make sure to install the Qt dependencies.

To run:

./src/qt/bitcoin-qt

Files and Directories

forms/

  • A directory that contains Designer UI files. These files specify the characteristics of form elements in XML. Qt UI files can be edited with Qt Creator or using any text editor.

locale/

  • Contains translations. They are periodically updated and an effort is made to support as many languages as possible. The process of contributing translations is described in doc/translation_process.md.

res/

  • Contains graphical resources used to enhance the UI experience.

test/

  • Functional tests used to ensure proper functionality of the GUI. Significant changes to the GUI code normally require new or updated tests.

bitcoingui.(h/cpp)

  • Represents the main window of the Bitcoin UI.

*model.(h/cpp)

  • The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
  • ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

  • A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

  • Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

  • (Deprecated) Used to process BIP21 payment URI requests. Also handles URI-based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

  • Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc. handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc.
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines.

Note: Do not change local/bitcoin_en.ts. It is updated automatically.

Using Qt Creator as an IDE

Qt Creator is a powerful tool which packages a UI designer tool (Qt Designer) and a C++ IDE into one application. This is especially useful if you want to change the UI layout.

Download Qt Creator

On Unix and macOS, Qt Creator can be installed through your package manager. Alternatively, you can download a binary from the Qt Website.

Note: If installing from a binary grabbed from the Qt Website: During the installation process, uncheck everything except for Qt Creator.

macOS
brew install qt-creator
Ubuntu & Debian
sudo apt-get install qtcreator

Setup Qt Creator

  1. Make sure you've installed all dependencies specified in your systems build instructions
  2. Follow the compile instructions for your system, run ./configure with the --enable-debug flag
  3. Start Qt Creator. At the start page, do: New -> Import Project -> Import Existing Project
  4. Enter bitcoin-qt as the Project Name and enter the absolute path to src/qt as Location
  5. Check over the file selection, you may need to select the forms directory (necessary if you intend to edit *.ui files)
  6. Confirm the Summary page
  7. In the Projects tab, select Manage Kits...

macOS

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "Clang (x86 64bit in /usr/bin)"
  • Under Debuggers: select "LLDB" as debugger (you might need to set the path to your LLDB installation)

Ubuntu & Debian

Note: Some of these options may already be set

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "GCC (x86 64bit in /usr/bin)"
  • Under Debuggers: select "GDB" as debugger
  1. While in the Projects tab, ensure that you have the bitcoin-qt executable specified under Run
  • If the executable is not specified: click "Choose...", navigate to src/qt, and select bitcoin-qt
  1. You're all set! Start developing, building, and debugging the Bitcoin Core GUI