0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-09 15:37:00 -04:00
bitcoin-core/src/test
Ava Chow bef99176e6
Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections
0a533613fb docs: add release notes for #27114 (brunoerg)
e6b8f19de9 test: add coverage for whitelisting manual connections (brunoerg)
c985eb854c test: add option to speed up tx relay/mempool sync (brunoerg)
66bc6e2d17 Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections (Luke Dashjr)
8e06be347c net_processing: Move extra service flag into InitializeNode (Luke Dashjr)
9133fd69a5 net: Move `NetPermissionFlags::Implicit` verification to `AddWhitelistPermissionFlags` (Luke Dashjr)
2863d7dddb net: store `-whitelist{force}relay` values in `CConnman` (brunoerg)

Pull request description:

  Revives #17167. It allows whitelisting manual connections. Fixes #9923

  Since there are some PRs/issues around this topic, I'll list some motivations/comments for whitelisting outbound connections from them:
  - Speed-up tx relay/mempool sync for testing purposes (my personal motivation for this) - In #26970, theStack pointed out that we whitelist peers to speed up tx relay for fast mempool synchronization, however, since it applies only for inbound connections and considering the topology `node0 <--- node1 <---- node2 <--- ... <-- nodeN`,  if a tx is submitted from any node other than node0, the mempool synchronization can take quite long.
  - https://github.com/bitcoin/bitcoin/pull/29058#issuecomment-1865155764 - "Before enabling -v2transport by default (which I'd image may happen after https://github.com/bitcoin/bitcoin/pull/24748) we could consider a way to force manual connections to be only-v1 or even only-v2 (disabling reconnect-with-v1). A possibility could be through a net permission flag, if https://github.com/bitcoin/bitcoin/pull/27114 makes it in."
  - https://github.com/bitcoin/bitcoin/pull/17167#issuecomment-1168606032 - "This would allow us to use https://github.com/bitcoin/bitcoin/pull/25355 when making outgoing connections to all nodes, except to whitelisted ones for which we would use our persistent I2P address."
  - Force-relay/mempool permissions for a node you intentionally connected to.

ACKs for top commit:
  achow101:
    ACK 0a533613fb
  sr-gi:
    re-ACK [0a53361](0a533613fb)
  pinheadmz:
    ACK 0a533613fb

Tree-SHA512: 97a79bb854110da04540897d2619eda409d829016aafdf1825ab5515334b0b42ef82f33cd41587af235b3af6ddcec3f2905ca038b5ab22e4c8a03d34f27aebe1
2024-03-12 12:59:02 -04:00
..
data Add test for negative transaction version w/ CSV to tx_valid.json 2024-01-11 15:05:01 -06:00
fuzz Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections 2024-03-12 12:59:02 -04:00
util Merge bitcoin/bitcoin#26564: test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-11 07:03:02 -04:00
.gitignore test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
addrman_tests.cpp doc, test: Test and explain service flag handling 2024-01-15 16:19:53 -05:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp refactor: Remove unused C-style casts 2023-07-24 15:32:00 +02:00
arith_uint256_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp refactor: rpc: Pass CBlockIndex by reference instead of pointer 2023-12-07 12:05:21 +01:00
blockencodings_tests.cpp scripted-diff: Use DataStream in most places 2023-11-28 12:42:37 +01:00
blockfilter_index_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
blockfilter_tests.cpp Remove unused includes from blockfilter.h 2023-08-17 18:28:15 +02:00
blockmanager_tests.cpp refactor: Remove calls to StartShutdown from KernelNotifications 2023-12-04 15:39:15 -04:00
bloom_tests.cpp Remove unused CDataStream 2023-11-30 11:27:54 +01:00
bswap_tests.cpp serialization: detect byteswap builtins without autoconf tests 2024-02-28 13:42:38 +00:00
checkqueue_tests.cpp refactor: Make CCheckQueue constructor start worker threads 2023-10-03 10:52:15 +01:00
coins_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
coinstatsindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
compilerbug_tests.cpp
compress_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
crypto_tests.cpp crypto: replace CountBits with std::bit_width 2024-02-26 16:13:12 +00:00
cuckoocache_tests.cpp
dbwrapper_tests.cpp
denialofservice_tests.cpp scripted-diff: Rename connection limit variables 2023-10-03 13:55:57 -04:00
descriptor_tests.cpp wallet: fix key parsing check for miniscript expressions in ParseScript 2023-12-08 06:54:00 -03:00
disconnected_transactions.cpp [test] DisconnectedBlockTransactions::DynamicMemoryUsage 2023-10-19 16:14:36 +01:00
flatfile_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp scripted-diff: move settings to common namespace 2023-05-30 17:26:51 +02:00
hash_tests.cpp Drop CHashWriter 2023-11-14 08:45:32 +10:00
headers_sync_chainwork_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from SAM proxy 2023-10-30 14:44:40 +01:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
ipc_test.capnp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.cpp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.h multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_tests.cpp test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Unit test for ellswift creation/decoding roundtrip 2023-06-23 14:22:39 -04:00
logging_tests.cpp logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace 2023-12-20 15:59:48 +10:00
main.cpp test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-07 10:11:45 -07:00
Makefile
mempool_tests.cpp [refactor] remove access to mapTx.find in mempool_tests.cpp 2023-11-10 16:44:35 +01:00
merkle_tests.cpp
merkleblock_tests.cpp refactor: Use Txid in CMerkleBlock 2023-11-28 17:49:41 +01:00
miner_tests.cpp refactor: Fix timedata includes 2024-02-01 13:52:05 +01:00
miniminer_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniscript_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
minisketch_tests.cpp
multisig_tests.cpp
net_peer_connection_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
net_peer_eviction_tests.cpp
net_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
netbase_tests.cpp Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections 2024-02-28 10:05:56 -03:00
orphanage_tests.cpp fuzz: Improve fuzzing stability for txorphan harness 2023-12-08 13:14:46 +00:00
peerman_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
pmt_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
policy_fee_tests.cpp [net processing] FeeFilterRounder doesn't own a FastRandomContext 2023-10-04 13:16:52 +01:00
policyestimator_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
pool_tests.cpp pool: change memusage_test to use int64_t, add allocation check 2023-11-20 17:10:34 +01:00
pow_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
prevector_tests.cpp
raii_event_tests.cpp
random_tests.cpp test: move remaining random test util code from setup_common to random 2023-06-14 08:28:33 -06:00
rbf_tests.cpp [refactor] change Workspace::m_conflicts and adjacent funcs/structs to use Txid 2024-01-16 14:20:33 +00:00
README.md Merge bitcoin/bitcoin#26564: test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-11 07:03:02 -04:00
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
sanity_tests.cpp
scheduler_tests.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
script_p2sh_tests.cpp tests: test both settings for permitbaremultisig in p2sh tests 2023-12-15 18:37:24 +10:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
script_tests.cpp scripted-diff: Fix bitcoin_config_h includes 2024-02-13 20:10:44 +00:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp
serialize_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
settings_tests.cpp init: improve corrupted/empty settings file error msg 2024-01-22 10:50:03 -03:00
sighash_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
sigopcount_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
skiplist_tests.cpp
sock_tests.cpp test: improve sock_tests/move_assignment 2023-08-28 14:32:17 +02:00
span_tests.cpp Fix CI-detected codespell warnings 2024-02-23 23:01:07 +01:00
streams_tests.cpp test: Drop x modifier in fsbridge::fopen call for mingw builds 2024-02-26 14:47:31 +00:00
sync_tests.cpp
system_tests.cpp test: Remove Windows-specific code from system_tests/run_command 2024-02-27 15:59:05 +00:00
timedata_tests.cpp
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning 2024-02-09 23:37:57 -05:00
translation_tests.cpp
txindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
txpackage_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
txreconciliation_tests.cpp
txrequest_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
txvalidation_tests.cpp [unit test] sibling not returned from SingleV3Checks if 1p2c or 3gen 2024-03-01 15:23:04 +00:00
txvalidationcache_tests.cpp [refactor] Add missing includes for next commit 2023-09-12 22:51:42 +02:00
uint256_tests.cpp Merge bitcoin/bitcoin#28924: refactor: Remove unused and fragile string interface from arith_uint256 2023-12-07 16:02:05 +00:00
util_tests.cpp Merge bitcoin/bitcoin#28075: util: Remove DirIsWritable, GetUniquePath 2023-12-13 10:06:16 +00:00
util_threadnames_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
validation_block_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
validation_chainstate_tests.cpp Tighten requirements for adding elements to setBlockIndexCandidates 2023-07-24 16:23:38 -04:00
validation_chainstatemanager_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
validation_flush_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
validation_tests.cpp test: removes unnecessary check from validation_tests 2024-02-29 09:54:47 -05:00
validationinterface_tests.cpp scripted-diff: Rename MainSignals to ValidationSignals 2024-02-15 14:45:51 +01:00
versionbits_tests.cpp doc: fix typos 2023-11-07 10:21:51 +09:00
xoroshiro128plusplus_tests.cpp

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check, which includes unit tests from subtrees, or make && make -C src check-unit for just the unit tests.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example.

test_bitcoin also accepts some of the command line arguments accepted by bitcoind. Use -- to separate these sets of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes sends debug logging, which normally goes only to debug.log within the data directory, also to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

test_bitcoin creates a temporary working (data) directory with a randomly generated pathname within test_common_Bitcoin Core/, which in turn is within the system's temporary directory (see temp_directory_path). This data directory looks like a simplified form of the standard bitcoind data directory. Its content will vary depending on the test, but it will always have a debug.log file, for example.

The location of the temporary data directory can be specified with the -testdatadir option. This can make debugging easier. The directory path used is the argument path appended with /test_common_Bitcoin Core/<test-name>/datadir. The directory path is created if necessary. Specifying this argument also causes the data directory not to be removed after the last test. This is useful for looking at what the test wrote to debug.log after it completes, for example. (The directory is removed at the start of the next test run, so no leftover state is used.)

$ test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir
Running 1 test case...

*** No errors detected
$ ls -l '/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir'
total 8
drwxrwxr-x 2 admin admin 4096 Nov 27 22:45 blocks
-rw-rw-r-- 1 admin admin 1003 Nov 27 22:45 debug.log

If you run an entire test suite, such as --run_test=getarg_tests, or all the test suites (by not specifying --run_test), a separate directory will be created for each individual test.

Run test_bitcoin --help for the full list of tests.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred