0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-08 14:34:53 -05:00
bitcoin-core/src
MarcoFalke d52bfc4916
Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal overlay is shown
d0cc1f6df7 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd2083d qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes #22.

  ---

  On master (ca055885c6):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6df7.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6df7 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
2020-07-13 10:34:27 +02:00
..
bench
compat
config
consensus
crc32c
crypto
index
interfaces wallet: Pass unused args to StartWallets 2020-07-09 13:07:37 +02:00
leveldb
logging
node Merge #19328: Add gettxoutsetinfo hash_type option 2020-07-06 08:06:40 -04:00
policy
primitives
qt Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal overlay is shown 2020-07-13 10:34:27 +02:00
rpc Merge #19474: doc: Use precise permission flags where possible 2020-07-11 10:23:09 +02:00
script script: Fix boost/C++17 compile failure 2020-07-01 17:24:46 -04:00
secp256k1
support
test wallet: Fix typo in comments; Simplify assert 2020-07-11 14:24:36 +02:00
univalue
util Merge #18638: net: Use mockable time for ping/pong, add tests 2020-07-10 16:06:28 +02:00
wallet Merge #18202: refactor: consolidate sendmany and sendtoaddress code 2020-07-12 14:42:35 +12:00
zmq
.clang-format tools: clang-format 6 compatibility 2020-07-06 03:52:37 +02:00
addrdb.cpp
addrdb.h Clean up separated ban/discourage interface 2020-07-03 20:43:55 -07:00
addrman.cpp
addrman.h
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp banlist: log post-swept banlist size at startup 2020-07-08 21:44:45 +08:00
banman.h Clean up separated ban/discourage interface 2020-07-03 20:43:55 -07:00
base58.cpp
base58.h
bech32.cpp
bech32.h
bitcoin-cli-res.rc
bitcoin-cli.cpp cli: reduce DefaultRequestHandler memory allocations 2020-07-05 16:39:17 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp
bitcoin-wallet-res.rc
bitcoin-wallet.cpp
bitcoind-res.rc
bitcoind.cpp
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp
bloom.h
chain.cpp
chain.h
chainparams.cpp
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp
coins.h
compat.h
compressor.cpp
compressor.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp
cuckoocache.h
dbwrapper.cpp
dbwrapper.h Drop unused CDBWrapper methods 2020-07-08 14:26:14 +03:00
dummywallet.cpp
flatfile.cpp
flatfile.h
fs.cpp
fs.h
hash.cpp
hash.h
httprpc.cpp
httprpc.h
httpserver.cpp
httpserver.h
indirectmap.h
init.cpp doc: Use precise permission flags where possible 2020-07-10 15:37:42 +02:00
init.h
key.cpp
key.h
key_io.cpp
key_io.h
limitedmap.h
logging.cpp
logging.h
Makefile.am
Makefile.bench.include
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt.include
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include tests: Add fuzzing harness for BanMan 2020-07-08 05:31:43 +00:00
Makefile.test_fuzz.include
Makefile.test_util.include
memusage.h
merkleblock.cpp
merkleblock.h
miner.cpp
miner.h
net.cpp Merge #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater 2020-07-10 19:16:48 +02:00
net.h Merge #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater 2020-07-10 19:16:48 +02:00
net_permissions.cpp net: Extract download permission from noban 2020-07-09 12:48:05 +02:00
net_permissions.h net: Extract download permission from noban 2020-07-09 12:48:05 +02:00
net_processing.cpp Merge #19474: doc: Use precise permission flags where possible 2020-07-11 10:23:09 +02:00
net_processing.h Clean up separated ban/discourage interface 2020-07-03 20:43:55 -07:00
net_types.h
netaddress.cpp
netaddress.h Merge #19314: refactor: Use uint16_t instead of unsigned short 2020-07-09 16:56:05 +02:00
netbase.cpp
netbase.h
netmessagemaker.h
noui.cpp
noui.h
optional.h
outputtype.cpp Enable Wswitch for OutputType 2020-07-01 18:03:12 -04:00
outputtype.h Remove confusing OutputType::CHANGE_AUTO 2020-07-01 18:02:38 -04:00
pow.cpp
pow.h
prevector.h
protocol.cpp
protocol.h [protocol] Remove unused CADDR_TIME_VERSION 2020-07-10 22:14:18 +01:00
psbt.cpp
psbt.h
pubkey.cpp
pubkey.h
random.cpp
random.h
randomenv.cpp
randomenv.h
rest.cpp
reverse_iterator.h
scheduler.cpp
scheduler.h
serialize.h
shutdown.cpp
shutdown.h
span.h
streams.h
sync.cpp
sync.h
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
tinyformat.h
torcontrol.cpp
torcontrol.h
txdb.cpp
txdb.h
txmempool.cpp
txmempool.h
uint256.cpp
uint256.h
undo.h
validation.cpp Merge #19317: Add a left-justified width field to log2_work component for a uniform debug.log output 2020-07-09 16:03:27 +02:00
validation.h doc: Use precise permission flags where possible 2020-07-10 15:37:42 +02:00
validationinterface.cpp
validationinterface.h
version.h [protocol] Remove unused GETHEADERS_VERSION 2020-07-10 22:14:18 +01:00
versionbits.cpp
versionbits.h
versionbitsinfo.cpp
versionbitsinfo.h
walletinitinterface.h
warnings.cpp
warnings.h