mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-11 15:56:58 -04:00
66b08e7822
eefe56967bbugfix: Fix incorrect debug.log config file path (Ryan Ofsky)3746f00be1init: Error if ignored bitcoin.conf file is found (Ryan Ofsky)398c3719b0lint: Fix lint-format-strings false positives when format specifiers have argument positions (Ryan Ofsky) Pull request description: Show an error on startup if a bitcoin datadir that is being used contains a `bitcoin.conf` file that is ignored. There are two cases where this could happen: - One case reported in [#27246 (comment)](https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470006043) happens when a `bitcoin.conf` file in the default datadir (e.g. `$HOME/.bitcoin/bitcoin.conf`) has a `datadir=/path` line that sets different datadir containing a second `bitcoin.conf` file. Currently the second `bitcoin.conf` file is ignored with no warning. - Another way this could happen is if a `-conf=` command line argument points to a configuration file with a `datadir=/path` line and that path contains a `bitcoin.conf` file, which is currently ignored. This change only adds an error message and doesn't change anything about way settings are applied. It also doesn't trigger errors if there are redundant `-datadir` or `-conf` settings pointing at the same configuration file, only if they are pointing at different files and one file is being ignored. ACKs for top commit: pinheadmz: re-ACKeefe56967bwillcl-ark: re-ACKeefe56967bTheCharlatan: ACKeefe56967bTree-SHA512: 939a98a4b271b5263d64a2df3054c56fcde94784edf6f010d78693a371c38aa03138ae9cebb026b6164bbd898d8fd0845a61a454fd996e328fd7bcf51c580c2b
118 lines
3.6 KiB
C++
118 lines
3.6 KiB
C++
// Copyright (c) 2009-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#if defined(HAVE_CONFIG_H)
|
|
#include <config/bitcoin-config.h>
|
|
#endif
|
|
|
|
#include <interfaces/init.h>
|
|
#include <interfaces/node.h>
|
|
#include <qt/bitcoin.h>
|
|
#include <qt/test/apptests.h>
|
|
#include <qt/test/optiontests.h>
|
|
#include <qt/test/rpcnestedtests.h>
|
|
#include <qt/test/uritests.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <util/chaintype.h>
|
|
|
|
#ifdef ENABLE_WALLET
|
|
#include <qt/test/addressbooktests.h>
|
|
#include <qt/test/wallettests.h>
|
|
#endif // ENABLE_WALLET
|
|
|
|
#include <QApplication>
|
|
#include <QDebug>
|
|
#include <QObject>
|
|
#include <QTest>
|
|
|
|
#include <functional>
|
|
|
|
#if defined(QT_STATICPLUGIN)
|
|
#include <QtPlugin>
|
|
#if defined(QT_QPA_PLATFORM_MINIMAL)
|
|
Q_IMPORT_PLUGIN(QMinimalIntegrationPlugin);
|
|
#endif
|
|
#if defined(QT_QPA_PLATFORM_XCB)
|
|
Q_IMPORT_PLUGIN(QXcbIntegrationPlugin);
|
|
#elif defined(QT_QPA_PLATFORM_WINDOWS)
|
|
Q_IMPORT_PLUGIN(QWindowsIntegrationPlugin);
|
|
#elif defined(QT_QPA_PLATFORM_COCOA)
|
|
Q_IMPORT_PLUGIN(QCocoaIntegrationPlugin);
|
|
#elif defined(QT_QPA_PLATFORM_ANDROID)
|
|
Q_IMPORT_PLUGIN(QAndroidPlatformIntegrationPlugin)
|
|
#endif
|
|
#endif
|
|
|
|
const std::function<void(const std::string&)> G_TEST_LOG_FUN{};
|
|
|
|
const std::function<std::vector<const char*>()> G_TEST_COMMAND_LINE_ARGUMENTS{};
|
|
|
|
// This is all you need to run all the tests
|
|
int main(int argc, char* argv[])
|
|
{
|
|
// Initialize persistent globals with the testing setup state for sanity.
|
|
// E.g. -datadir in gArgs is set to a temp directory dummy value (instead
|
|
// of defaulting to the default datadir), or globalChainParams is set to
|
|
// regtest params.
|
|
//
|
|
// All tests must use their own testing setup (if needed).
|
|
fs::create_directories([] {
|
|
BasicTestingSetup dummy{ChainType::REGTEST};
|
|
return gArgs.GetDataDirNet() / "blocks";
|
|
}());
|
|
|
|
std::unique_ptr<interfaces::Init> init = interfaces::MakeGuiInit(argc, argv);
|
|
gArgs.ForceSetArg("-listen", "0");
|
|
gArgs.ForceSetArg("-listenonion", "0");
|
|
gArgs.ForceSetArg("-discover", "0");
|
|
gArgs.ForceSetArg("-dnsseed", "0");
|
|
gArgs.ForceSetArg("-fixedseeds", "0");
|
|
gArgs.ForceSetArg("-upnp", "0");
|
|
gArgs.ForceSetArg("-natpmp", "0");
|
|
|
|
std::string error;
|
|
if (!gArgs.ReadConfigFiles(error, true)) QWARN(error.c_str());
|
|
|
|
// Prefer the "minimal" platform for the test instead of the normal default
|
|
// platform ("xcb", "windows", or "cocoa") so tests can't unintentionally
|
|
// interfere with any background GUIs and don't require extra resources.
|
|
#if defined(WIN32)
|
|
if (getenv("QT_QPA_PLATFORM") == nullptr) _putenv_s("QT_QPA_PLATFORM", "minimal");
|
|
#else
|
|
setenv("QT_QPA_PLATFORM", "minimal", 0 /* overwrite */);
|
|
#endif
|
|
|
|
BitcoinApplication app;
|
|
app.setApplicationName("Bitcoin-Qt-test");
|
|
app.createNode(*init);
|
|
|
|
int num_test_failures{0};
|
|
|
|
AppTests app_tests(app);
|
|
num_test_failures += QTest::qExec(&app_tests);
|
|
|
|
OptionTests options_tests(app.node());
|
|
num_test_failures += QTest::qExec(&options_tests);
|
|
|
|
URITests test1;
|
|
num_test_failures += QTest::qExec(&test1);
|
|
|
|
RPCNestedTests test3(app.node());
|
|
num_test_failures += QTest::qExec(&test3);
|
|
|
|
#ifdef ENABLE_WALLET
|
|
WalletTests test5(app.node());
|
|
num_test_failures += QTest::qExec(&test5);
|
|
|
|
AddressBookTests test6(app.node());
|
|
num_test_failures += QTest::qExec(&test6);
|
|
#endif
|
|
|
|
if (num_test_failures) {
|
|
qWarning("\nFailed tests: %d\n", num_test_failures);
|
|
} else {
|
|
qDebug("\nAll tests passed.\n");
|
|
}
|
|
return num_test_failures;
|
|
}
|