MacroFake da23320998 Merge bitcoin/bitcoin#25651: refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify ... 4bedfd702a refactor: remove unneeded temporaries in node/interfaces, simplify code (Jon Atack) b27ba169eb refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public (Jon Atack) Pull request description: - Make all `NodeImpl`, `ChainImpl` and `ExternalSignerImpl` class members `public` (and document why), to be consistent in all the `*Impl` classes in `src/node/interfaces.cpp` and `src/wallet/interfaces.cpp` and to help future reviewers and contributors. - Remove unneeded temporaries in `NodeImpl` and `ChainImpl` methods in `src/node/interfaces.cpp` and simplify, to make the code easier to read and understand and to improve performance by avoiding unnecessary move operations. ACKs for top commit: ryanofsky: Code review ACK 4bedfd702a. Changes since last review, applying suggested style & simplifiying first commit. Also avoiding another lock in second commit. Tree-SHA512: 112f7cad5e2838c94c5b79d61328f42fe75fdb97f401ab49eccf696fc2c6a8a0c0ee55ec974c0602acf7423f78bb82e90eb8a0cc531e1d3347f73b7c83685504		2022-08-01 11:19:55 +02:00
..
bench	Merge bitcoin/bitcoin#24584: wallet: avoid mixing different OutputTypes during coin selection	2022-07-28 18:16:51 -04:00
common
compat	compat: document redefining ssize_t when using MSVC	2022-07-20 13:10:12 +01:00
config
consensus
crc32c
crypto	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
index	Merge bitcoin/bitcoin#22485: doc: BaseIndex sync behavior with empty datadir	2022-07-21 19:54:18 +02:00
init
interfaces	Merge bitcoin/bitcoin#23997: wallet: avoid rescans under assumed-valid blocks	2022-07-18 14:39:55 -04:00
ipc
kernel	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
leveldb	Update leveldb-subtree subtree to latest upstream	2022-07-29 14:43:11 +01:00
logging
minisketch
node	Merge bitcoin/bitcoin#25651: refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify	2022-08-01 11:19:55 +02:00
policy
primitives	refactor: Make CTransaction constructor explicit	2022-07-25 12:16:54 +02:00
qt	Merge bitcoin-core/gui#629: Fix translator comment for Restore Wallet QInputDialog	2022-07-23 09:43:02 +01:00
rpc	Merge bitcoin/bitcoin#25610: wallet, rpc: Opt in to RBF by default	2022-08-01 10:53:11 +02:00
script	script: actually trigger the optimization in BuildScript	2022-07-26 13:02:48 +02:00
secp256k1
support
test	Merge bitcoin/bitcoin#25571: refactor: Make mapBlocksUnknownParent local, and rename it	2022-07-29 15:47:23 +01:00
univalue	Merge bitcoin/bitcoin#25611: univalue: Avoid brittle, narrowing and verbose integral type confusions	2022-07-25 15:12:41 +01:00
util	Merge bitcoin/bitcoin#24697: refactor address relay time	2022-07-27 10:30:32 +01:00
wallet	Merge bitcoin/bitcoin#25651: refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify	2022-08-01 11:19:55 +02:00
zmq
.bear-tidy-config
.clang-format
.clang-tidy	tidy: enable readability-redundant-string-init	2022-07-26 10:16:42 +01:00
addrdb.cpp
addrdb.h
addrman.cpp	refactor: Use type-safe std::chrono for addrman time	2022-07-26 11:06:10 +02:00
addrman.h	refactor: Use type-safe std::chrono for addrman time	2022-07-26 11:06:10 +02:00
addrman_impl.h	refactor: Use type-safe std::chrono for addrman time	2022-07-26 11:06:10 +02:00
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp
banman.h
base58.cpp
base58.h
bech32.cpp
bech32.h
bitcoin-chainstate.cpp	refactor: Reduce number of LoadChainstate return values	2022-07-19 15:54:52 -05:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
bitcoin-util-res.rc
bitcoin-util.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
bitcoind-res.rc
bitcoind.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp	refactor: remove unnecessary string initializations	2022-07-26 10:16:42 +01:00
blockfilter.h
chain.cpp	refactor: move CBlockIndex#ToString() from header to implementation	2022-07-22 12:47:13 +02:00
chain.h	refactor: move CBlockIndex#ToString() from header to implementation	2022-07-22 12:47:13 +02:00
chainparams.cpp	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp	tracing: do not use coin after move in CCoinsViewCache::AddCoin	2022-07-21 12:55:20 +03:00
coins.h
compressor.cpp
compressor.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp
cuckoocache.h
dbwrapper.cpp	Remove unused includes from dbwrapper.h	2022-07-19 14:32:53 +02:00
dbwrapper.h	Remove unused includes from dbwrapper.h	2022-07-19 14:32:53 +02:00
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp
external_signer.cpp	refactor: remove unnecessary string initializations	2022-07-26 10:16:42 +01:00
external_signer.h
flatfile.cpp
flatfile.h
fs.cpp
fs.h	Move FopenFn to fsbridge namespace	2022-07-15 12:25:51 -04:00
hash.cpp	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
hash.h	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
httprpc.cpp
httprpc.h
httpserver.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
httpserver.h
i2p.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
i2p.h	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
indirectmap.h
init.cpp	refactor: Reduce number of SanityChecks return values	2022-07-19 16:54:52 -04:00
init.h
key.cpp
key.h
key_io.cpp
key_io.h
logging.cpp
logging.h
Makefile.am	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
Makefile.bench.include
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include
Makefile.qt.include
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include	Merge bitcoin/bitcoin#24584: wallet: avoid mixing different OutputTypes during coin selection	2022-07-28 18:16:51 -04:00
Makefile.test_fuzz.include	test/fuzz: Invoke LoadMempool via CChainState	2022-07-15 12:26:00 -04:00
Makefile.test_util.include
Makefile.univalue.include
mapport.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
mapport.h
mempool_args.cpp
mempool_args.h
memusage.h
merkleblock.cpp
merkleblock.h
net.cpp	Merge bitcoin/bitcoin#24697: refactor address relay time	2022-07-27 10:30:32 +01:00
net.h	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
net_permissions.cpp
net_permissions.h
net_processing.cpp	Merge bitcoin/bitcoin#25683: refactor: log nEvicted message in LimitOrphans then return void	2022-07-29 16:17:16 +02:00
net_processing.h	[net processing] Remove CNode::nServices	2022-07-14 14:50:44 +02:00
net_types.cpp
net_types.h
netaddress.cpp
netaddress.h	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
netbase.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
netbase.h	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
netgroup.cpp
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp
protocol.h	refactor: Use type-safe std::chrono for addrman time	2022-07-26 11:06:10 +02:00
psbt.cpp
psbt.h	psbt: Fix unsigned integer overflow	2022-07-25 18:45:57 +02:00
pubkey.cpp	Use HashWriter where possible	2022-07-20 15:34:36 +02:00
pubkey.h
random.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
random.h
randomenv.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
randomenv.h
rest.cpp
rest.h
reverse_iterator.h
scheduler.cpp
scheduler.h
serialize.h	Add ChronoFormatter to serialize	2022-07-26 11:05:04 +02:00
shutdown.cpp
shutdown.h
signet.cpp
signet.h
span.h
streams.h
sync.cpp
sync.h
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h	Add type-safe AdjustedTime() getter to timedata	2022-07-26 11:05:54 +02:00
tinyformat.h
torcontrol.cpp	refactor: move compat.h into compat/	2022-07-20 10:34:46 +01:00
torcontrol.h
txdb.cpp	CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()	2022-07-22 12:45:07 +02:00
txdb.h	Add missing includes	2022-07-19 14:12:33 +02:00
txmempool.cpp	mempool: Improve comments for [GS]etLoadTried	2022-07-15 11:35:13 -04:00
txmempool.h	mempool: Improve comments for [GS]etLoadTried	2022-07-15 11:35:13 -04:00
txorphanage.cpp	refactor: log nEvicted message in LimitOrphans then return void	2022-07-28 14:39:45 +08:00
txorphanage.h	refactor: log nEvicted message in LimitOrphans then return void	2022-07-28 14:39:45 +08:00
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h
undo.h
validation.cpp	Merge bitcoin/bitcoin#25571: refactor: Make mapBlocksUnknownParent local, and rename it	2022-07-29 15:47:23 +01:00
validation.h	Merge bitcoin/bitcoin#25571: refactor: Make mapBlocksUnknownParent local, and rename it	2022-07-29 15:47:23 +01:00
validationinterface.cpp
validationinterface.h
version.h
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp
warnings.h