0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-09 15:37:00 -04:00
bitcoin-core/src/test
Andrew Chow f37bd15d47
Merge bitcoin/bitcoin#25685: wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection
3fcb545ab2 bench: benchmark transaction creation process (furszy)
a8a75346d7 wallet: SelectCoins, return early if target is covered by preset-inputs (furszy)
f41712a734 wallet: simplify preset inputs selection target check (furszy)
5baedc3351 wallet: remove fetch pre-selected-inputs responsibility from SelectCoins (furszy)
295852f619 wallet: encapsulate pre-selected-inputs lookup into its own function (furszy)
37e7887cb4 wallet: skip manually selected coins from 'AvailableCoins' result (furszy)
94c0766b0c wallet: skip available coins fetch if "other inputs" are disallowed (furszy)

Pull request description:

  #### # Context (Current Flow on Master)

  In the transaction creation process, in order to select which coins the new transaction will spend,
  we first obtain all the available coins known by the wallet, which means walking-through the
  wallet txes map, gathering the ones that fulfill certain spendability requirements in a vector.

  This coins vector is then provided to the Coin Selection process, which first checks if the user
  has manually selected any input (which could be internal, aka known by the wallet, or external),
  and if it does, it fetches them by searching each of them inside the wallet and/or inside the
  Coin Control external tx data.

  Then, after finding the pre-selected-inputs and gathering them in a vector, the Coin Selection
  process walks-through the entire available coins vector once more just to erase coins that are
  in both vectors. So the Coin Selection process doesn’t pick them twice (duplicate inputs inside
  the same transaction).

  #### # Process Workflow Changes

  Now, a new method, `FetchCoins` will be responsible for:
  1) Lookup the user pre-selected-inputs (which can be internal or external).
  2) And, fetch the available coins in the wallet (excluding the already fetched ones).

  Which will occur prior to the Coin Selection process. Which allows us to never include the
  pre-selected-inputs inside the available coins vector in the first place, as well as doing other
  nice improvements (written below).

  So, Coin Selection can perform its main responsibility without mixing it with having to fetch
  internal/external coins nor any slow and unneeded duplicate coins verification.

  #### # Summarizing the Improvements:

  1) If any pre-selected-input lookup fail, the process will return the error right away.
      (before, the wallet was fetching all the wallet available coins, walking through the
      entire txes map, and then failing for an invalid pre-selected-input inside SelectCoins)

  2) The pre-selected-inputs lookup failure causes are properly described on the return error.
      (before, we were returning an "Insufficient Funds" error for everything, even if the failure
      was due a not solvable external input)

  3) **Faster Coin Selection**: no longer need to "remove the pre-set inputs from the available coins
      vector so that Coin Selection doesn't pick them" (which meant to loop-over the entire
      available coins vector at Coin Selection time, erasing duplicate coins that were pre-selected).

      Now, the available coins vector, which is built after the pre-selected-inputs fetching,
      doesn’t include the already selected inputs in the first place.

  4) **Faster transaction creation** for transactions that only use manually selected inputs.

      We now will return early, as soon as we finish fetching the pre-selected-inputs and
      not perform the resources expensive calculation of walking-through the entire wallet
      txes map to obtain the available coins (coins that we will not use).

  ---------------------------

  Added a new bench (f6d0bb2) measuring the transaction creation process, for a wallet with ~250k UTXO, only using the pre-selected-inputs inside coin control. Setting `m_allow_other_inputs=false` to disallow the wallet to include coins automatically.

  #### Result on this PR (tip f6d0bb2d):

  |               ns/op |                op/s |    err% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------:|:----------
  |        1,048,675.00 |              953.58 |    0.3% |      0.06 | `WalletCreateTransaction`

  vs

  #### Result on master (tip 4a4289e2):

  |               ns/op |                op/s |    err% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------:|:----------
  |       96,373,458.20 |               10.38 |    0.2% |      5.30 | `WalletCreateTransaction`

  The benchmark took to run in master: **96.37 milliseconds**, while in this PR: **1 millisecond**  🚀 .

ACKs for top commit:
  S3RK:
    Code Review ACK 3fcb545ab2
  achow101:
    ACK 3fcb545ab2
  aureleoules:
    reACK 3fcb545ab2

Tree-SHA512: 42f833e92f40c348007ca565a4c98039e6f1ff25d8322bc2b27115824744779baf0b0a38452e4e2cdcba45076473f1028079bbd0f670020481ec5d3db42e4731
2022-10-27 17:48:58 -04:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
util Merge bitcoin/bitcoin#25685: wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection 2022-10-27 17:48:58 -04:00
addrman_tests.cpp addrman: Use system time instead of adjusted network time 2022-07-30 11:04:09 +02:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
arith_uint256_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
banman_tests.cpp test: Use proper Boost macros instead of assertions 2022-10-03 00:00:31 +01:00
base32_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
base58_tests.cpp refactor: Make const refs vars where applicable 2022-07-27 13:27:57 +02:00
base64_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp extended keys: fail to derive too large depth instead of wrapping around 2022-08-04 11:32:26 +02:00
blockchain_tests.cpp refactor: use <cstdlib> over stdlib.h 2022-09-23 10:48:47 +01:00
blockencodings_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
blockfilter_index_tests.cpp Require callers of AcceptBlockHeader() to perform anti-dos checks 2022-08-29 08:10:35 -04:00
blockfilter_tests.cpp refactor: Make const refs vars where applicable 2022-07-27 13:27:57 +02:00
blockmanager_tests.cpp reindex, log, test: fixes #21379 2022-05-07 07:11:29 -04:00
bloom_tests.cpp Use spans of std::byte in serialize 2022-01-02 11:40:31 +01:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
coins_tests.cpp refactor: Remove defunct attributes.h includes 2022-05-21 13:54:33 -05:00
coinstatsindex_tests.cpp test: silence TSAN false positive in coinstatsindex_initial_sync 2022-10-11 09:45:54 +02:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
denialofservice_tests.cpp net: drop cs_sendProcessing 2022-09-15 14:44:42 +10:00
descriptor_tests.cpp test: remove unused norm_prv parameter 2022-08-21 18:26:11 -03:00
flatfile_tests.cpp Use AutoFile where possible 2022-06-29 10:33:13 +02:00
fs_tests.cpp test: Correctly decode UTF-8 literal string paths 2022-03-03 14:12:07 -05:00
getarg_tests.cpp test: Remove boost::split from getarg_tests.cpp 2022-04-29 14:35:50 +02:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
headers_sync_chainwork_tests.cpp Add unit test for HeadersSyncState 2022-08-29 08:10:35 -04:00
httpserver_tests.cpp Add GetQueryParameter helper function 2022-03-10 12:01:54 +01:00
i2p_tests.cpp Merge bitcoin/bitcoin#25614: Severity-based logging, step 2 2022-09-01 15:57:56 -04:00
interfaces_tests.cpp refactor: Add lock annotations to Active* methods 2022-08-16 17:26:40 +02:00
key_io_tests.cpp refactor: Make const refs vars where applicable 2022-07-27 13:27:57 +02:00
key_tests.cpp refactor: use Span in random.* 2022-03-23 17:36:33 -05:00
logging_tests.cpp Create BCLog::Level::Trace log severity level 2022-08-20 11:55:17 +02:00
main.cpp build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
Makefile
mempool_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
merkle_tests.cpp
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
miniscript_tests.cpp Permit delaying duplicate key check in miniscript::Node construction 2022-09-17 10:47:05 +02:00
minisketch_tests.cpp test: Prevent UB in minisketch_tests.cpp 2022-10-06 12:50:54 +01:00
multisig_tests.cpp Pass datacarrier setting into IsStandard 2022-08-02 15:28:30 +02:00
net_peer_eviction_tests.cpp doc: Convert remaining comments to clang-tidy format 2022-04-06 15:37:07 +02:00
net_tests.cpp Merge bitcoin/bitcoin#26036: net: add NetEventsInterface::g_msgproc_mutex 2022-09-20 14:18:23 +01:00
netbase_tests.cpp Validate port value in SplitHostPort 2022-10-05 19:24:04 +02:00
orphanage_tests.cpp [tests] Move TxOrphange tests to orphange_tests.cpp 2022-04-25 08:37:01 +01:00
pmt_tests.cpp Remove not needed ArithToUint256 roundtrips in tests 2022-04-14 19:29:52 +02:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
pow_tests.cpp Add function to validate difficulty changes 2022-08-23 11:34:10 -04:00
prevector_tests.cpp test, bench: make prevector and checkqueue swap member functions noexcept 2022-04-28 20:34:43 +02:00
raii_event_tests.cpp refactor: use <cstdlib> over stdlib.h 2022-09-23 10:48:47 +01:00
random_tests.cpp refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) 2022-07-13 15:21:12 +02:00
rbf_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
result_tests.cpp refactor: Replace BResult with util::Result 2022-08-03 07:33:01 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp univalue: Remove unused and confusing set*() return value 2022-07-29 15:24:42 +02:00
sanity_tests.cpp compat: remove glibcxx sanity checks 2022-05-28 09:43:02 +01:00
scheduler_tests.cpp Switch scheduler to steady_clock 2022-05-10 10:54:54 +02:00
script_p2sh_tests.cpp test: Add missing static to IsStandardTx helper 2022-08-03 11:19:53 +02:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
script_tests.cpp refactor: Make const refs vars where applicable 2022-07-27 13:27:57 +02:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp test: Fix Wambiguous-reversed-operator compiler warnings 2022-02-21 16:36:59 +01:00
settings_tests.cpp settings: Add update/getPersistent/isIgnored methods 2022-05-19 11:32:56 -04:00
sighash_tests.cpp refactor: Make const refs vars where applicable 2022-07-27 13:27:57 +02:00
sigopcount_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
skiplist_tests.cpp Add functions to construct locators without CChain 2022-08-23 16:05:00 -04:00
sock_tests.cpp refactor: move compat.h into compat/ 2022-07-20 10:34:46 +01:00
streams_tests.cpp test: Create fresh CDataStream each time 2022-02-03 20:16:41 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
system_tests.cpp refactor: move run_command from util to common 2022-10-04 21:21:05 +00:00
timedata_tests.cpp timedata: make it possible to reset the state 2022-03-02 15:40:30 +01:00
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks 2022-08-19 17:11:06 +02:00
txindex_tests.cpp test: move SyncWithValidationInterfaceQueue() before Stop() in txindex_tests 2022-10-11 09:45:55 +02:00
txpackage_tests.cpp refactor: fixup named args in txpackage tests 2022-04-07 12:50:54 +01:00
txreconciliation_tests.cpp test: Add unit tests for reconciliation negotiation 2022-10-17 12:35:44 +03:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp tests: Reduce calls to InitS*Cache() 2022-08-03 12:02:31 -04:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp Require callers of AcceptBlockHeader() to perform anti-dos checks 2022-08-29 08:10:35 -04:00
validation_chainstate_tests.cpp test: add reset_chainstate parameter for snapshot unittests 2022-09-13 13:31:21 -04:00
validation_chainstatemanager_tests.cpp Merge bitcoin/bitcoin#25667: assumeutxo: snapshot initialization 2022-10-13 10:19:27 -04:00
validation_flush_tests.cpp scripted-diff: rename CChainState -> Chainstate 2022-09-09 11:47:27 -04:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp Merge bitcoin/bitcoin#25200: doc: Fix spelling errors identified by codespell in comments 2022-05-31 15:19:59 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred