0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-11 15:56:58 -04:00
bitcoin-core/test/functional
glozow 82ba505134
Merge bitcoin/bitcoin#31759: test: fixes p2p_ibd_txrelay wait time
1973a9e4f1 test: fixes p2p_ibd_txrelay wait time (Sergi Delgado Segura)

Pull request description:

  `p2p_ibd_txrelay` expects no GETDATA to have been received by a peer after announcing a transaction. The reason is that the node is doing IBD, so transaction requests are not replied to. However, the way this is checked is wrong, and the check will pass even if the node **was not** in IBD.

  This is due to the mocktime not being properly initialized, so the check is always performed earlier than it should, making it impossible for the request to be there.

  This can be checked by modifying the test so the peer **is not doing IBD**, and checking how the test succeeds on that assert (even though it fails later on, given the nature of the test):

  ```diff
  index 882f5b5c13..3a69ae5860 100755
  --- a/test/functional/p2p_ibd_txrelay.py
  +++ b/test/functional/p2p_ibd_txrelay.py
  @@ -34,7 +34,7 @@ NORMAL_FEE_FILTER = Decimal(100) / COIN

   class P2PIBDTxRelayTest(BitcoinTestFramework):
       def set_test_params(self):
  -        self.setup_clean_chain = True
  +        # self.setup_clean_chain = True
           self.num_nodes = 2
           self.extra_args = [
               ["-minrelaytxfee={}".format(NORMAL_FEE_FILTER)],
  @@ -43,9 +43,11 @@ class P2PIBDTxRelayTest(BitcoinTestFramework):

       def run_test(self):
           self.log.info("Check that nodes set minfilter to MAX_MONEY while still in IBD")
  -        for node in self.nodes:
  -            assert node.getblockchaininfo()['initialblockdownload']
  -            self.wait_until(lambda: all(peer['minfeefilter'] == MAX_FEE_FILTER for peer in node.getpeerinfo()))
  +        # for node in self.nodes:
  +        #     assert node.getblockchaininfo()['initialblockdownload']
  +        #     self.wait_until(lambda: all(peer['minfeefilter'] == MAX_FEE_FILTER for peer in node.getpeerinfo()))
  ```

ACKs for top commit:
  i-am-yuvi:
    ACK 1973a9e4f1
  glozow:
    ACK 1973a9e4f1

Tree-SHA512: c4b3afe9927c5480671ebf5c1f6ee5fc7e3aeefeb13c210fa83587a6c126e1a8e40ad8e46587537d0f4bf06a36bbf2310ca065d685d4d9286e5a446b8d5b2235
2025-02-06 00:57:29 -05:00
..
data
mocks
test_framework Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response 2025-02-05 13:30:51 +00:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py
feature_abortnode.py
feature_addrman.py
feature_anchors.py
feature_asmap.py
feature_assumeutxo.py
feature_assumevalid.py
feature_bind_extra.py
feature_bind_port_discover.py
feature_bind_port_externalip.py
feature_bip68_sequence.py
feature_block.py
feature_blocksdir.py
feature_blocksxor.py
feature_cltv.py
feature_coinstatsindex.py
feature_config_args.py
feature_csv_activation.py
feature_dbcrash.py
feature_dersig.py
feature_dirsymlinks.py
feature_discover.py
feature_fastprune.py
feature_fee_estimation.py
feature_filelock.py
feature_framework_miniwallet.py Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response 2025-02-05 13:30:51 +00:00
feature_framework_unit_tests.py
feature_help.py
feature_includeconf.py
feature_index_prune.py
feature_init.py
feature_loadblock.py
feature_logging.py
feature_maxtipage.py
feature_maxuploadtarget.py
feature_minchainwork.py test: Introduce ensure_for helper 2024-11-13 12:00:16 +01:00
feature_notifications.py
feature_nulldummy.py
feature_port.py
feature_posix_fs_permissions.py
feature_presegwit_node_upgrade.py
feature_proxy.py
feature_pruning.py
feature_rbf.py
feature_reindex.py
feature_reindex_readonly.py
feature_remove_pruned_files_on_startup.py
feature_segwit.py
feature_settings.py
feature_shutdown.py
feature_signet.py
feature_startupnotify.py
feature_taproot.py
feature_uacomment.py
feature_unsupported_utxo_db.py
feature_utxo_set_hash.py
feature_versionbits_warning.py
interface_bitcoin_cli.py
interface_http.py
interface_rest.py
interface_rpc.py
interface_usdt_coinselection.py
interface_usdt_mempool.py
interface_usdt_net.py tracing: connection closed tracepoint 2025-02-04 10:25:33 +01:00
interface_usdt_utxocache.py
interface_usdt_validation.py
interface_zmq.py
mempool_accept.py
mempool_accept_wtxid.py
mempool_compatibility.py
mempool_datacarrier.py
mempool_dust.py
mempool_ephemeral_dust.py
mempool_expiry.py
mempool_limit.py
mempool_package_limits.py
mempool_package_onemore.py
mempool_package_rbf.py
mempool_packages.py
mempool_persist.py
mempool_reorg.py
mempool_resurrect.py
mempool_sigoplimit.py
mempool_spend_coinbase.py
mempool_truc.py
mempool_unbroadcast.py
mempool_updatefromblock.py
mining_basic.py rpc: have mintime account for timewarp rule 2025-01-29 09:39:32 +01:00
mining_getblocktemplate_longpoll.py
mining_mainnet.py
mining_prioritisetransaction.py
p2p_1p1c_network.py test: fix intermittent timeout in p2p_1p1c_network.py 2025-01-29 10:46:55 -05:00
p2p_add_connections.py
p2p_addr_relay.py
p2p_addrfetch.py
p2p_addrv2_relay.py
p2p_block_sync.py
p2p_blockfilters.py
p2p_blocksonly.py
p2p_compactblocks.py
p2p_compactblocks_blocksonly.py
p2p_compactblocks_hb.py
p2p_disconnect_ban.py
p2p_dns_seeds.py
p2p_dos_header_tree.py
p2p_eviction.py
p2p_feefilter.py
p2p_filter.py
p2p_fingerprint.py
p2p_getaddr_caching.py
p2p_getdata.py
p2p_handshake.py
p2p_headers_sync_with_minchainwork.py
p2p_i2p_ports.py
p2p_i2p_sessions.py
p2p_ibd_stalling.py
p2p_ibd_txrelay.py test: fixes p2p_ibd_txrelay wait time 2025-01-29 14:24:29 -05:00
p2p_initial_headers_sync.py
p2p_invalid_block.py
p2p_invalid_locator.py
p2p_invalid_messages.py
p2p_invalid_tx.py
p2p_leak.py
p2p_leak_tx.py
p2p_message_capture.py
p2p_mutated_blocks.py
p2p_net_deadlock.py
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py
p2p_opportunistic_1p1c.py
p2p_orphan_handling.py Merge bitcoin/bitcoin#31760: test: make sure we are on sync with a peer before checking if they have sent a message 2025-02-06 00:02:00 -05:00
p2p_outbound_eviction.py
p2p_permissions.py
p2p_ping.py
p2p_seednode.py
p2p_segwit.py
p2p_sendheaders.py
p2p_sendtxrcncl.py
p2p_timeouts.py
p2p_tx_download.py Merge bitcoin/bitcoin#31437: func test: Expand tx download preference tests 2025-02-05 13:21:58 +00:00
p2p_tx_privacy.py
p2p_unrequested_blocks.py
p2p_v2_encrypted.py
p2p_v2_misbehaving.py
p2p_v2_transport.py
README.md
rpc_bind.py
rpc_blockchain.py Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response 2025-02-05 13:30:51 +00:00
rpc_createmultisig.py
rpc_decodescript.py
rpc_deprecated.py
rpc_deriveaddresses.py
rpc_dumptxoutset.py
rpc_estimatefee.py
rpc_generate.py
rpc_getblockfilter.py
rpc_getblockfrompeer.py
rpc_getblockstats.py
rpc_getchaintips.py
rpc_getdescriptoractivity.py
rpc_getdescriptorinfo.py
rpc_help.py
rpc_invalid_address_message.py
rpc_invalidateblock.py
rpc_mempool_info.py
rpc_misc.py
rpc_named_arguments.py
rpc_net.py
rpc_orphans.py
rpc_packages.py
rpc_preciousblock.py
rpc_psbt.py
rpc_rawtransaction.py
rpc_scanblocks.py
rpc_scantxoutset.py
rpc_setban.py
rpc_signer.py
rpc_signmessagewithprivkey.py
rpc_signrawtransactionwithkey.py
rpc_txoutproof.py
rpc_uptime.py
rpc_users.py
rpc_validateaddress.py
rpc_whitelist.py
test-shell.md
test_runner.py
tool_signet_miner.py
tool_wallet.py Merge bitcoin/bitcoin#30125: test: improve BDB parser (handle internal/overflow pages, support all page sizes) 2025-01-29 15:56:36 -05:00
wallet_abandonconflict.py
wallet_address_types.py
wallet_assumeutxo.py
wallet_avoid_mixing_output_types.py
wallet_avoidreuse.py
wallet_backup.py
wallet_backwards_compatibility.py
wallet_balance.py
wallet_basic.py
wallet_blank.py
wallet_bumpfee.py
wallet_change_address.py
wallet_coinbase_category.py
wallet_conflicts.py
wallet_create_tx.py
wallet_createwallet.py
wallet_createwalletdescriptor.py
wallet_crosschain.py
wallet_descriptor.py
wallet_disable.py
wallet_dump.py
wallet_encryption.py
wallet_fallbackfee.py
wallet_fast_rescan.py
wallet_fundrawtransaction.py
wallet_gethdkeys.py
wallet_groups.py
wallet_hd.py
wallet_implicitsegwit.py
wallet_import_rescan.py
wallet_import_with_label.py
wallet_importdescriptors.py
wallet_importmulti.py
wallet_importprunedfunds.py
wallet_inactive_hdchains.py
wallet_keypool.py
wallet_keypool_topup.py
wallet_labels.py
wallet_listdescriptors.py
wallet_listreceivedby.py
wallet_listsinceblock.py
wallet_listtransactions.py
wallet_migration.py
wallet_miniscript.py
wallet_multisig_descriptor_psbt.py
wallet_multiwallet.py
wallet_orphanedreward.py
wallet_pruning.py
wallet_reindex.py
wallet_reorgsrestore.py
wallet_rescan_unconfirmed.py
wallet_resendwallettransactions.py
wallet_send.py
wallet_sendall.py
wallet_sendmany.py
wallet_signer.py
wallet_signmessagewithaddress.py
wallet_signrawtransactionwithwallet.py
wallet_simulaterawtx.py
wallet_spend_unconfirmed.py
wallet_startup.py
wallet_taproot.py
wallet_timelock.py
wallet_transactiontime_rescan.py
wallet_txn_clone.py
wallet_txn_doublespend.py
wallet_upgradewallet.py
wallet_watchonly.py

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Assuming the build directory is build, running build/test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.
  • Use platform.system() for detecting the running operating system and os.name to check whether it's a POSIX system (see also the skip_if_platform_not_{linux,posix} methods in the BitcoinTestFramework class, which can be used to skip a whole test depending on the platform).

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: