mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-08 14:34:53 -05:00
c3fad1f29d
Before this commit, there are only two possibly outcomes for the "more" prediction
in Transport::GetBytesToSend():
* true: the transport itself has more to send, so the answer is certainly yes.
* false: the transport has nothing further to send, but if vSendMsg has more message(s)
left, that still will result in more wire bytes after the next
SetMessageToSend().
For the BIP324 v2 transport, there will arguably be a third state:
* definitely not: the transport has nothing further to send, but even if vSendMsg has
more messages left, they can't be sent (right now). This happens
before the handshake is complete.
To implement this, we move the entire decision logic to the Transport, by adding a
boolean to GetBytesToSend(), called have_next_message, which informs the transport
whether more messages are available. The return values are still true and false, but
they mean "definitely yes" and "definitely no", rather than "yes" and "maybe".
|
||
|---|---|---|
| .. | ||
| blockfilter.cpp | ||
| blockfilter.h | ||
| chainstate.h | ||
| coins.cpp | ||
| coins.h | ||
| index.cpp | ||
| index.h | ||
| json.cpp | ||
| json.h | ||
| logging.cpp | ||
| logging.h | ||
| mining.cpp | ||
| mining.h | ||
| net.cpp | ||
| net.h | ||
| poolresourcetester.h | ||
| random.cpp | ||
| random.h | ||
| README.md | ||
| script.cpp | ||
| script.h | ||
| setup_common.cpp | ||
| setup_common.h | ||
| str.cpp | ||
| str.h | ||
| transaction_utils.cpp | ||
| transaction_utils.h | ||
| txmempool.cpp | ||
| txmempool.h | ||
| validation.cpp | ||
| validation.h | ||
| xoroshiro128plusplus.h | ||
Test library
This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).
Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.
The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common
defines the common test setup for all test binaries. The test binaries will handle the global state when they
instantiate the BasicTestingSetup (or one of its derived classes).