0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
bitcoin-core/src/test
fanquake 45b2a91897
Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup
9d1dbbd4ce scripted-diff: Fix bitcoin_config_h includes (TheCharlatan)

Pull request description:

  As mentioned in https://github.com/bitcoin/bitcoin/pull/26924#issuecomment-1403449932 and https://github.com/bitcoin/bitcoin/pull/29263#issuecomment-1922334399, it is currently not safe to remove `bitcoin-config.h` includes from headers because some unrelated file might be depending on it.

  See also #26972 for discussion.

  Solve this by including the file directly everywhere it's required, regardless of whether or not it's already included by another header.

  There should be no functional change here, but it will allow us to safely remove includes from headers in the future.

  ~I'm afraid it's a bit tedious to reproduce these commits, but it's reasonably straightforward:~
  Edit: See note below

  ```bash
  # All commands executed from the src/ subdir.

  # Collect all tokens from bitcoin-config.h.in
  # Isolate the tokens and remove blank lines
  # Replace newlines with | and remove the last trailing one
  # Collect all files which use these tokens
  # Filter out subprojects (proper forwarding can be verified from Makefiles)
  # Filter out .rc files
  # Save to a text file
  git grep -E -l `grep undef config/bitcoin-config.h.in | cut -d" " -f2 | grep -v '^$' | tr '\n' '|' | sed 's/|$//'` | grep -v -e "^leveldb/" -e "^secp256k1/" -e "^crc32c/" -e "^minisketch/" -e "^Makefile" -e "\.rc$" > files-with-config-include.txt

  # Find all files from the above list which don't include bitcoin-config.h
  git grep -L -E "config/bitcoin-config.h" -- `cat files-with-config-include.txt`

  # Include them manually with the exception of some files in crypto:
  # crypto/sha256_arm_shani.cpp crypto/sha256_avx2.cpp crypto/sha256_sse41.cpp crypto/sha256_x86_shani.cpp
  # These are exceptions which don't use bitcoin-config.h, rather the Makefile.am adds these cppflags manually.

  # Commit changes. This should match the first commit of this PR.

  # Use the same search as above to find all files which DON'T use any config tokens
  git grep -E -L `grep undef config/bitcoin-config.h.in | cut -d" " -f2 | grep -v '^$' | tr '\n' '|' | sed 's/|$//'` | grep -v -e "^leveldb/" -e "^secp256k1/" -e "^crc32c/" -e "^minisketch/" -e "^Makefile" -e "\.rc$" > files-without-config-include.txt

  # Manually remove the includes and commit changes. This should match the second commit of this PR.
  ```

  Edit: I'll keep this old description for posterity, but the manual approach has been replaced with a scripted diff from TheCharlatan

ACKs for top commit:
  maflcko:
    ACK 9d1dbbd4ce 🚪
  TheCharlatan:
    ACK 9d1dbbd4ce
  hebasto:
    ACK 9d1dbbd4ce, I have reviewed the code and it looks OK.
  fanquake:
    ACK 9d1dbbd4ce

Tree-SHA512: f11ddc4ae6a887f96b954a6b77f310558ddb271088a3fda3edc833669c4251b7f392515224bbb8e5f67eb2c799b4ffed3b07d96454e82ec635c686d0df545872
2024-02-20 13:07:48 +00:00
..
data Add test for negative transaction version w/ CSV to tx_valid.json 2024-01-11 15:05:01 -06:00
fuzz Merge bitcoin/bitcoin#29413: fuzz: increase length of string used for NetWhitelist{bind}Permissions::TryParse 2024-02-13 11:47:10 -03:00
util Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup 2024-02-20 13:07:48 +00:00
.gitignore test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
addrman_tests.cpp doc, test: Test and explain service flag handling 2024-01-15 16:19:53 -05:00
allocator_tests.cpp
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp
arith_uint256_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp
bip324_tests.cpp
blockchain_tests.cpp refactor: rpc: Pass CBlockIndex by reference instead of pointer 2023-12-07 12:05:21 +01:00
blockencodings_tests.cpp scripted-diff: Use DataStream in most places 2023-11-28 12:42:37 +01:00
blockfilter_index_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
blockfilter_tests.cpp
blockmanager_tests.cpp refactor: Remove calls to StartShutdown from KernelNotifications 2023-12-04 15:39:15 -04:00
bloom_tests.cpp Remove unused CDataStream 2023-11-30 11:27:54 +01:00
bswap_tests.cpp
checkqueue_tests.cpp
coins_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
coinstatsindex_tests.cpp refactor: Remove call to ShutdownRequested from IndexWaitSynced 2023-12-04 15:39:15 -04:00
compilerbug_tests.cpp
compress_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
crypto_tests.cpp
cuckoocache_tests.cpp
dbwrapper_tests.cpp
denialofservice_tests.cpp
descriptor_tests.cpp wallet: fix key parsing check for miniscript expressions in ParseScript 2023-12-08 06:54:00 -03:00
disconnected_transactions.cpp
flatfile_tests.cpp
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp
hash_tests.cpp
headers_sync_chainwork_tests.cpp
httpserver_tests.cpp
i2p_tests.cpp
interfaces_tests.cpp
ipc_test.capnp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.cpp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.h multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_tests.cpp test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
key_io_tests.cpp
key_tests.cpp
logging_tests.cpp logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace 2023-12-20 15:59:48 +10:00
main.cpp
Makefile
mempool_tests.cpp
merkle_tests.cpp
merkleblock_tests.cpp refactor: Use Txid in CMerkleBlock 2023-11-28 17:49:41 +01:00
miner_tests.cpp refactor: Fix timedata includes 2024-02-01 13:52:05 +01:00
miniminer_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniscript_tests.cpp
minisketch_tests.cpp
multisig_tests.cpp
net_peer_connection_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
net_peer_eviction_tests.cpp
net_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
netbase_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
orphanage_tests.cpp fuzz: Improve fuzzing stability for txorphan harness 2023-12-08 13:14:46 +00:00
peerman_tests.cpp test: add coverage for peerman adaptive connections service flags 2024-01-23 10:25:15 -03:00
pmt_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
policy_fee_tests.cpp
policyestimator_tests.cpp tx fees: update m_from_disconnected_block to m_mempool_limit_bypassed 2024-01-02 12:41:01 +01:00
pool_tests.cpp pool: change memusage_test to use int64_t, add allocation check 2023-11-20 17:10:34 +01:00
pow_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
prevector_tests.cpp
raii_event_tests.cpp
random_tests.cpp
rbf_tests.cpp [refactor] change Workspace::m_conflicts and adjacent funcs/structs to use Txid 2024-01-16 14:20:33 +00:00
README.md test: Add makefile target for running unit tests 2024-02-03 17:59:43 +01:00
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp
sanity_tests.cpp
scheduler_tests.cpp
script_p2sh_tests.cpp tests: test both settings for permitbaremultisig in p2sh tests 2023-12-15 18:37:24 +10:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
script_tests.cpp scripted-diff: Fix bitcoin_config_h includes 2024-02-13 20:10:44 +00:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp
serialize_tests.cpp
settings_tests.cpp init: improve corrupted/empty settings file error msg 2024-01-22 10:50:03 -03:00
sighash_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
sigopcount_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
skiplist_tests.cpp
sock_tests.cpp
span_tests.cpp
streams_tests.cpp refactor: SpanReader without nVersion 2023-11-28 12:42:07 +01:00
sync_tests.cpp
system_tests.cpp scripted-diff: Fix bitcoin_config_h includes 2024-02-13 20:10:44 +00:00
timedata_tests.cpp
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning 2024-02-09 23:37:57 -05:00
translation_tests.cpp
txindex_tests.cpp refactor: Remove call to ShutdownRequested from IndexWaitSynced 2023-12-04 15:39:15 -04:00
txpackage_tests.cpp refactor: share and use GenerateRandomKey helper 2023-12-23 13:26:00 +01:00
txreconciliation_tests.cpp
txrequest_tests.cpp
txvalidation_tests.cpp [test] PackageV3Checks with inheritance violation in mempool ancestor 2024-02-12 14:47:12 +00:00
txvalidationcache_tests.cpp
uint256_tests.cpp Merge bitcoin/bitcoin#28924: refactor: Remove unused and fragile string interface from arith_uint256 2023-12-07 16:02:05 +00:00
util_tests.cpp Merge bitcoin/bitcoin#28075: util: Remove DirIsWritable, GetUniquePath 2023-12-13 10:06:16 +00:00
util_threadnames_tests.cpp
validation_block_tests.cpp
validation_chainstate_tests.cpp
validation_chainstatemanager_tests.cpp refactor: Fix timedata includes 2024-02-01 13:52:05 +01:00
validation_flush_tests.cpp
validation_tests.cpp
validationinterface_tests.cpp
versionbits_tests.cpp
xoroshiro128plusplus_tests.cpp

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check, which includes unit tests from subtrees, or make && make -C src check-unit for just the unit tests.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred