Ryan Ofsky 6663c802fe Merge bitcoin/bitcoin#25634: wallet, tests: Expand and test when the blank wallet flag should be un/set ... cdba23db35 wallet: Document blank flag use in descriptor wallets (Ryan Ofsky) 43310200dc wallet: Ensure that the blank wallet flag is unset after imports (Andrew Chow) e9379f1ffa rpc, wallet: Include information about blank flag (Andrew Chow) Pull request description: The `blank` wallet flag is used to indicate that the wallet intentionally does not have any keys, scripts, or descriptors, and it prevents the automatic generation of those things for such a wallet. Once the wallet contains any of those data, it is unnecessary, and possibly incorrect, to have `blank` set. This PR fixes a few places where this was not properly happening. It also adds a test for this unset behavior. ACKs for top commit: S3RK: reACK cdba23db35 ryanofsky: Code review ACK cdba23db35. Only change since last review is dropping the commit which makes createwallet RPC set BLANK flag automatically when DISABLE_PRIVATE_KEYS flag is set Tree-SHA512: 85bc2a9754df0531575d5c8f4ad7e8f38dcd50083dc29b3283dacf56feae842e81f34654c5e1781f2dadb0560ff80e454bbc8ca3b2d1fab1b236499ae9abd7da		2023-06-14 09:30:39 -04:00
..
bench	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
common	scripted-diff: move settings to common namespace	2023-05-30 17:26:51 +02:00
compat	refactor: don't avoid sys/types.h on when building for Windows	2023-04-03 14:44:48 +01:00
config
consensus	Use int32_t type for most transaction size/weight values	2023-06-12 19:47:19 +01:00
crc32c
crypto	scripted-diff: Use platform-agnostic ALWAYS_INLINE macro	2023-05-04 20:58:01 +01:00
index	refactor: index: use AbortNode in fatal error helper	2023-06-08 16:38:36 -03:00
init	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
interfaces	Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors	2023-06-12 12:54:49 -04:00
ipc	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
kernel	Use int32_t type for most transaction size/weight values	2023-06-12 19:47:19 +01:00
leveldb
logging
minisketch
node	Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors	2023-06-12 12:54:49 -04:00
policy	Use int32_t type for most transaction size/weight values	2023-06-12 19:47:19 +01:00
primitives
qt	Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors	2023-06-12 12:54:49 -04:00
rpc	Merge bitcoin/bitcoin#27501: mempool / rpc: add getprioritisedtransactions, delete a mapDeltas entry when delta==0	2023-06-07 03:29:05 -04:00
script	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
secp256k1	Update src/secp256k1 to latest upstream master (v0.3.1 + CI fix)	2023-04-14 10:35:51 -04:00
support	Add pool based memory resource & allocator	2023-03-23 19:38:38 +01:00
test	Merge bitcoin/bitcoin#27876: test: (refactor) Use datadir from options in chainstatemanager test	2023-06-13 16:28:16 -04:00
univalue	Merge bitcoin/bitcoin#27256: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it	2023-06-02 16:18:11 +01:00
util	move-only: Move settings to the common library	2023-05-30 17:26:47 +02:00
wallet	Merge bitcoin/bitcoin#25634: wallet, tests: Expand and test when the blank wallet flag should be un/set	2023-06-14 09:30:39 -04:00
zmq	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
.bear-tidy-config
.clang-format
.clang-tidy	clang-tidy: Exclude performance-* checks rather including them	2023-03-26 20:18:13 +01:00
addrdb.cpp	scripted-diff: move settings to common namespace	2023-05-30 17:26:51 +02:00
addrdb.h	fix includes for touched header files (iwyu)	2023-05-29 13:26:31 +02:00
addrman.cpp	addrman: add functionality to select by network	2023-03-17 17:59:02 -07:00
addrman.h	doc: clarify new_only param for Select function	2023-03-17 18:02:40 -07:00
addrman_impl.h	addrman: add functionality to select by network	2023-03-17 17:59:02 -07:00
arith_uint256.cpp
arith_uint256.h
attributes.h	Introduce platform-agnostic ALWAYS_INLINE macro	2023-05-04 20:57:51 +01:00
banman.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
banman.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
base58.cpp
base58.h
bech32.cpp
bech32.h
bitcoin-chainstate.cpp	kernel: Remove chainparams, chainparamsbase, args, settings from kernel library	2023-05-30 17:15:22 +02:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-util-res.rc
bitcoin-util.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoind-res.rc
bitcoind.cpp	refactor: decouple early return commands from AppInit	2023-06-10 11:10:29 -03:00
blockencodings.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
blockencodings.h
blockfilter.cpp
blockfilter.h
chain.cpp
chain.h
chainparams.cpp	test: Throw error when -signetchallenge is non-hex	2023-05-25 19:24:05 +02:00
chainparams.h	test: Throw error when -signetchallenge is non-hex	2023-05-25 19:24:05 +02:00
chainparamsbase.cpp	refactor: Use ChainType enum exhaustively	2023-05-10 10:39:58 +02:00
chainparamsbase.h	refactor: Use ChainType enum exhaustively	2023-05-10 10:39:58 +02:00
chainparamsseeds.h	p2p: update hardcoded mainnet seeds for 25.x	2023-04-20 06:08:22 -07:00
checkqueue.h	refactor: Use move semantics in CCheckQueue::Loop	2023-03-21 13:04:21 +00:00
clientversion.cpp
clientversion.h
coins.cpp	Use PoolAllocator for CCoinsMap	2023-03-23 19:38:38 +01:00
coins.h	Use PoolAllocator for CCoinsMap	2023-03-23 19:38:38 +01:00
compressor.cpp
compressor.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
cuckoocache.h
dbwrapper.cpp	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
dbwrapper.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
external_signer.cpp	Fix clang-tidy performance-unnecessary-copy-initialization warnings	2023-05-09 18:48:52 +02:00
external_signer.h	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
flatfile.cpp	refactor: Extract util/fs_helpers from util/system	2023-03-23 12:52:00 +01:00
flatfile.h	Merge bitcoin/bitcoin#27254: refactor: Extract util/fs from util/system	2023-04-03 14:41:22 +01:00
hash.cpp
hash.h
headerssync.cpp
headerssync.h
httprpc.cpp	scripted-diff: Use UniValue::find_value method	2023-05-09 18:47:14 +02:00
httprpc.h
httpserver.cpp	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
httpserver.h
i2p.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
i2p.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
indirectmap.h
init.cpp	Return EXIT_FAILURE on post-init fatal errors	2023-06-09 17:52:23 -03:00
init.h	Return EXIT_FAILURE on post-init fatal errors	2023-06-09 17:52:23 -03:00
key.cpp
key.h
key_io.cpp	use 'byte'/'bytes' for bech32(m) validation error	2023-05-25 06:30:10 +00:00
key_io.h
logging.cpp	Merge bitcoin/bitcoin#27317: log: Check that the timestamp string is non-empty to avoid undefined behavior	2023-04-05 11:50:27 +01:00
logging.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
Makefile.am	move-only: Move settings to the common library	2023-05-30 17:26:47 +02:00
Makefile.bench.include	[bench] add streams findbyte	2023-05-05 06:03:14 -06:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include
Makefile.qt.include
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include	Merge bitcoin/bitcoin#27021: Implement Mini version of BlockAssembler to calculate mining scores	2023-05-19 10:26:19 -04:00
Makefile.test_fuzz.include
Makefile.test_util.include	Add pool based memory resource & allocator	2023-03-23 19:38:38 +01:00
Makefile.univalue.include
mapport.cpp	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
mapport.h
memusage.h	Calculate memory usage correctly for unordered_maps that use PoolAllocator	2023-03-23 19:38:38 +01:00
merkleblock.cpp
merkleblock.h
net.cpp	Merge bitcoin/bitcoin#27467: p2p: skip netgroup diversity follow-up	2023-06-09 14:21:19 -04:00
net.h	Support up to 3 parallel compact block txn fetchings	2023-05-23 13:07:49 -04:00
net_permissions.cpp	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
net_permissions.h
net_processing.cpp	Remove mapRelay	2023-06-08 11:52:30 +02:00
net_processing.h	Support up to 3 parallel compact block txn fetchings	2023-05-23 13:07:49 -04:00
net_types.cpp
net_types.h
netaddress.cpp
netaddress.h
netbase.cpp	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
netbase.h	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
netgroup.cpp
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp	Don't return OutputType::UNKNOWN in ParseOutputType	2023-04-16 23:48:05 +02:00
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
protocol.h	doc: Remove unused NO_BLOOM_VERSION constant	2023-05-15 10:18:58 +02:00
psbt.cpp	Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex	2023-04-21 14:06:12 -04:00
psbt.h	Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex	2023-04-21 14:06:12 -04:00
pubkey.cpp
pubkey.h
random.cpp	random: switch to using getrandom() directly	2023-05-20 17:20:01 +01:00
random.h
randomenv.cpp	refactor: don't avoid sys/types.h on when building for Windows	2023-04-03 14:44:48 +01:00
randomenv.h
rest.cpp	rest: bugfix, fix crash error when calling /deploymentinfo	2023-06-12 10:24:14 -03:00
rest.h
reverse_iterator.h
scheduler.cpp
scheduler.h
serialize.h
shutdown.cpp	Return EXIT_FAILURE on post-init fatal errors	2023-06-09 17:52:23 -03:00
shutdown.h	Return EXIT_FAILURE on post-init fatal errors	2023-06-09 17:52:23 -03:00
signet.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
signet.h
span.h
streams.h	streams: Drop confusing DataStream::Serialize method and << operator	2023-06-01 10:27:33 -04:00
sync.cpp
sync.h
threadsafety.h
timedata.cpp	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
timedata.h
tinyformat.h
torcontrol.cpp	p2p, refactor: return vector/optional<CService> in Lookup	2023-05-26 13:40:02 -03:00
torcontrol.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
txdb.cpp	refactor: Replace std::optional<bilingual_str> with util::Result	2023-05-24 08:55:47 -04:00
txdb.h	fix includes for touched header files (iwyu)	2023-05-29 13:26:31 +02:00
txmempool.cpp	Remove txmempool implicit-integer-sign-change sanitizer suppressions	2023-06-12 19:48:47 +01:00
txmempool.h	Use int32_t type for most transaction size/weight values	2023-06-12 19:47:19 +01:00
txorphanage.cpp
txorphanage.h
txrequest.cpp	Add public Boost headers explicitly	2023-05-31 15:43:01 +01:00
txrequest.h
uint256.cpp
uint256.h
undo.h
validation.cpp	Merge bitcoin/bitcoin#27357: validation: Move warningcache to ChainstateManager and rename to m_warningcache	2023-06-12 13:20:18 +01:00
validation.h	Merge bitcoin/bitcoin#27357: validation: Move warningcache to ChainstateManager and rename to m_warningcache	2023-06-12 13:20:18 +01:00
validationinterface.cpp
validationinterface.h
version.h	doc: Remove unused NO_BLOOM_VERSION constant	2023-05-15 10:18:58 +02:00
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
warnings.h