foster/deno - Foster's Laboratory

foster/deno

mirror of https://github.com/denoland/deno.git synced 2025-03-11 14:47:26 -04:00

2 lines

26 B

JavaScript

Raw Normal View History

fix(ext/node): add missing _preloadModules hook (#18447) This internal node hook is used by libraries such as `ts-node` when used as a require hook `node -r ts-node/register`. That combination is often used with test frameworks like `mocha` or `jasmine`. We had a reference to `Module._preloadModules` in our code, but the implementation was missing. While fixing this I also noticed that the `fakeParent` module that we create internally always threw because of the `pathDirname` check on the module id in the constructor of `Mdoule`. So this code path was probably broken for a while. ```txt ✖ ERROR: Error: Empty filepath. at pathDirname (ext:deno_node/01_require.js:245:11) at new Module (ext:deno_node/01_require.js:446:15) at Function.Module._resolveFilename (ext:deno_node/01_require.js:754:28) at Function.resolve (ext:deno_node/01_require.js:1015:19) ```

2023-03-27 21:54:22 +02:00

globalThis.foo = "Hello";