chore: upgrade rusty_v8 to 0.72.0 (#19228)

This commit updates rusty_v8 to 0.72.0 and by extension
V8 to version 11.5.150.1.

.github/workflows/ci.generate.ts

@@ -17,7 +17,7 @@ const Runners = (() => {
 })();
 // bump the number at the start when you want to purge the cache
 const prCacheKeyPrefix =
-  "27-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-";
+  "28-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-";
 
 const installPkgsCommand =
   "sudo apt-get install --no-install-recommends debootstrap clang-15 lld-15";
@@ -480,7 +480,7 @@ const ci = {
               "~/.cargo/git/db",
             ].join("\n"),
             key:
-              "27-cargo-home-${{ matrix.os }}-${{ hashFiles('Cargo.lock') }}",
+              "28-cargo-home-${{ matrix.os }}-${{ hashFiles('Cargo.lock') }}",
           },
         },
         {

.github/workflows/ci.yml

@@ -293,7 +293,7 @@ jobs:
             ~/.cargo/registry/index
             ~/.cargo/registry/cache
             ~/.cargo/git/db
-          key: '27-cargo-home-${{ matrix.os }}-${{ hashFiles(''Cargo.lock'') }}'
+          key: '28-cargo-home-${{ matrix.os }}-${{ hashFiles(''Cargo.lock'') }}'
         if: '!(github.event_name == ''pull_request'' && matrix.skip_pr)'
       - name: Restore cache build output (PR)
         uses: actions/cache/restore@v3
@@ -305,7 +305,7 @@ jobs:
             !./target/*/*.zip
             !./target/*/*.tar.gz
           key: never_saved
-          restore-keys: '27-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-'
+          restore-keys: '28-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-'
       - name: Apply and update mtime cache
         if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (!startsWith(github.ref, ''refs/tags/''))'
         uses: ./.github/mtime_cache
@@ -589,7 +589,7 @@ jobs:
             !./target/*/gn_out
             !./target/*/*.zip
             !./target/*/*.tar.gz
-          key: '27-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
+          key: '28-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
   publish-canary:
     name: publish canary
     runs-on: ubuntu-22.04

Cargo.lock

@@ -5711,9 +5711,9 @@ dependencies = [
 
 [[package]]
 name = "v8"
-version = "0.71.2"
+version = "0.72.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1a4bbfd886a9c2f87170438c0cdb6b1ddbfe80412ab591c83d24c7e48e487313"
+checksum = "d5c1d09f66ab7f69e36211c5488d47f683fef6b65b83a627cfd75ed9cef254e6"
 dependencies = [
  "bitflags 1.3.2",
  "fslock",

Cargo.toml

@@ -41,7 +41,7 @@ license = "MIT"
 repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
-v8 = { version = "0.71.2", default-features = false }
+v8 = { version = "0.72.0", default-features = false }
 deno_ast = { version = "0.26.0", features = ["transpiling"] }
 
 deno_core = { version = "0.187.0", path = "./core" }

cli/tests/node_compat/test.ts

@@ -66,9 +66,15 @@ async function runTest(t: Deno.TestContext, path: string): Promise<void> {
 
       const v8Flags = ["--stack-size=4000"];
       const testSource = await Deno.readTextFile(testCase);
+      const envVars: Record<string, string> = {};
       // TODO(kt3k): Parse `Flags` directive correctly
       if (testSource.includes("Flags: --expose_externalize_string")) {
         v8Flags.push("--expose-externalize-string");
+        // TODO(bartlomieju): disable verifying globals if that V8 flag is
+        // present. Even though we should be able to pass a list of globals
+        // that are allowed, it doesn't work, because the list is expected to
+        // contain actual JS objects, not strings :)).
+        envVars["NODE_TEST_KNOWN_GLOBALS"] = "0";
       }
 
       const args = [
@@ -88,6 +94,7 @@ async function runTest(t: Deno.TestContext, path: string): Promise<void> {
         args,
         env: {
           TEST_SERIAL_ID: String(testSerialId++),
+          ...envVars,
         },
         cwd,
       });

cli/tests/testdata/run/worker_close_in_wasm_reactions.js.out

@@ -1,2 +1,2 @@
-Error: CompileError: WebAssembly.compile(): expected  length: @+10
+Error: CompileError: WebAssembly.compile(): reached end while decoding  length: @+10
     at file:///[WILDCARD]/close_in_wasm_reactions.js:18:13