foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(coverage): escape source code in html coverage report (#21531)

Browse source
This commit is contained in:
Yoshiya Hinosawa 2023-12-11 19:24:20 +09:00 • committed by GitHub
parent e9ab9ba9f0
commit 073e341faf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/tests/integration/coverage_tests.rs
View file

@ -553,6 +553,8 @@ fn test_html_reporter() {
let bar_ts_html = let bar_ts_html =
fs::read_to_string(tempdir.join("html").join("bar.ts.html")).unwrap(); fs::read_to_string(tempdir.join("html").join("bar.ts.html")).unwrap();
assert!(bar_ts_html.contains("<h1>Coverage report for bar.ts</h1>")); assert!(bar_ts_html.contains("<h1>Coverage report for bar.ts</h1>"));
// Check <T> in source code is escaped to &lt;T&gt;
assert!(bar_ts_html.contains("&lt;T&gt;"));
let baz_index_html = let baz_index_html =
fs::read_to_string(tempdir.join("html").join("baz").join("index.html")) fs::read_to_string(tempdir.join("html").join("baz").join("index.html"))

2
cli/tests/testdata/coverage/multisource/bar.ts vendored
View file

@ -1,4 +1,4 @@
export function bar(cond: boolean) { export function bar<T>(cond: T) {
if (cond) { if (cond) {
return 1; return 1;
} else { } else {

7
cli/tools/coverage/reporter.rs
View file

@ -512,7 +512,7 @@ impl HtmlCoverageReporter {
/// Creates <table> of single file code coverage. /// Creates <table> of single file code coverage.
pub fn create_html_code_table( pub fn create_html_code_table(
&self, &self,
file_text: &String, file_text: &str,
report: &CoverageReport, report: &CoverageReport,
) -> String { ) -> String {
let line_num = file_text.lines().count(); let line_num = file_text.lines().count();
@ -548,6 +548,11 @@ impl HtmlCoverageReporter {
.collect::<Vec<_>>() .collect::<Vec<_>>()
.join("\n"); .join("\n");
let file_text = file_text
.replace('&', "&amp;")
.replace('<', "&lt;")
.replace('>', "&gt;");
// TODO(kt3k): Add syntax highlight to source code // TODO(kt3k): Add syntax highlight to source code
format!( format!(
"<table class='coverage'> "<table class='coverage'>