foster/deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-03-03 17:34:47 -05:00
Code Issues Packages 1 Wiki Activity

perf(lsp): fix redundant serialization of sources (#21435)

Browse source
This commit is contained in:
Nayeem Rahman 2023-12-02 23:28:46 +00:00 • committed by GitHub
parent f29075ae4c
commit 0f990d9d92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
cli/tsc/99_main_compiler.js
View file

@ -555,9 +555,13 @@ delete Object.prototype.__proto__;
} }
/** @type {{ data: string; scriptKind: ts.ScriptKind; version: string; }} */ /** @type {{ data: string; scriptKind: ts.ScriptKind; version: string; }} */
const { data, scriptKind, version } = ops.op_load( const fileInfo = ops.op_load(
{ specifier }, { specifier },
); );
if (!fileInfo) {
return undefined;
}
const { data, scriptKind, version } = fileInfo;
assert( assert(
data != null, data != null,
`"data" is unexpectedly null for "${specifier}".`, `"data" is unexpectedly null for "${specifier}".`,
@ -713,10 +717,6 @@ delete Object.prototype.__proto__;
if (logDebug) { if (logDebug) {
debug(`host.getScriptVersion("${specifier}")`); debug(`host.getScriptVersion("${specifier}")`);
} }
const sourceFile = sourceFileCache.get(specifier);
if (sourceFile) {
return sourceFile.version ?? "1";
}
// tsc requests the script version multiple times even though it can't // tsc requests the script version multiple times even though it can't
// possibly have changed, so we will memoize it on a per request basis. // possibly have changed, so we will memoize it on a per request basis.
if (scriptVersionCache.has(specifier)) { if (scriptVersionCache.has(specifier)) {
@ -730,30 +730,26 @@ delete Object.prototype.__proto__;
if (logDebug) { if (logDebug) {
debug(`host.getScriptSnapshot("${specifier}")`); debug(`host.getScriptSnapshot("${specifier}")`);
} }
const sourceFile = sourceFileCache.get(specifier); let sourceFile = sourceFileCache.get(specifier);
if (
!specifier.startsWith(ASSETS_URL_PREFIX) &&
sourceFile?.version != this.getScriptVersion(specifier)
) {
sourceFileCache.delete(specifier);
sourceFile = undefined;
}
if (!sourceFile) {
sourceFile = this.getSourceFile(
specifier,
specifier.endsWith(".json")
? ts.ScriptTarget.JSON
: ts.ScriptTarget.ESNext,
);
}
if (sourceFile) { if (sourceFile) {
return { return ts.ScriptSnapshot.fromString(sourceFile.text);
getText(start, end) {
return sourceFile.text.substring(start, end);
},
getLength() {
return sourceFile.text.length;
},
getChangeRange() {
return undefined;
},
};
}
const fileInfo = ops.op_load(
{ specifier },
);
if (fileInfo) {
scriptVersionCache.set(specifier, fileInfo.version);
return ts.ScriptSnapshot.fromString(fileInfo.data);
} else {
return undefined;
} }
return undefined;
}, },
}; };